Note: I've decided to removed the pxelinux.cfg patches from this series
for now, since full pxelinux support requires to parse some additional
DHCP options (see https://tools.ietf.org/html/rfc5071), and for this, the
SLOF libnet code needs to be changed first. So I guess I first have to
implement pxelinux.cfg support for PPC, too, which will likely take a
little bit longer...
Thus to keep this series short and reviewable, and to avoid that the other
patches bit-rot on my hard disk, I've now only included the patches that
are not related to pxelinux.cfg.

The first patch is just a minor code refactoring which should not have
any visible impact, but makes the following patches easier.

The second patch makes sure that we leave the machine in a sane state
before jumping into the Linux kernel - i.e. the netboot firmware now
resets the machine with diag308, too, just like the main s390-ccw
is doing it already.

Patch 3 adds support for loading kernels via .INS configuration files.
You can find these .INS config files on ISO images, so with this patch,
it should be possible to boot if the TFTP server is configured to use
the contents of such an ISO image.

v4:
 - s/uninit/release/ in the title of the first patch
 - Set schid of the network device in 184
 - Jump to 0x10000 start address if S390EP magic is available

Thomas Huth (3):
  pc-bios/s390-ccw/net: Split up net_load() into init, load and release
    parts
  pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to
    the OS
  pc-bios/s390-ccw/net: Add support for .INS config files

 pc-bios/s390-ccw/Makefile    |   4 +-
 pc-bios/s390-ccw/bootmap.c   |  63 +---------------
 pc-bios/s390-ccw/bootmap.h   |   4 --
 pc-bios/s390-ccw/jump2ipl.c  |  91 +++++++++++++++++++++++
 pc-bios/s390-ccw/netboot.mak |   3 +-
 pc-bios/s390-ccw/netmain.c   | 168 +++++++++++++++++++++++++++++++++++--------
 pc-bios/s390-ccw/s390-ccw.h  |   4 ++
 7 files changed, 240 insertions(+), 97 deletions(-)
 create mode 100644 pc-bios/s390-ccw/jump2ipl.c

-- 
1.8.3.1

On 26.04.2018 11:28, Thomas Huth wrote:
> Note: I've decided to removed the pxelinux.cfg patches from this series
> for now, since full pxelinux support requires to parse some additional
> DHCP options (see https://tools.ietf.org/html/rfc5071), and for this, the
> SLOF libnet code needs to be changed first. So I guess I first have to
> implement pxelinux.cfg support for PPC, too, which will likely take a
> little bit longer...

I don't think it would be wrong to include it for now. We just don't
support all options yet - that can be fixed later. If the current state
is what 99.9999% of all users will need, than include it. If it is a
crucial feature, than I agree.

> Thus to keep this series short and reviewable, and to avoid that the other
> patches bit-rot on my hard disk, I've now only included the patches that
> are not related to pxelinux.cfg.
> 
> The first patch is just a minor code refactoring which should not have
> any visible impact, but makes the following patches easier.
> 
> The second patch makes sure that we leave the machine in a sane state
> before jumping into the Linux kernel - i.e. the netboot firmware now
> resets the machine with diag308, too, just like the main s390-ccw
> is doing it already.
> 
> Patch 3 adds support for loading kernels via .INS configuration files.
> You can find these .INS config files on ISO images, so with this patch,
> it should be possible to boot if the TFTP server is configured to use
> the contents of such an ISO image.
> 
> v4:
>  - s/uninit/release/ in the title of the first patch
>  - Set schid of the network device in 184
>  - Jump to 0x10000 start address if S390EP magic is available
> 
> Thomas Huth (3):
>   pc-bios/s390-ccw/net: Split up net_load() into init, load and release
>     parts
>   pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to
>     the OS
>   pc-bios/s390-ccw/net: Add support for .INS config files
> 
>  pc-bios/s390-ccw/Makefile    |   4 +-
>  pc-bios/s390-ccw/bootmap.c   |  63 +---------------
>  pc-bios/s390-ccw/bootmap.h   |   4 --
>  pc-bios/s390-ccw/jump2ipl.c  |  91 +++++++++++++++++++++++
>  pc-bios/s390-ccw/netboot.mak |   3 +-
>  pc-bios/s390-ccw/netmain.c   | 168 +++++++++++++++++++++++++++++++++++--------
>  pc-bios/s390-ccw/s390-ccw.h  |   4 ++
>  7 files changed, 240 insertions(+), 97 deletions(-)
>  create mode 100644 pc-bios/s390-ccw/jump2ipl.c
> 


-- 

Thanks,

David / dhildenb

On 04/27/2018 03:14 PM, David Hildenbrand wrote:
> On 26.04.2018 11:28, Thomas Huth wrote:
>> Note: I've decided to removed the pxelinux.cfg patches from this series
>> for now, since full pxelinux support requires to parse some additional
>> DHCP options (see https://tools.ietf.org/html/rfc5071), and for this, the
>> SLOF libnet code needs to be changed first. So I guess I first have to
>> implement pxelinux.cfg support for PPC, too, which will likely take a
>> little bit longer...
> 
> I don't think it would be wrong to include it for now. We just don't
> support all options yet - that can be fixed later. If the current state
> is what 99.9999% of all users will need, than include it. If it is a
> crucial feature, than I agree.

Agreed. 
Lets start with these 3 patches and then do a followup review of the "pxe light"
patch so that we can keep the discussion in there.

> 
>> Thus to keep this series short and reviewable, and to avoid that the other
>> patches bit-rot on my hard disk, I've now only included the patches that
>> are not related to pxelinux.cfg.
>>
>> The first patch is just a minor code refactoring which should not have
>> any visible impact, but makes the following patches easier.
>>
>> The second patch makes sure that we leave the machine in a sane state
>> before jumping into the Linux kernel - i.e. the netboot firmware now
>> resets the machine with diag308, too, just like the main s390-ccw
>> is doing it already.
>>
>> Patch 3 adds support for loading kernels via .INS configuration files.
>> You can find these .INS config files on ISO images, so with this patch,
>> it should be possible to boot if the TFTP server is configured to use
>> the contents of such an ISO image.
>>
>> v4:
>>  - s/uninit/release/ in the title of the first patch
>>  - Set schid of the network device in 184
>>  - Jump to 0x10000 start address if S390EP magic is available
>>
>> Thomas Huth (3):
>>   pc-bios/s390-ccw/net: Split up net_load() into init, load and release
>>     parts
>>   pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to
>>     the OS
>>   pc-bios/s390-ccw/net: Add support for .INS config files
>>
>>  pc-bios/s390-ccw/Makefile    |   4 +-
>>  pc-bios/s390-ccw/bootmap.c   |  63 +---------------
>>  pc-bios/s390-ccw/bootmap.h   |   4 --
>>  pc-bios/s390-ccw/jump2ipl.c  |  91 +++++++++++++++++++++++
>>  pc-bios/s390-ccw/netboot.mak |   3 +-
>>  pc-bios/s390-ccw/netmain.c   | 168 +++++++++++++++++++++++++++++++++++--------
>>  pc-bios/s390-ccw/s390-ccw.h  |   4 ++
>>  7 files changed, 240 insertions(+), 97 deletions(-)
>>  create mode 100644 pc-bios/s390-ccw/jump2ipl.c
>>
> 
> 

On 04/26/2018 11:28 AM, Thomas Huth wrote:
> Note: I've decided to removed the pxelinux.cfg patches from this series
> for now, since full pxelinux support requires to parse some additional
> DHCP options (see https://tools.ietf.org/html/rfc5071), and for this, the
> SLOF libnet code needs to be changed first. So I guess I first have to
> implement pxelinux.cfg support for PPC, too, which will likely take a
> little bit longer...
> Thus to keep this series short and reviewable, and to avoid that the other
> patches bit-rot on my hard disk, I've now only included the patches that
> are not related to pxelinux.cfg.
> 
> The first patch is just a minor code refactoring which should not have
> any visible impact, but makes the following patches easier.
> 
> The second patch makes sure that we leave the machine in a sane state
> before jumping into the Linux kernel - i.e. the netboot firmware now
> resets the machine with diag308, too, just like the main s390-ccw
> is doing it already.
> 
> Patch 3 adds support for loading kernels via .INS configuration files.
> You can find these .INS config files on ISO images, so with this patch,
> it should be possible to boot if the TFTP server is configured to use
> the contents of such an ISO image.
> 
> v4:
>  - s/uninit/release/ in the title of the first patch
>  - Set schid of the network device in 184
>  - Jump to 0x10000 start address if S390EP magic is available
> 
> Thomas Huth (3):
>   pc-bios/s390-ccw/net: Split up net_load() into init, load and release
>     parts
>   pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to
>     the OS
>   pc-bios/s390-ccw/net: Add support for .INS config files
> 
>  pc-bios/s390-ccw/Makefile    |   4 +-
>  pc-bios/s390-ccw/bootmap.c   |  63 +---------------
>  pc-bios/s390-ccw/bootmap.h   |   4 --
>  pc-bios/s390-ccw/jump2ipl.c  |  91 +++++++++++++++++++++++
>  pc-bios/s390-ccw/netboot.mak |   3 +-
>  pc-bios/s390-ccw/netmain.c   | 168 +++++++++++++++++++++++++++++++++++--------
>  pc-bios/s390-ccw/s390-ccw.h  |   4 ++
>  7 files changed, 240 insertions(+), 97 deletions(-)
>  create mode 100644 pc-bios/s390-ccw/jump2ipl.c
> 


Not looked into all details but the general idea and patches

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>