I was going to just re-send the previous versions of these, but after
looking I realized it would have the same misuse of vmstate_register(),
and I didn't have a way to work around it.  I had already done the
VMSTATE_VSTRUCT work earlier, so I merged that in.

Changes from v2:
  * Added VMSTATE_VSTRUCT types of vmstate macros that allow the
    specific structure version used to be specified.
  * Reworked the KCS vmstate code to use the new VMSTATE_VSTRUCT
    macros.

Changes from v1:
  * Validate the data values in pre_load functions.
  * For KCS, instead of an old function, create a separate vmstate
    structure for the new version.  The name on the old vmstate
    structure wasn't specific enough, so a new name was needed,
    The old structure is set up to never be sent, but it can be
    received.

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1524670052-28373-1-git-send-email-minyard@acm.org
Subject: [Qemu-devel] [PATCH v3 0/3] ipmi: Fix vmstate transfer

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1524670052-28373-1-git-send-email-minyard@acm.org -> patchew/1524670052-28373-1-git-send-email-minyard@acm.org
 t [tag update]            patchew/20180420145249.32435-1-peter.maydell@linaro.org -> patchew/20180420145249.32435-1-peter.maydell@linaro.org
 t [tag update]            patchew/20180423223337.82366-1-eblake@redhat.com -> patchew/20180423223337.82366-1-eblake@redhat.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
782859090c ipmi: Use proper struct reference for BT vmstate
4324fae8c3 ipmi: Use proper struct reference for KCS vmstate
a72462b176 vmstate: Add a VSTRUCT type

=== OUTPUT BEGIN ===
Checking PATCH 1/3: vmstate: Add a VSTRUCT type...
ERROR: line over 90 characters
#67: FILE: include/migration/vmstate.h:423:
+#define VMSTATE_VSTRUCT_TEST(_field, _state, _test, _version, _vmsd, _type, _struct_version) { \

WARNING: line over 80 characters
#88: FILE: include/migration/vmstate.h:754:
+#define VMSTATE_VSTRUCT_V(_field, _state, _version, _vmsd, _type, _struct_version) \

total: 1 errors, 1 warnings, 140 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/3: ipmi: Use proper struct reference for KCS vmstate...
Checking PATCH 3/3: ipmi: Use proper struct reference for BT vmstate...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com