[Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups

Michael S. Tsirkin posted 2 patches 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1521568357-114127-1-git-send-email-mst@redhat.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 failed
Test s390x passed
linux-headers/asm-arm/bitsperlong.h     |   1 +
linux-headers/asm-arm64/bitsperlong.h   |  24 +
linux-headers/asm-generic/bitsperlong.h |  16 +
linux-headers/asm-generic/unistd.h      | 944 ++++++++++++++++++++++++++++++++
linux-headers/asm-mips/bitsperlong.h    |   9 +
linux-headers/asm-mips/unistd.h         |  44 +-
linux-headers/asm-powerpc/bitsperlong.h |  13 +
linux-headers/asm-s390/bitsperlong.h    |  14 +
linux-headers/asm-x86/bitsperlong.h     |  14 +
scripts/update-linux-headers.sh         |  20 +-
10 files changed, 1086 insertions(+), 13 deletions(-)
create mode 100644 linux-headers/asm-arm/bitsperlong.h
create mode 100644 linux-headers/asm-arm64/bitsperlong.h
create mode 100644 linux-headers/asm-generic/bitsperlong.h
create mode 100644 linux-headers/asm-generic/unistd.h
create mode 100644 linux-headers/asm-mips/bitsperlong.h
create mode 100644 linux-headers/asm-powerpc/bitsperlong.h
create mode 100644 linux-headers/asm-s390/bitsperlong.h
create mode 100644 linux-headers/asm-x86/bitsperlong.h
[Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups
Posted by Michael S. Tsirkin 7 years, 7 months ago
It turns out that we have unistd.h for some architectures but not
others.  We are thus unable to use e.g. usefaultfd on these systems.

Fix up update-linux-headers.sh to make sure we
get it for all architectures which have linux-headers/
(unfortunately this still does not mean "all linux systems").

Tested on x86 only.

Pls consider merging this through the migration tree.

Michael S. Tsirkin (2):
  update-linux-headers.sh: add unistd.h
  linux-headers: add asm-generic/unistd.h

 linux-headers/asm-arm/bitsperlong.h     |   1 +
 linux-headers/asm-arm64/bitsperlong.h   |  24 +
 linux-headers/asm-generic/bitsperlong.h |  16 +
 linux-headers/asm-generic/unistd.h      | 944 ++++++++++++++++++++++++++++++++
 linux-headers/asm-mips/bitsperlong.h    |   9 +
 linux-headers/asm-mips/unistd.h         |  44 +-
 linux-headers/asm-powerpc/bitsperlong.h |  13 +
 linux-headers/asm-s390/bitsperlong.h    |  14 +
 linux-headers/asm-x86/bitsperlong.h     |  14 +
 scripts/update-linux-headers.sh         |  20 +-
 10 files changed, 1086 insertions(+), 13 deletions(-)
 create mode 100644 linux-headers/asm-arm/bitsperlong.h
 create mode 100644 linux-headers/asm-arm64/bitsperlong.h
 create mode 100644 linux-headers/asm-generic/bitsperlong.h
 create mode 100644 linux-headers/asm-generic/unistd.h
 create mode 100644 linux-headers/asm-mips/bitsperlong.h
 create mode 100644 linux-headers/asm-powerpc/bitsperlong.h
 create mode 100644 linux-headers/asm-s390/bitsperlong.h
 create mode 100644 linux-headers/asm-x86/bitsperlong.h

-- 
MST


Re: [Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups
Posted by Michael S. Tsirkin 7 years, 7 months ago
Cc MIPS maintainers.
Can we drop the MIPS blacklist for kvm?
Could you guys pls check?

On Tue, Mar 20, 2018 at 07:52:51PM +0200, Michael S. Tsirkin wrote:
> It turns out that we have unistd.h for some architectures but not
> others.  We are thus unable to use e.g. usefaultfd on these systems.
> 
> Fix up update-linux-headers.sh to make sure we
> get it for all architectures which have linux-headers/
> (unfortunately this still does not mean "all linux systems").
> 
> Tested on x86 only.
> 
> Pls consider merging this through the migration tree.
> 
> Michael S. Tsirkin (2):
>   update-linux-headers.sh: add unistd.h
>   linux-headers: add asm-generic/unistd.h
> 
>  linux-headers/asm-arm/bitsperlong.h     |   1 +
>  linux-headers/asm-arm64/bitsperlong.h   |  24 +
>  linux-headers/asm-generic/bitsperlong.h |  16 +
>  linux-headers/asm-generic/unistd.h      | 944 ++++++++++++++++++++++++++++++++
>  linux-headers/asm-mips/bitsperlong.h    |   9 +
>  linux-headers/asm-mips/unistd.h         |  44 +-
>  linux-headers/asm-powerpc/bitsperlong.h |  13 +
>  linux-headers/asm-s390/bitsperlong.h    |  14 +
>  linux-headers/asm-x86/bitsperlong.h     |  14 +
>  scripts/update-linux-headers.sh         |  20 +-
>  10 files changed, 1086 insertions(+), 13 deletions(-)
>  create mode 100644 linux-headers/asm-arm/bitsperlong.h
>  create mode 100644 linux-headers/asm-arm64/bitsperlong.h
>  create mode 100644 linux-headers/asm-generic/bitsperlong.h
>  create mode 100644 linux-headers/asm-generic/unistd.h
>  create mode 100644 linux-headers/asm-mips/bitsperlong.h
>  create mode 100644 linux-headers/asm-powerpc/bitsperlong.h
>  create mode 100644 linux-headers/asm-s390/bitsperlong.h
>  create mode 100644 linux-headers/asm-x86/bitsperlong.h
> 
> -- 
> MST
> 

Re: [Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups
Posted by Peter Maydell 7 years, 7 months ago
On 20 March 2018 at 18:05, Michael S. Tsirkin <mst@redhat.com> wrote:
> Cc MIPS maintainers.
> Can we drop the MIPS blacklist for kvm?
> Could you guys pls check?

My guess is that MIPS got blacklisted in 1842bdfdbac2ec4
because Marc-André didn't want to deal with the fact that
the mips unistd.h includes another header that would also
need to be synced. Marc-André, I don't suppose you can
remember your reasoning from three years back? :-)

thanks
-- PMM

Re: [Qemu-devel] [PATCH v3 0/2] linux-headers: unistd.h fixups
Posted by Dr. David Alan Gilbert 7 years, 7 months ago
* Michael S. Tsirkin (mst@redhat.com) wrote:
> It turns out that we have unistd.h for some architectures but not
> others.  We are thus unable to use e.g. usefaultfd on these systems.
> 
> Fix up update-linux-headers.sh to make sure we
> get it for all architectures which have linux-headers/
> (unfortunately this still does not mean "all linux systems").
> 
> Tested on x86 only.
> 
> Pls consider merging this through the migration tree.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

and queued for migration;  I'll test build Power and aarch64 as well.

Dave

> Michael S. Tsirkin (2):
>   update-linux-headers.sh: add unistd.h
>   linux-headers: add asm-generic/unistd.h
> 
>  linux-headers/asm-arm/bitsperlong.h     |   1 +
>  linux-headers/asm-arm64/bitsperlong.h   |  24 +
>  linux-headers/asm-generic/bitsperlong.h |  16 +
>  linux-headers/asm-generic/unistd.h      | 944 ++++++++++++++++++++++++++++++++
>  linux-headers/asm-mips/bitsperlong.h    |   9 +
>  linux-headers/asm-mips/unistd.h         |  44 +-
>  linux-headers/asm-powerpc/bitsperlong.h |  13 +
>  linux-headers/asm-s390/bitsperlong.h    |  14 +
>  linux-headers/asm-x86/bitsperlong.h     |  14 +
>  scripts/update-linux-headers.sh         |  20 +-
>  10 files changed, 1086 insertions(+), 13 deletions(-)
>  create mode 100644 linux-headers/asm-arm/bitsperlong.h
>  create mode 100644 linux-headers/asm-arm64/bitsperlong.h
>  create mode 100644 linux-headers/asm-generic/bitsperlong.h
>  create mode 100644 linux-headers/asm-generic/unistd.h
>  create mode 100644 linux-headers/asm-mips/bitsperlong.h
>  create mode 100644 linux-headers/asm-powerpc/bitsperlong.h
>  create mode 100644 linux-headers/asm-s390/bitsperlong.h
>  create mode 100644 linux-headers/asm-x86/bitsperlong.h
> 
> -- 
> MST
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK