[Qemu-devel] [PATCH v5.1 for 2.13 0/4] tpm: Extend TPM with state migration support

Stefan Berger posted 4 patches 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1521242665-15807-1-git-send-email-stefanb@linux.vnet.ibm.com
Test checkpatch failed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test s390x passed
docs/specs/tpm.txt         | 106 +++++++++++++++
hw/tpm/tpm_emulator.c      | 318 +++++++++++++++++++++++++++++++++++++++++++--
hw/tpm/tpm_tis.c           |  52 +++++++-
hw/tpm/trace-events        |   9 +-
tests/Makefile.include     |   3 +
tests/tpm-crb-swtpm-test.c | 244 ++++++++++++++++++++++++++++++++++
tests/tpm-util.c           | 135 +++++++++++++++++++
tests/tpm-util.h           |  36 +++++
8 files changed, 889 insertions(+), 14 deletions(-)
create mode 100644 tests/tpm-crb-swtpm-test.c
create mode 100644 tests/tpm-util.c
create mode 100644 tests/tpm-util.h
[Qemu-devel] [PATCH v5.1 for 2.13 0/4] tpm: Extend TPM with state migration support
Posted by Stefan Berger 7 years, 7 months ago
This series of patches implements support for migrating the state of the
external 'swtpm' TPM emulator as well as that of the TIS interface. 

For testing of TPM 2 (migration) please use the following git repos and
branches:

libtpms: 
   - repo: https://github.com/stefanberger/libtpms
   - branch: tpm2-preview.rev146.v2

swtpm:
   - repo: https://github.com/stefanberger/swtpm
   - branch: tpm2-preview.rev146.v2

Regards,
  Stefan

Changes:
 v4->v5:
   - followed Marc-André's and Alan's comments where possible; some comments
     were not addressed and reasons posted to mailing list
   - converted debug statements to tracing
   - qemu_chr_fe_read_all does not return errno, so displaying expected versus
     received number of bytes rather than strerror(errno)
   - added test cases
   - added documentation for migration to docs/spec/tpm.txt

 v3->v4:
   - dropped the size limit enforcement on blobs received from the swtpm
   - the .post_load migration function requires errno's to be returned.
     -> some of the functions have been converted to return a better errno



Stefan Berger (4):
  tpm: extend TPM emulator with state migration support
  tpm: extend TPM TIS with state migration support
  docs: tpm: add VM save/restore example and troubleshooting guide
  tpm: Add test cases that uses the external swtpm with CRB interface

 docs/specs/tpm.txt         | 106 +++++++++++++++
 hw/tpm/tpm_emulator.c      | 318 +++++++++++++++++++++++++++++++++++++++++++--
 hw/tpm/tpm_tis.c           |  52 +++++++-
 hw/tpm/trace-events        |   9 +-
 tests/Makefile.include     |   3 +
 tests/tpm-crb-swtpm-test.c | 244 ++++++++++++++++++++++++++++++++++
 tests/tpm-util.c           | 135 +++++++++++++++++++
 tests/tpm-util.h           |  36 +++++
 8 files changed, 889 insertions(+), 14 deletions(-)
 create mode 100644 tests/tpm-crb-swtpm-test.c
 create mode 100644 tests/tpm-util.c
 create mode 100644 tests/tpm-util.h

-- 
2.5.5


Re: [Qemu-devel] [PATCH v5.1 for 2.13 0/4] tpm: Extend TPM with state migration support
Posted by no-reply@patchew.org 7 years, 7 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1521242665-15807-1-git-send-email-stefanb@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v5.1 for 2.13 0/4] tpm: Extend TPM with state migration support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1521242665-15807-1-git-send-email-stefanb@linux.vnet.ibm.com -> patchew/1521242665-15807-1-git-send-email-stefanb@linux.vnet.ibm.com
Switched to a new branch 'test'
1195d3f6ef tpm: Add test cases that uses the external swtpm with CRB interface
c462cd1932 docs: tpm: add VM save/restore example and troubleshooting guide
ad36584301 tpm: extend TPM TIS with state migration support
b6f35a440a tpm: extend TPM emulator with state migration support

=== OUTPUT BEGIN ===
Checking PATCH 1/4: tpm: extend TPM emulator with state migration support...
Checking PATCH 2/4: tpm: extend TPM TIS with state migration support...
Checking PATCH 3/4: docs: tpm: add VM save/restore example and troubleshooting guide...
Checking PATCH 4/4: tpm: Add test cases that uses the external swtpm with CRB interface...
ERROR: braces {} are necessary for all arms of this statement
#331: FILE: tests/tpm-util.c:36:
+    } while (g_get_monotonic_time() < end_time);
[...]

ERROR: line over 90 characters
#387: FILE: tests/tpm-util.c:92:
+gboolean tpm_util_swtpm_start(const char *path, GPid *pid, SocketAddress **addr, GError **error)

ERROR: braces {} are necessary for all arms of this statement
#409: FILE: tests/tpm-util.c:114:
+    for (i = 0; swtpm_argv[i]; i++)
[...]

ERROR: braces {} are necessary for all arms of this statement
#419: FILE: tests/tpm-util.c:124:
+    if (!pid)
[...]

total: 4 errors, 0 warnings, 430 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org