[v2] RISC-V Post-merge spec conformance and cleanup

[Qemu-devel] [PATCH v2 03/23] RISC-V: Make virt board description match spike

Posted by Michael Clark 7 years, 11 months ago

This makes 'qemu-system-riscv64 -machine help' output more tidy
and consistent.

Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Signed-off-by: Michael Clark <mjc@sifive.com>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
---
 hw/riscv/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index a402856..0055439 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -404,7 +404,7 @@ static const TypeInfo riscv_virt_board_device = {
 
 static void riscv_virt_board_machine_init(MachineClass *mc)
 {
-    mc->desc = "RISC-V VirtIO Board (Privileged spec v1.10)";
+    mc->desc = "RISC-V VirtIO Board (Privileged ISA v1.10)";
     mc->init = riscv_virt_board_init;
     mc->max_cpus = 8; /* hardcoded limit in BBL */
 }
-- 
2.7.0

Re: [Qemu-devel] [PATCH v2 03/23] RISC-V: Make virt board description match spike

Posted by Philippe Mathieu-Daudé 7 years, 11 months ago

On 03/09/2018 05:12 AM, Michael Clark wrote:
> This makes 'qemu-system-riscv64 -machine help' output more tidy
> and consistent.
> 
> Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>
> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Signed-off-by: Michael Clark <mjc@sifive.com>
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/riscv/virt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index a402856..0055439 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -404,7 +404,7 @@ static const TypeInfo riscv_virt_board_device = {
>  
>  static void riscv_virt_board_machine_init(MachineClass *mc)
>  {
> -    mc->desc = "RISC-V VirtIO Board (Privileged spec v1.10)";
> +    mc->desc = "RISC-V VirtIO Board (Privileged ISA v1.10)";
>      mc->init = riscv_virt_board_init;
>      mc->max_cpus = 8; /* hardcoded limit in BBL */
>  }
>