[Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated

Paolo Bonzini posted 34 patches 7 years, 7 months ago
[Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated
Posted by Paolo Bonzini 7 years, 7 months ago
From: Thomas Huth <thuth@redhat.com>

These options have been marked in a comment in qemu-options.hx as
deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
never informed the users about these deprecations. Let's catch up
on that omission now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1519138892-12836-1-git-send-email-thuth@redhat.com>
[Fix messages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qemu-doc.texi | 16 +++++++++++-----
 vl.c          |  5 +++++
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/qemu-doc.texi b/qemu-doc.texi
index fb6fac5..589519a 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2723,12 +2723,18 @@ filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
 which is not the recommended way to run QEMU. This backend should not be
 used and it will be removed with no replacement.
 
-@subsection -no-frame (since 2.12.0)
+@subsection -rtc-td-hack (since 2.12.0)
 
-The ``-no-frame'' argument works with SDL 1.2 only.  SDL 2.0 lacks
-support for frameless windows, and the other user interfaces never
-implemented this in the first place.  So this will be removed together
-with SDL 1.2 support.
+The @code{-rtc-td-hack} option has been replaced by
+@code{-rtc driftfix=slew}.
+
+@subsection -localtime (since 2.12.0)
+
+The @code{-localtime} option has been replaced by @code{-rtc base=localtime}.
+
+@subsection -startdate (since 2.12.0)
+
+The @code{-startdate} option has been replaced by @code{-rtc base=@var{date}}.
 
 @section qemu-img command line arguments
 
diff --git a/vl.c b/vl.c
index 6e4f1a2..e648bed 100644
--- a/vl.c
+++ b/vl.c
@@ -3406,6 +3406,8 @@ int main(int argc, char **argv, char **envp)
                 break;
             case QEMU_OPTION_localtime:
                 rtc_utc = 0;
+                warn_report("This option is deprecated, "
+                            "use '-rtc base=localtime' instead.");
                 break;
             case QEMU_OPTION_vga:
                 vga_model = optarg;
@@ -3665,6 +3667,8 @@ int main(int argc, char **argv, char **envp)
                 };
 
                 qdev_prop_register_global(&slew_lost_ticks);
+                warn_report("This option is deprecated, "
+                            "use '-rtc driftfix=slew' instead.");
                 break;
             }
             case QEMU_OPTION_acpitable:
@@ -3866,6 +3870,7 @@ int main(int argc, char **argv, char **envp)
                  */
                 break;
             case QEMU_OPTION_startdate:
+                warn_report("This option is deprecated, use '-rtc base=' instead.");
                 configure_rtc_date_offset(optarg, 1);
                 break;
             case QEMU_OPTION_rtc:
-- 
1.8.3.1



Re: [Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated
Posted by Thomas Huth 7 years, 7 months ago
On 06.03.2018 14:19, Paolo Bonzini wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> These options have been marked in a comment in qemu-options.hx as
> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
> never informed the users about these deprecations. Let's catch up
> on that omission now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <1519138892-12836-1-git-send-email-thuth@redhat.com>
> [Fix messages. - Paolo]
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu-doc.texi | 16 +++++++++++-----
>  vl.c          |  5 +++++
>  2 files changed, 16 insertions(+), 5 deletions(-)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index fb6fac5..589519a 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2723,12 +2723,18 @@ filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
>  which is not the recommended way to run QEMU. This backend should not be
>  used and it will be removed with no replacement.
>  
> -@subsection -no-frame (since 2.12.0)
> +@subsection -rtc-td-hack (since 2.12.0)
>  
> -The ``-no-frame'' argument works with SDL 1.2 only.  SDL 2.0 lacks
> -support for frameless windows, and the other user interfaces never
> -implemented this in the first place.  So this will be removed together
> -with SDL 1.2 support.

No, this should not be removed. Looks like an accident when resolving a
conflict?

 Thomas

Re: [Qemu-devel] [PULL 07/34] Document --rtc-td-hack, --localtime and --startdate as deprecated
Posted by Paolo Bonzini 7 years, 7 months ago
On 06/03/2018 16:13, Thomas Huth wrote:
> On 06.03.2018 14:19, Paolo Bonzini wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> These options have been marked in a comment in qemu-options.hx as
>> deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
>> never informed the users about these deprecations. Let's catch up
>> on that omission now.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> Message-Id: <1519138892-12836-1-git-send-email-thuth@redhat.com>
>> [Fix messages. - Paolo]
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  qemu-doc.texi | 16 +++++++++++-----
>>  vl.c          |  5 +++++
>>  2 files changed, 16 insertions(+), 5 deletions(-)
>>
>> diff --git a/qemu-doc.texi b/qemu-doc.texi
>> index fb6fac5..589519a 100644
>> --- a/qemu-doc.texi
>> +++ b/qemu-doc.texi
>> @@ -2723,12 +2723,18 @@ filesystem test suite. Also it requires the CAP_DAC_READ_SEARCH capability,
>>  which is not the recommended way to run QEMU. This backend should not be
>>  used and it will be removed with no replacement.
>>  
>> -@subsection -no-frame (since 2.12.0)
>> +@subsection -rtc-td-hack (since 2.12.0)
>>  
>> -The ``-no-frame'' argument works with SDL 1.2 only.  SDL 2.0 lacks
>> -support for frameless windows, and the other user interfaces never
>> -implemented this in the first place.  So this will be removed together
>> -with SDL 1.2 support.
> 
> No, this should not be removed. Looks like an accident when resolving a
> conflict?

Oops, yes.  My wrong understanding was that 2.12 removed SDL 1.2 support.

Paolo