Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1520342370-123606-1-git-send-email-pbonzini@redhat.com
Subject: [Qemu-devel] [PULL 00/34] Misc patches for 2018-03-06
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1520342370-123606-1-git-send-email-pbonzini@redhat.com -> patchew/1520342370-123606-1-git-send-email-pbonzini@redhat.com
* [new tag] patchew/20180306132430.32110-1-berrange@redhat.com -> patchew/20180306132430.32110-1-berrange@redhat.com
Switched to a new branch 'test'
a4ceb15bac use g_path_get_basename instead of basename
6c2567cdf0 balloon: Fix documentation of the --balloon parameter and deprecate it
ae1cb543f3 WHPX improve interrupt notification registration
126902e88b WHXP Removes the use of WHvGetExitContextSize
e2e4d890b2 Fix WHPX issue leaking tpr values
05afbff507 Fix WHPX typo in 'mmio'
738cc18aff Fix WHPX additional lock acquisition
b5d7df4cba Remove unnecessary WHPX __debugbreak();
9de91b4ec7 Resolves WHPX breaking changes in SDK 17095
21fe88200d Fixing WHPX casing to match SDK
78f5194b0f Revert "build-sys: compile with -Og or -O1 when --enable-debug"
8623937bc8 checkpatch: add check for `while` and `for`
bb7b953c4d checkpatch: add a warning for basename/dirname
2c469a02cf address_space_rw: address_space_to_flatview needs RCU lock
c61cb65854 address_space_map: address_space_to_flatview needs RCU lock
a59cf85880 address_space_access_valid: address_space_to_flatview needs RCU lock
0da59bd682 address_space_read: address_space_to_flatview needs RCU lock
6e79fe431d address_space_write: address_space_to_flatview needs RCU lock
c23349c6c2 memory: inline some performance-sensitive accessors
9993848605 openpic_kvm: drop address_space_to_flatview call
f68a1b6e05 chardev: fix leak in tcp_chr_telnet_init_io()
d19120b81f sdhci-test: fix leaks
f291bd7c9c ahci-test: fix opts leak of skip tests
e9cec95067 lockable: workaround GCC link issue with ASAN
829b78b4fe build-sys: fix -fsanitize=address check
832c16ffc0 qmp: Add qom-list-properties to list QOM object properties
4ad1ae9dbc qmp: Merge ObjectPropertyInfo and DevicePropertyInfo
cab2b8d9c7 Document --rtc-td-hack, --localtime and --startdate as deprecated
2441bf2aa9 cpus: CPU threads are always created initially for one CPU only
883c381bf3 cpus: wait for CPU creation at central place
10f3537b7b cpus: properly inititalize CPU > 1 under single-threaded TCG
bab82158ce scsi: Remove automatic creation of SCSI controllers with -drive if=scsi
3bf0e70f24 Remove the deprecated -tdf option
128269f3f0 g364fb: fix DirtyBitmapSnapshot leak
=== OUTPUT BEGIN ===
Checking PATCH 1/34: g364fb: fix DirtyBitmapSnapshot leak...
Checking PATCH 2/34: Remove the deprecated -tdf option...
Checking PATCH 3/34: scsi: Remove automatic creation of SCSI controllers with -drive if=scsi...
Checking PATCH 4/34: cpus: properly inititalize CPU > 1 under single-threaded TCG...
Checking PATCH 5/34: cpus: wait for CPU creation at central place...
Checking PATCH 6/34: cpus: CPU threads are always created initially for one CPU only...
Checking PATCH 7/34: Document --rtc-td-hack, --localtime and --startdate as deprecated...
WARNING: line over 80 characters
#72: FILE: vl.c:3873:
+ warn_report("This option is deprecated, use '-rtc base=' instead.");
total: 0 errors, 1 warnings, 46 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/34: qmp: Merge ObjectPropertyInfo and DevicePropertyInfo...
Checking PATCH 9/34: qmp: Add qom-list-properties to list QOM object properties...
Checking PATCH 10/34: build-sys: fix -fsanitize=address check...
Checking PATCH 11/34: lockable: workaround GCC link issue with ASAN...
WARNING: architecture specific defines should be avoided
#28: FILE: include/qemu/lockable.h:31:
+#if defined(__OPTIMIZE__) && !defined(__SANITIZE_ADDRESS__)
total: 0 errors, 1 warnings, 8 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/34: ahci-test: fix opts leak of skip tests...
Checking PATCH 13/34: sdhci-test: fix leaks...
Checking PATCH 14/34: chardev: fix leak in tcp_chr_telnet_init_io()...
Checking PATCH 15/34: openpic_kvm: drop address_space_to_flatview call...
Checking PATCH 16/34: memory: inline some performance-sensitive accessors...
Checking PATCH 17/34: address_space_write: address_space_to_flatview needs RCU lock...
Checking PATCH 18/34: address_space_read: address_space_to_flatview needs RCU lock...
Checking PATCH 19/34: address_space_access_valid: address_space_to_flatview needs RCU lock...
Checking PATCH 20/34: address_space_map: address_space_to_flatview needs RCU lock...
Checking PATCH 21/34: address_space_rw: address_space_to_flatview needs RCU lock...
Checking PATCH 22/34: checkpatch: add a warning for basename/dirname...
ERROR: line over 90 characters
#24: FILE: scripts/checkpatch.pl:2589:
+ WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n" . $herecurr);
total: 1 errors, 0 warnings, 11 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 23/34: checkpatch: add check for `while` and `for`...
Checking PATCH 24/34: Revert "build-sys: compile with -Og or -O1 when --enable-debug"...
Checking PATCH 25/34: Fixing WHPX casing to match SDK...
Checking PATCH 26/34: Resolves WHPX breaking changes in SDK 17095...
Checking PATCH 27/34: Remove unnecessary WHPX __debugbreak();...
Checking PATCH 28/34: Fix WHPX additional lock acquisition...
Checking PATCH 29/34: Fix WHPX typo in 'mmio'...
Checking PATCH 30/34: Fix WHPX issue leaking tpr values...
Checking PATCH 31/34: WHXP Removes the use of WHvGetExitContextSize...
Checking PATCH 32/34: WHPX improve interrupt notification registration...
Checking PATCH 33/34: balloon: Fix documentation of the --balloon parameter and deprecate it...
Checking PATCH 34/34: use g_path_get_basename instead of basename...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org