[Qemu-devel] [PATCH] virtio-pci: trivial fixes in error message

Greg Kurz posted 1 patch 6 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/151844508814.7999.5257918627784684957.stgit@bahia
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test docker-quick@centos6 passed
Test ppcbe passed
Test ppcle passed
Test s390x passed
hw/virtio/virtio-pci.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] virtio-pci: trivial fixes in error message
Posted by Greg Kurz 6 years, 2 months ago
Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/virtio/virtio-pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index c20537f31de7..ae3e8e1ca9b8 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1585,7 +1585,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp)
     if (legacy) {
         if (virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM)) {
             error_setg(errp, "VIRTIO_F_IOMMU_PLATFORM was supported by"
-                       "neither legacy nor transitional device.");
+                       " neither legacy nor transitional device");
             return ;
         }
         /*


Re: [Qemu-devel] [PATCH] virtio-pci: trivial fixes in error message
Posted by Eric Blake 6 years, 2 months ago
On 02/12/2018 08:18 AM, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>   hw/virtio/virtio-pci.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index c20537f31de7..ae3e8e1ca9b8 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1585,7 +1585,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp)
>       if (legacy) {
>           if (virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM)) {
>               error_setg(errp, "VIRTIO_F_IOMMU_PLATFORM was supported by"
> -                       "neither legacy nor transitional device.");
> +                       " neither legacy nor transitional device");

Reviewed-by: Eric Blake <eblake@redhat.com>

(fixing both the missing space and the unneeded trailing dot)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org