[Qemu-devel] [PULL v2 1/6] tpm: Set the flags of the CMD_INIT command to 0

Stefan Berger posted 6 patches 8 years ago
[Qemu-devel] [PULL v2 1/6] tpm: Set the flags of the CMD_INIT command to 0
Posted by Stefan Berger 8 years ago
The flags of the CMD_INIT control channel command were not
initialized properly. Fix this and set to 0.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/tpm/tpm_emulator.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 35c78de..532d3e3 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/tpm_emulator.c
@@ -320,7 +320,9 @@ static int tpm_emulator_set_buffer_size(TPMBackend *tb,
 static int tpm_emulator_startup_tpm(TPMBackend *tb, size_t buffersize)
 {
     TPMEmulator *tpm_emu = TPM_EMULATOR(tb);
-    ptm_init init;
+    ptm_init init = {
+        .u.req.init_flags = 0,
+    };
     ptm_res res;
 
     if (buffersize != 0 &&
-- 
2.5.5


Re: [Qemu-devel] [PULL v2 1/6] tpm: Set the flags of the CMD_INIT command to 0
Posted by Stefan Berger 7 years, 11 months ago
Michael, can you please apply this patch to stable?

git cherry-pick 302705876

Regards,
    Stefan


> The flags of the CMD_INIT control channel command were not
> initialized properly. Fix this and set to 0.
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   hw/tpm/tpm_emulator.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
> index 35c78de..532d3e3 100644
> --- a/hw/tpm/tpm_emulator.c
> +++ b/hw/tpm/tpm_emulator.c
> @@ -320,7 +320,9 @@ static int tpm_emulator_set_buffer_size(TPMBackend *tb,
>   static int tpm_emulator_startup_tpm(TPMBackend *tb, size_t buffersize)
>   {
>       TPMEmulator *tpm_emu = TPM_EMULATOR(tb);
> -    ptm_init init;
> +    ptm_init init = {
> +        .u.req.init_flags = 0,
> +    };
>       ptm_res res;
>   
>       if (buffersize != 0 &&