[Qemu-devel] [PATCH 15/24] tricore: cpu: add TARGET_DEFAULT_CPU_TYPE macro

Igor Mammedov posted 24 patches 7 years, 9 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 15/24] tricore: cpu: add TARGET_DEFAULT_CPU_TYPE macro
Posted by Igor Mammedov 7 years, 9 months ago
it will be used for for 2 purposes, 1st is to
provide to cpu name resolving class for machine 'none'
  cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model)
and later to drop a bunch of ifdefs *-user/main.c that
set default cpu_model.

linux-user defaults to catch all 'any' which is bogus
and results into error. Pick arbitrary model "tc1796"
for TARGET_DEFAULT_CPU_TYPE to use and it would fix
missing default when *-user is switched to using types
instead of cpu_model.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
CC: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 target/tricore/cpu.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h
index f41d2ce..835d51a 100644
--- a/target/tricore/cpu.h
+++ b/target/tricore/cpu.h
@@ -415,6 +415,7 @@ static inline void cpu_get_tb_cpu_state(CPUTriCoreState *env, target_ulong *pc,
 
 #define TRICORE_CPU_TYPE_SUFFIX "-" TYPE_TRICORE_CPU
 #define TRICORE_CPU_TYPE_NAME(model) model TRICORE_CPU_TYPE_SUFFIX
+#define TARGET_DEFAULT_CPU_TYPE TRICORE_CPU_TYPE_NAME("tc1796")
 
 /* helpers.c */
 int cpu_tricore_handle_mmu_fault(CPUState *cpu, target_ulong address,
-- 
2.7.4


Re: [Qemu-devel] [PATCH 15/24] tricore: cpu: add TARGET_DEFAULT_CPU_TYPE macro
Posted by Bastian Koppelmann 7 years, 9 months ago
On 01/17/2018 04:43 PM, Igor Mammedov wrote:
> it will be used for for 2 purposes, 1st is to
> provide to cpu name resolving class for machine 'none'
>   cpu_parse_cpu_model(machine_class->default_cpu_type, cpu_model)
> and later to drop a bunch of ifdefs *-user/main.c that
> set default cpu_model.
> 
> linux-user defaults to catch all 'any' which is bogus
> and results into error. Pick arbitrary model "tc1796"
> for TARGET_DEFAULT_CPU_TYPE to use and it would fix
> missing default when *-user is switched to using types
> instead of cpu_model.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CC: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
>  target/tricore/cpu.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

Cheers,
Bastian