tests: acpi: fix FADT not being tested and cleanups

[Qemu-devel] [PATCH 0/5] tests: acpi: fix FADT not being tested and cleanups

Igor Mammedov posted 5 patches 7 years, 10 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1514560602-280058-1-git-send-email-imammedo@redhat.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

tests/bios-tables-test.c | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/5] tests: acpi: fix FADT not being tested and cleanups

Posted by Igor Mammedov 7 years, 10 months ago

Even though we have tests/acpi-test-data/[q35|pc]/FACP reference table
in source tree, it hasn't been actually tested. As result it went stale
and we did not notice any changes that were happening to it.

Fix it buy making sure it's not ignored and before fixing it,
do some cleanups in testcase that hopefully will make more clear what
functions actually do. 

NOTE to maintaner:
   after fix in 5/5 update following reference tables, to match reality
   tests/acpi-test-data/pc/FACP
   tests/acpi-test-data/q35/FACP


CC: Michael S. Tsirkin" <mst@redhat.com>
CC: Thomas Huth <thuth@redhat.com>

Igor Mammedov (5):
  tests: acpi: move tested tables array allocation outside of
    test_acpi_dsdt_table()
  tests: acpi: init table descriptor in test_dst_table()
  tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its
    usage
  tests: acpi: add comments to fetch_rsdt_referenced_tables/data->tables
    usage
  tests: acpi: fix FADT not being compared to reference table

 tests/bios-tables-test.c | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

-- 
2.7.4