[Qemu-devel] [PATCH 0/3] block: Deprecated options

Thomas Huth posted 3 patches 7 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1513617273-7988-1-git-send-email-thuth@redhat.com
Test checkpatch passed
Test docker passed
Test ppc passed
Test s390x passed
blockdev.c      | 11 --------
qemu-doc.texi   | 29 +++++++++----------
qemu-options.hx | 19 ++-----------
vl.c            | 86 ++-------------------------------------------------------
4 files changed, 19 insertions(+), 126 deletions(-)
[Qemu-devel] [PATCH 0/3] block: Deprecated options
Posted by Thomas Huth 7 years, 10 months ago
Remove the deprecated "-drive boot" and "-hdachs" options and properly
mark some other deprecated options in the deprecation chapter.

Thomas Huth (3):
  block: Remove the obsolete -drive boot=on|off parameter
  block: Remove the deprecated -hdachs option
  block: Mention -drive cyls/heads/secs/trans/serial/addr in deprecation
    chapter

 blockdev.c      | 11 --------
 qemu-doc.texi   | 29 +++++++++----------
 qemu-options.hx | 19 ++-----------
 vl.c            | 86 ++-------------------------------------------------------
 4 files changed, 19 insertions(+), 126 deletions(-)

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH 0/3] block: Deprecated options
Posted by Markus Armbruster 7 years, 10 months ago
Thomas Huth <thuth@redhat.com> writes:

> Remove the deprecated "-drive boot" and "-hdachs" options and properly
> mark some other deprecated options in the deprecation chapter.

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block: Deprecated options
Posted by John Snow 7 years, 10 months ago

On 12/18/2017 12:14 PM, Thomas Huth wrote:
> Remove the deprecated "-drive boot" and "-hdachs" options and properly
> mark some other deprecated options in the deprecation chapter.
> 
> Thomas Huth (3):
>   block: Remove the obsolete -drive boot=on|off parameter
>   block: Remove the deprecated -hdachs option
>   block: Mention -drive cyls/heads/secs/trans/serial/addr in deprecation
>     chapter
> 
>  blockdev.c      | 11 --------
>  qemu-doc.texi   | 29 +++++++++----------
>  qemu-options.hx | 19 ++-----------
>  vl.c            | 86 ++-------------------------------------------------------
>  4 files changed, 19 insertions(+), 126 deletions(-)
> 

Reviewed-by: John Snow <jsnow@redhat.com>

So long, farewell: however, since we forgot to document them, can we
remove them already?

Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block: Deprecated options
Posted by Thomas Huth 7 years, 10 months ago
On 20.12.2017 22:40, John Snow wrote:
> 
> 
> On 12/18/2017 12:14 PM, Thomas Huth wrote:
>> Remove the deprecated "-drive boot" and "-hdachs" options and properly
>> mark some other deprecated options in the deprecation chapter.
>>
>> Thomas Huth (3):
>>   block: Remove the obsolete -drive boot=on|off parameter
>>   block: Remove the deprecated -hdachs option
>>   block: Mention -drive cyls/heads/secs/trans/serial/addr in deprecation
>>     chapter
>>
>>  blockdev.c      | 11 --------
>>  qemu-doc.texi   | 29 +++++++++----------
>>  qemu-options.hx | 19 ++-----------
>>  vl.c            | 86 ++-------------------------------------------------------
>>  4 files changed, 19 insertions(+), 126 deletions(-)
>>
> 
> Reviewed-by: John Snow <jsnow@redhat.com>

Thanks!

> So long, farewell: however, since we forgot to document them, can we
> remove them already?

The are documented in
https://qemu.weilnetz.de/doc/qemu-doc.html#Block-device-options so I
doubt that we can simply drop them without announcing it first?

 Thomas

Re: [Qemu-devel] [PATCH 0/3] block: Deprecated options
Posted by Kevin Wolf 7 years, 10 months ago
Am 18.12.2017 um 18:14 hat Thomas Huth geschrieben:
> Remove the deprecated "-drive boot" and "-hdachs" options and properly
> mark some other deprecated options in the deprecation chapter.
> 
> Thomas Huth (3):
>   block: Remove the obsolete -drive boot=on|off parameter
>   block: Remove the deprecated -hdachs option
>   block: Mention -drive cyls/heads/secs/trans/serial/addr in deprecation
>     chapter

Thanks, applied to the block branch.

Kevin