[v1] RE: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal

RE: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal

Posted by Zhang, Chen 4 years, 1 month ago

Hi Jason,

No news for a while.
Please review this series when you have time.

Thanks
Zhang Chen 

> -----Original Message-----
> From: Qemu-devel <qemu-devel-
> bounces+chen.zhang=intel.com@nongnu.org> On Behalf Of Zhang, Chen
> Sent: Wednesday, March 4, 2020 4:00 PM
> To: Jason Wang <jasowang@redhat.com>; qemu-dev <qemu-
> devel@nongnu.org>
> Cc: Daniel Cho <danielcho@qnap.com>; Dr . David Alan Gilbert
> <dgilbert@redhat.com>; Zhang Chen <zhangckid@gmail.com>
> Subject: RE: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal
> 
> Hi all,
> 
> Please give me some comments, this patch need by users(QNAP...).
> 
> Thanks
> Zhang Chen
> 
> > -----Original Message-----
> > From: Zhang, Chen <chen.zhang@intel.com>
> > Sent: Monday, February 24, 2020 4:58 AM
> > To: Jason Wang <jasowang@redhat.com>; qemu-dev <qemu-
> > devel@nongnu.org>
> > Cc: Zhang Chen <zhangckid@gmail.com>; Dr . David Alan Gilbert
> > <dgilbert@redhat.com>; Daniel Cho <danielcho@qnap.com>; Zhang, Chen
> > <chen.zhang@intel.com>
> > Subject: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal
> >
> > From: Zhang Chen <chen.zhang@intel.com>
> >
> > Make a way to config COLO parameter detailed according to user cases
> > and environment.
> >
> > Zhang Chen (2):
> >   net/colo-compare.c: Expose "compare_timeout" to user
> >   net/colo-compare.c: Expose "expired_scan_cycle" to user
> >
> >  net/colo-compare.c | 95
> > +++++++++++++++++++++++++++++++++++++++++++---
> >  qemu-options.hx    |  6 ++-
> >  2 files changed, 94 insertions(+), 7 deletions(-)
> >
> > --
> > 2.17.1
>

Re: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal

Posted by Jason Wang 4 years, 1 month ago

On 2020/3/17 下午4:25, Zhang, Chen wrote:
> Hi Jason,
>
> No news for a while.
> Please review this series when you have time.
>
> Thanks
> Zhang Chen

Sorry for the delay.

Patch looks good to me.

But it can not be applied cleanly on master.

Please rebase and send V2 (btw, I notice some typos in the commit log, 
please try to fix them as well).

Thanks

RE: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal

Posted by Zhang, Chen 4 years, 1 month ago


> -----Original Message-----
> From: Jason Wang <jasowang@redhat.com>
> Sent: Wednesday, March 18, 2020 10:48 AM
> To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu-
> devel@nongnu.org>
> Cc: Daniel Cho <danielcho@qnap.com>; Dr . David Alan Gilbert
> <dgilbert@redhat.com>; Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [PATCH 0/2] net/colo-compare.c: Expose more COLO internal
> 
> 
> On 2020/3/17 下午4:25, Zhang, Chen wrote:
> > Hi Jason,
> >
> > No news for a while.
> > Please review this series when you have time.
> >
> > Thanks
> > Zhang Chen
> 
> 
> Sorry for the delay.
> 
> Patch looks good to me.
> 
> But it can not be applied cleanly on master.
> 
> Please rebase and send V2 (btw, I notice some typos in the commit log,
> please try to fix them as well).

Sure.

Thanks
Zhang Chen

> 
> Thanks