[Qemu-devel] [PULL 0/3] MIPS queue

Yongbok Kim posted 3 patches 6 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1508769996-5747-1-git-send-email-yongbok.kim@imgtec.com
Test checkpatch passed
Test docker passed
Test s390x passed
.mailmap    |    3 +++
MAINTAINERS |   10 +++++-----
2 files changed, 8 insertions(+), 5 deletions(-)
[Qemu-devel] [PULL 0/3] MIPS queue
Posted by Yongbok Kim 6 years, 6 months ago
The following changes since commit e822e81e350825dd94f41ee2538ff1432b812eb9:

  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-10-20 15:04:00 +0100)

are available in the git repository at:

  git://github.com/yongbok/upstream-qemu.git target-mips.next

----------------------------------------------------------------
MIPS patches 2017-10-23

Changes:
Update email addresses of Yongbok Kim, James Hogan and Paul Burton.

----------------------------------------------------------------

James Hogan (1):
  MAINTAINERS: Update James Hogan's email address

Paul Burton (1):
  MAINTAINERS: Update Paul Burton's email address

Yongbok Kim (1):
  MAINTAINERS: Update Yongbok Kim's email address

 .mailmap    |    3 +++
 MAINTAINERS |   10 +++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)


Re: [Qemu-devel] [PULL 0/3] MIPS queue
Posted by Yongbok Kim 6 years, 6 months ago
On 23/10/2017 15:46, Yongbok Kim wrote:
> The following changes since commit e822e81e350825dd94f41ee2538ff1432b812eb9:
>
>    Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-10-20 15:04:00 +0100)
>
> are available in the git repository at:
>
>    git://github.com/yongbok/upstream-qemu.git target-mips.next
>
> ----------------------------------------------------------------
> MIPS patches 2017-10-23
>
> Changes:
> Update email addresses of Yongbok Kim, James Hogan and Paul Burton.
>
> ----------------------------------------------------------------
>
> James Hogan (1):
>    MAINTAINERS: Update James Hogan's email address
>
> Paul Burton (1):
>    MAINTAINERS: Update Paul Burton's email address
>
> Yongbok Kim (1):
>    MAINTAINERS: Update Yongbok Kim's email address
>
>   .mailmap    |    3 +++
>   MAINTAINERS |   10 +++++-----
>   2 files changed, 8 insertions(+), 5 deletions(-)
>
>

Ping?


Re: [Qemu-devel] [PULL 0/3] MIPS queue
Posted by Peter Maydell 6 years, 6 months ago
On 30 October 2017 at 14:09, Yongbok Kim <yongbok.kim@mips.com> wrote:
> On 23/10/2017 15:46, Yongbok Kim wrote:
>>
>> The following changes since commit
>> e822e81e350825dd94f41ee2538ff1432b812eb9:
>>
>>    Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
>> into staging (2017-10-20 15:04:00 +0100)
>>
>> are available in the git repository at:
>>
>>    git://github.com/yongbok/upstream-qemu.git target-mips.next
>>
>> ----------------------------------------------------------------
>> MIPS patches 2017-10-23
>>
>> Changes:
>> Update email addresses of Yongbok Kim, James Hogan and Paul Burton.
>>
>> ----------------------------------------------------------------
>>
>> James Hogan (1):
>>    MAINTAINERS: Update James Hogan's email address
>>
>> Paul Burton (1):
>>    MAINTAINERS: Update Paul Burton's email address
>>
>> Yongbok Kim (1):
>>    MAINTAINERS: Update Yongbok Kim's email address
>>
>>   .mailmap    |    3 +++
>>   MAINTAINERS |   10 +++++-----
>>   2 files changed, 8 insertions(+), 5 deletions(-)
>>
>>
>
> Ping?

I only notice pull requests if they contain the magic words
"for you to fetch changes up to", which yours does not.
'git request-pull' includes this in its output, so you should
probably make sure your workflow is using that.

I tried applying this, but git complains:
error: remotes/yongbok/target-mips.next: cannot verify a non-tag
object of type commit.

Pull requests should quote a gpg-signed tag name, not a branch.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/3] MIPS queue
Posted by Yongbok Kim 6 years, 6 months ago

On 30/10/2017 14:20, Peter Maydell wrote:
> On 30 October 2017 at 14:09, Yongbok Kim <yongbok.kim@mips.com> wrote:
>> On 23/10/2017 15:46, Yongbok Kim wrote:
>>> The following changes since commit
>>> e822e81e350825dd94f41ee2538ff1432b812eb9:
>>>
>>>     Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
>>> into staging (2017-10-20 15:04:00 +0100)
>>>
>>> are available in the git repository at:
>>>
>>>     git://github.com/yongbok/upstream-qemu.git target-mips.next
>>>
>>> ----------------------------------------------------------------
>>> MIPS patches 2017-10-23
>>>
>>> Changes:
>>> Update email addresses of Yongbok Kim, James Hogan and Paul Burton.
>>>
>>> ----------------------------------------------------------------
>>>
>>> James Hogan (1):
>>>     MAINTAINERS: Update James Hogan's email address
>>>
>>> Paul Burton (1):
>>>     MAINTAINERS: Update Paul Burton's email address
>>>
>>> Yongbok Kim (1):
>>>     MAINTAINERS: Update Yongbok Kim's email address
>>>
>>>    .mailmap    |    3 +++
>>>    MAINTAINERS |   10 +++++-----
>>>    2 files changed, 8 insertions(+), 5 deletions(-)
>>>
>>>
>> Ping?
> I only notice pull requests if they contain the magic words
> "for you to fetch changes up to", which yours does not.
> 'git request-pull' includes this in its output, so you should
> probably make sure your workflow is using that.
>
> I tried applying this, but git complains:
> error: remotes/yongbok/target-mips.next: cannot verify a non-tag
> object of type commit.
>
> Pull requests should quote a gpg-signed tag name, not a branch.
>
> thanks
> -- PMM
Hm. Odd. Something went wrong then.
Ok. I will try to create a new pull-req.

Thanks,
Yongbok