net: add print link status of nics in print_net_client function

[Qemu-devel] [PATCH] net: add print link status of nics in print_net_client function

ZhiPeng Lu posted 1 patch 8 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1508468326-18354-1-git-send-email-lu.zhipeng@zte.com.cn

Test checkpatch passed

Test docker passed

Test s390x passed

net/net.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] net: add print link status of nics in print_net_client function

Posted by ZhiPeng Lu 8 years ago

We can directly know the information of vm by executing "info network" command,
 including the link state of nics, without excuting other commands again.

Signed-off-by: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
Reviewed-by: Jiyun Fan <fan.jiyun@zte.com.cn>
---
 net/net.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/net/net.c b/net/net.c
index 39ef546..9e349cb 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1298,10 +1298,14 @@ void print_net_client(Monitor *mon, NetClientState *nc)
 {
     NetFilterState *nf;
 
-    monitor_printf(mon, "%s: index=%d,type=%s,%s\n", nc->name,
+    monitor_printf(mon, "%s: index=%d,type=%s,%s", nc->name,
                    nc->queue_index,
                    NetClientDriver_str(nc->info->type),
                    nc->info_str);
+    if (nc->info->type == NET_CLIENT_DRIVER_NIC) {
+        monitor_printf(mon, ",link status:%s", nc->link_down ? "down" : "up");
+    }
+    monitor_printf(mon, "\n");
     if (!QTAILQ_EMPTY(&nc->filters)) {
         monitor_printf(mon, "filters:\n");
     }
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] net: add print link status of nics in print_net_client function

Posted by Philippe Mathieu-Daudé 8 years ago

On 10/19/2017 11:58 PM, ZhiPeng Lu wrote:
> We can directly know the information of vm by executing "info network" command,
>  including the link state of nics, without excuting other commands again.

"executing"

> 
> Signed-off-by: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
> Reviewed-by: Jiyun Fan <fan.jiyun@zte.com.cn>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  net/net.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/net/net.c b/net/net.c
> index 39ef546..9e349cb 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1298,10 +1298,14 @@ void print_net_client(Monitor *mon, NetClientState *nc)
>  {
>      NetFilterState *nf;
>  
> -    monitor_printf(mon, "%s: index=%d,type=%s,%s\n", nc->name,
> +    monitor_printf(mon, "%s: index=%d,type=%s,%s", nc->name,
>                     nc->queue_index,
>                     NetClientDriver_str(nc->info->type),
>                     nc->info_str);
> +    if (nc->info->type == NET_CLIENT_DRIVER_NIC) {
> +        monitor_printf(mon, ",link status:%s", nc->link_down ? "down" : "up");
> +    }
> +    monitor_printf(mon, "\n");
>      if (!QTAILQ_EMPTY(&nc->filters)) {
>          monitor_printf(mon, "filters:\n");
>      }
>