1
Try #2, with the compile failure in kvm32.c fixed
1
This bug seemed worth fixing for 8.0 since we need an rc4 anyway:
2
(trivial change, not resending patches)
2
we were using uninitialized data for the guarded bit when
3
combining stage 1 and stage 2 attrs.
3
4
4
thanks
5
thanks
5
-- PMM
6
-- PMM
6
7
7
The following changes since commit 98bfaac788be0ca63d7d010c8d4ba100ff1d8278:
8
The following changes since commit 08dede07030973c1053868bc64de7e10bfa02ad6:
8
9
9
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-09-01-v3' into staging (2017-09-04 13:28:09 +0100)
10
Merge tag 'pull-ppc-20230409' of https://github.com/legoater/qemu into staging (2023-04-10 11:47:52 +0100)
10
11
11
are available in the git repository at:
12
are available in the Git repository at:
12
13
13
git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170904-1
14
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230410
14
15
15
for you to fetch changes up to 0b8095ec9e924dc00636ab2069d88dec6592a75d:
16
for you to fetch changes up to 8539dc00552e8ea60420856fc1262c8299bc6308:
16
17
17
arm_gicv3_kvm: Fix compile warning (2017-09-04 15:21:56 +0100)
18
target/arm: Copy guarded bit in combine_cacheattrs (2023-04-10 14:31:40 +0100)
18
19
19
----------------------------------------------------------------
20
----------------------------------------------------------------
20
target-arm:
21
target-arm: Fix bug where we weren't initializing
21
* collection of M profile cleanups and minor bugfixes
22
guarded bit state when combining S1/S2 attrs
22
* loader: handle ELF files with overlapping zero-init data
23
* virt: allow PMU instantiation with userspace irqchip
24
* wdt_aspeed: Add support for the reset width register
25
* cpu: Define new cpu_transaction_failed() hook
26
* arm: Support generating CPU exceptions on memory
27
transaction failures (bus faults)
28
* Mark some SoC devices as not user-creatable
29
* arm: Fix aa64 ldp register writeback
30
* arm_gicv3_kvm: Fix compile warning
31
23
32
----------------------------------------------------------------
24
----------------------------------------------------------------
33
Andrew Jeffery (2):
25
Richard Henderson (2):
34
watchdog: wdt_aspeed: Add support for the reset width register
26
target/arm: PTE bit GP only applies to stage1
35
aspeed_soc: Propagate silicon-rev to watchdog
27
target/arm: Copy guarded bit in combine_cacheattrs
36
28
37
Andrew Jones (4):
29
target/arm/ptw.c | 11 ++++++-----
38
hw/arm/virt: add pmu interrupt state
30
1 file changed, 6 insertions(+), 5 deletions(-)
39
target/arm/kvm: pmu: split init and set-irq stages
40
hw/arm/virt: allow pmu instantiation with userspace irqchip
41
target/arm/kvm: pmu: improve error handling
42
43
Peter Maydell (25):
44
target/arm: Use MMUAccessType enum rather than int
45
target/arm: Don't trap WFI/WFE for M profile
46
target/arm: Consolidate PMSA handling in get_phys_addr()
47
target/arm: Tighten up Thumb decode where new v8M insns will be
48
hw/intc/armv7m_nvic.c: Remove out of date comment
49
target/arm: Remove incorrect comment about MPU_CTRL
50
target/arm: Fix outdated comment about exception exit
51
target/arm: Define and use XPSR bit masks
52
target/arm: Don't store M profile PRIMASK and FAULTMASK in daif
53
target/arm: Don't use cpsr_write/cpsr_read to transfer M profile XPSR
54
target/arm: Make arm_cpu_dump_state() handle the M-profile XPSR
55
target/arm: Don't calculate lr in arm_v7m_cpu_do_interrupt() until needed
56
target/arm: Create and use new function arm_v7m_is_handler_mode()
57
armv7m_nvic.h: Move from include/hw/arm to include/hw/intc
58
nvic: Implement "user accesses BusFault" SCS region behaviour
59
loader: Handle ELF files with overlapping zero-initialized data
60
loader: Ignore zero-sized ELF segments
61
memory.h: Move MemTxResult type to memattrs.h
62
cpu: Define new cpu_transaction_failed() hook
63
cputlb: Support generating CPU exceptions on memory transaction failures
64
boards.h: Define new flag ignore_memory_transaction_failures
65
hw/arm: Set ignore_memory_transaction_failures for most ARM boards
66
target/arm: Factor out fault delivery code
67
target/arm: Allow deliver_fault() caller to specify EA bit
68
target/arm: Implement new do_transaction_failed hook
69
70
Philippe Mathieu-Daudé (1):
71
hw/arm: use defined type name instead of hard-coded string
72
73
Pranith Kumar (1):
74
arm_gicv3_kvm: Fix compile warning
75
76
Richard Henderson (1):
77
target/arm: Fix aa64 ldp register writeback
78
79
Thomas Huth (2):
80
hw/arm/aspeed_soc: Mark devices as user_creatable = false
81
hw/arm/digic: Mark device with user_creatable = false
82
83
include/exec/memattrs.h | 10 +++
84
include/exec/memory.h | 10 ---
85
include/hw/arm/armv7m.h | 2 +-
86
include/hw/boards.h | 11 +++
87
include/hw/elf_ops.h | 72 +++++++++++++--
88
include/hw/{arm => intc}/armv7m_nvic.h | 0
89
include/hw/watchdog/wdt_aspeed.h | 2 +
90
include/qom/cpu.h | 27 ++++++
91
softmmu_template.h | 4 +-
92
target/arm/cpu.h | 56 +++++++++---
93
target/arm/internals.h | 15 +++-
94
target/arm/kvm_arm.h | 9 +-
95
accel/tcg/cputlb.c | 32 ++++++-
96
hw/arm/armv7m.c | 4 +-
97
hw/arm/aspeed.c | 3 +
98
hw/arm/aspeed_soc.c | 4 +
99
hw/arm/collie.c | 1 +
100
hw/arm/cubieboard.c | 1 +
101
hw/arm/digic.c | 2 +
102
hw/arm/digic_boards.c | 1 +
103
hw/arm/exynos4210.c | 4 +-
104
hw/arm/exynos4_boards.c | 2 +
105
hw/arm/gumstix.c | 2 +
106
hw/arm/highbank.c | 13 ++-
107
hw/arm/imx25_pdk.c | 1 +
108
hw/arm/integratorcp.c | 1 +
109
hw/arm/kzm.c | 1 +
110
hw/arm/mainstone.c | 1 +
111
hw/arm/musicpal.c | 1 +
112
hw/arm/netduino2.c | 1 +
113
hw/arm/nseries.c | 2 +
114
hw/arm/omap_sx1.c | 2 +
115
hw/arm/palm.c | 1 +
116
hw/arm/raspi.c | 1 +
117
hw/arm/realview.c | 10 ++-
118
hw/arm/sabrelite.c | 1 +
119
hw/arm/spitz.c | 4 +
120
hw/arm/stellaris.c | 2 +
121
hw/arm/tosa.c | 1 +
122
hw/arm/versatilepb.c | 2 +
123
hw/arm/vexpress.c | 7 +-
124
hw/arm/virt.c | 12 ++-
125
hw/arm/xilinx_zynq.c | 15 ++--
126
hw/arm/xlnx-ep108.c | 2 +
127
hw/arm/z2.c | 1 +
128
hw/intc/arm_gicv3_kvm.c | 2 +-
129
hw/intc/armv7m_nvic.c | 68 +++++++++-----
130
hw/watchdog/wdt_aspeed.c | 93 ++++++++++++++++---
131
qom/cpu.c | 7 ++
132
target/arm/cpu.c | 8 +-
133
target/arm/helper.c | 124 ++++++++++++-------------
134
target/arm/kvm.c | 6 +-
135
target/arm/kvm32.c | 8 +-
136
target/arm/kvm64.c | 63 +++++++------
137
target/arm/machine.c | 54 ++++++++++-
138
target/arm/op_helper.c | 160 ++++++++++++++++++++++-----------
139
target/arm/translate-a64.c | 29 +++---
140
target/arm/translate.c | 106 ++++++++++++++++------
141
58 files changed, 795 insertions(+), 289 deletions(-)
142
rename include/hw/{arm => intc}/armv7m_nvic.h (100%)
143
diff view generated by jsdifflib
New patch
1
From: Richard Henderson <richard.henderson@linaro.org>
1
2
3
Only perform the extract of GP during the stage1 walk.
4
5
Reported-by: Peter Maydell <peter.maydell@linaro.org>
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-2-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 10 +++++-----
12
1 file changed, 5 insertions(+), 5 deletions(-)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
19
result->f.attrs.secure = false;
20
}
21
22
- /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
23
- if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
24
- result->f.guarded = extract64(attrs, 50, 1); /* GP */
25
- }
26
-
27
if (regime_is_stage2(mmu_idx)) {
28
result->cacheattrs.is_s2_format = true;
29
result->cacheattrs.attrs = extract32(attrs, 2, 4);
30
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
31
assert(attrindx <= 7);
32
result->cacheattrs.is_s2_format = false;
33
result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8);
34
+
35
+ /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
36
+ if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
37
+ result->f.guarded = extract64(attrs, 50, 1); /* GP */
38
+ }
39
}
40
41
/*
42
--
43
2.34.1
diff view generated by jsdifflib
New patch
1
From: Richard Henderson <richard.henderson@linaro.org>
1
2
3
The guarded bit comes from the stage1 walk.
4
5
Fixes: Coverity CID 1507929
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-3-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 1 +
12
1 file changed, 1 insertion(+)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr,
19
20
assert(!s1.is_s2_format);
21
ret.is_s2_format = false;
22
+ ret.guarded = s1.guarded;
23
24
if (s1.attrs == 0xf0) {
25
tagged = true;
26
--
27
2.34.1
diff view generated by jsdifflib