[Qemu-devel] [RFC v2 01/33] bitmap: remove BITOP_WORD()

Peter Xu posted 33 patches 8 years, 2 months ago
There is a newer version of this series
[Qemu-devel] [RFC v2 01/33] bitmap: remove BITOP_WORD()
Posted by Peter Xu 8 years, 2 months ago
We have BIT_WORD(). It's the same.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 util/bitops.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/util/bitops.c b/util/bitops.c
index b0c35dd..f236401 100644
--- a/util/bitops.c
+++ b/util/bitops.c
@@ -14,15 +14,13 @@
 #include "qemu/osdep.h"
 #include "qemu/bitops.h"
 
-#define BITOP_WORD(nr)		((nr) / BITS_PER_LONG)
-
 /*
  * Find the next set bit in a memory region.
  */
 unsigned long find_next_bit(const unsigned long *addr, unsigned long size,
 			    unsigned long offset)
 {
-    const unsigned long *p = addr + BITOP_WORD(offset);
+    const unsigned long *p = addr + BIT_WORD(offset);
     unsigned long result = offset & ~(BITS_PER_LONG-1);
     unsigned long tmp;
 
@@ -87,7 +85,7 @@ found_middle:
 unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size,
 				 unsigned long offset)
 {
-    const unsigned long *p = addr + BITOP_WORD(offset);
+    const unsigned long *p = addr + BIT_WORD(offset);
     unsigned long result = offset & ~(BITS_PER_LONG-1);
     unsigned long tmp;
 
-- 
2.7.4


Re: [Qemu-devel] [RFC v2 01/33] bitmap: remove BITOP_WORD()
Posted by Juan Quintela 8 years, 1 month ago
Peter Xu <peterx@redhat.com> wrote:
> We have BIT_WORD(). It's the same.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

It is the same, and it don't ever exist on linux code.