[v2] QEMU Backup Tool

[Qemu-devel] [PATCH v2 0/3] QEMU Backup Tool

Posted by Ishani Chugh 8 years, 2 months ago

This patch series is intended to introduce QEMU Backup tool.
qemu-backup will be a command-line tool for performing full and
incremental disk backups on running VMs. It is intended as a
reference implementation for management stack and backup developers
to see QEMU's backup features in action.
This patch series contains three patches,
               1) QEMU Backup command line tool.
               2) Test for full backup.
               3) Manpage for the tool.

Ishani Chugh (3):
  backup: QEMU Backup Tool
  Test for full Backup
  Add manpage for QEMU Backup Tool

 Makefile                        |  14 +-
 contrib/backup/qemu-backup.py   | 335 ++++++++++++++++++++++++++++++++++++++++
 contrib/backup/qemu-backup.texi | 144 +++++++++++++++++
 tests/qemu-iotests/191          |  86 +++++++++++
 tests/qemu-iotests/191.out      |  35 +++++
 tests/qemu-iotests/group        |   2 +
 6 files changed, 612 insertions(+), 4 deletions(-)
 create mode 100644 contrib/backup/qemu-backup.py
 create mode 100644 contrib/backup/qemu-backup.texi
 create mode 100755 tests/qemu-iotests/191
 create mode 100644 tests/qemu-iotests/191.out

-- 
2.7.4

Re: [Qemu-devel] [PATCH v2 0/3] QEMU Backup Tool

Posted by Fam Zheng 8 years, 2 months ago

On Tue, 08/29 22:13, Ishani Chugh wrote:
> This patch series is intended to introduce QEMU Backup tool.
> qemu-backup will be a command-line tool for performing full and
> incremental disk backups on running VMs. It is intended as a
> reference implementation for management stack and backup developers
> to see QEMU's backup features in action.
> This patch series contains three patches,
>                1) QEMU Backup command line tool.
>                2) Test for full backup.
>                3) Manpage for the tool.

Looks good in general. I've left small suggestions. Thanks for working on this
tool!

Fam

> 
> Ishani Chugh (3):
>   backup: QEMU Backup Tool
>   Test for full Backup
>   Add manpage for QEMU Backup Tool
> 
>  Makefile                        |  14 +-
>  contrib/backup/qemu-backup.py   | 335 ++++++++++++++++++++++++++++++++++++++++
>  contrib/backup/qemu-backup.texi | 144 +++++++++++++++++
>  tests/qemu-iotests/191          |  86 +++++++++++
>  tests/qemu-iotests/191.out      |  35 +++++
>  tests/qemu-iotests/group        |   2 +
>  6 files changed, 612 insertions(+), 4 deletions(-)
>  create mode 100644 contrib/backup/qemu-backup.py
>  create mode 100644 contrib/backup/qemu-backup.texi
>  create mode 100755 tests/qemu-iotests/191
>  create mode 100644 tests/qemu-iotests/191.out
> 
> -- 
> 2.7.4
> 
>

Re: [Qemu-devel] [PATCH v2 0/3] QEMU Backup Tool

Posted by Stefan Hajnoczi 8 years, 2 months ago

On Tue, Aug 29, 2017 at 10:13:36PM +0530, Ishani Chugh wrote:
> This patch series is intended to introduce QEMU Backup tool.
> qemu-backup will be a command-line tool for performing full and
> incremental disk backups on running VMs. It is intended as a
> reference implementation for management stack and backup developers
> to see QEMU's backup features in action.
> This patch series contains three patches,
>                1) QEMU Backup command line tool.
>                2) Test for full backup.
>                3) Manpage for the tool.
> 
> Ishani Chugh (3):
>   backup: QEMU Backup Tool
>   Test for full Backup
>   Add manpage for QEMU Backup Tool
> 
>  Makefile                        |  14 +-
>  contrib/backup/qemu-backup.py   | 335 ++++++++++++++++++++++++++++++++++++++++
>  contrib/backup/qemu-backup.texi | 144 +++++++++++++++++
>  tests/qemu-iotests/191          |  86 +++++++++++
>  tests/qemu-iotests/191.out      |  35 +++++
>  tests/qemu-iotests/group        |   2 +
>  6 files changed, 612 insertions(+), 4 deletions(-)
>  create mode 100644 contrib/backup/qemu-backup.py
>  create mode 100644 contrib/backup/qemu-backup.texi
>  create mode 100755 tests/qemu-iotests/191
>  create mode 100644 tests/qemu-iotests/191.out

When you send the next revision to address Fam's comments, please
include a changelog like this:

v3:
 * Fix typo in foo.py
 * Add missing parameter to bar()
 ...

That way reviewers know what changes to look out for.  Thanks!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>