On Thu, 17 Aug 2017 08:25:07 +0200
Thomas Huth <thuth@redhat.com> wrote:
> We currently do not have many tests enabled for QEMU on s390x yet,
> so this series reworks some of the tests to be also usable on s390x
> to get some extended test coverage there.
More coverage on s390x is certainly desirable. I'm wondering how many
other tests are needlessly restricted to certain architectures as
well...
>
> Along the way, this also cleans up some of the generic test code,
> e.g. by introducing generic functions to do hot-plugging with
> the device_add QMP command.
Cleanup also sounds good :)
>
> Please review!
>
> Thanks,
> Thomas
>
>
> Thomas Huth (6):
> tests: Run filter-redirector and -mirror test only on POSIX systems
> tests: Add network filter tests to the check-qtest-s390x list
I think these two are fine as-is.
> tests: Enable the drive_del test also on s390x
> tests: Introduce generic device hot-plug/hot-unplug functions
> tests: Add qvirtio_(un)plug_device_test wrapper functions
> tests: Enable the simple virtio tests on s390x, too
But these probably need some work (or at least, some thought.)
>
> tests/Makefile.include | 20 +++++++++-----
> tests/drive_del-test.c | 13 ++++-----
> tests/libqos/pci.c | 19 ++-----------
> tests/libqos/usb.c | 30 +++++----------------
> tests/libqos/virtio.c | 29 ++++++++++++++++++++
> tests/libqos/virtio.h | 5 ++++
> tests/libqtest.c | 60 ++++++++++++++++++++++++++++++++++++++++++
> tests/libqtest.h | 19 +++++++++++++
> tests/test-filter-mirror.c | 14 +++++-----
> tests/test-filter-redirector.c | 32 +++++++++++-----------
> tests/test-netfilter.c | 11 +++++++-
> tests/usb-hcd-uhci-test.c | 26 ++----------------
> tests/usb-hcd-xhci-test.c | 51 +++--------------------------------
> tests/virtio-balloon-test.c | 6 ++---
> tests/virtio-console-test.c | 12 ++++-----
> tests/virtio-net-test.c | 8 ++----
> tests/virtio-rng-test.c | 17 +++++-------
> tests/virtio-scsi-test.c | 24 ++---------------
> tests/virtio-serial-test.c | 33 +++++------------------
> 19 files changed, 208 insertions(+), 221 deletions(-)
>
The big question remains again: Who merges this? I can merge this
through the s390x tree if there are no other takers.