Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1502134806-13669-1-git-send-email-dverma@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] Vmstate-static-checker.py fix upstream
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
70f617a8dd Add new functions for whitelisting and their calls
08fd5e2a45 Update the existing whitelist
7451f74a3b Fix format and styles; make code more pythonic
=== OUTPUT BEGIN ===
Checking PATCH 1/3: Fix format and styles; make code more pythonic...
WARNING: line over 80 characters
#216: FILE: scripts/vmstate-static-checker.py:358:
+ 'minimum version error: ' + str(src_ver["version_id"]) + ' < ' +
total: 0 errors, 1 warnings, 245 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/3: Update the existing whitelist...
WARNING: line over 80 characters
#36: FILE: scripts/vmstate-static-checker.py:98:
+ 'e1000e': ['PCIDevice', 'PCIEDevice', 'intr_state', 'redhat_7_3_intr_state'],
total: 0 errors, 1 warnings, 40 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: Add new functions for whitelisting and their calls...
ERROR: line over 90 characters
#48: FILE: scripts/vmstate-static-checker.py:64:
+# A lot of errors are generated due to differences in sizes some of which are false positives. This list
WARNING: line over 80 characters
#60: FILE: scripts/vmstate-static-checker.py:76:
+ if (old_size in new_sizes_list[field] and new_size in new_sizes_list[field]):
WARNING: line over 80 characters
#141: FILE: scripts/vmstate-static-checker.py:390:
+ # commit 20daa90a20d, extra field 'config' was added in newer releases
WARNING: line over 80 characters
#142: FILE: scripts/vmstate-static-checker.py:391:
+ # there will be a mismatch in the number of fields of irq_state and config
WARNING: line over 80 characters
#196: FILE: scripts/vmstate-static-checker.py:471:
+ check_fields(src_desc[field], dest_desc[field], src_desc["name"], sec)
WARNING: line over 80 characters
#201: FILE: scripts/vmstate-static-checker.py:474:
+ check_subsections(src_desc[field], dest_desc[field], src_desc["name"], sec)
WARNING: line over 80 characters
#213: FILE: scripts/vmstate-static-checker.py:479:
+ if not check_updated_sizes(sec, src_ver["version_id"], dest_ver["version_id"]):
ERROR: line over 90 characters
#217: FILE: scripts/vmstate-static-checker.py:483:
+ print ('version error: ' + str(src_ver["version_id"]) + ' > ' + str(dest_ver["version_id"]))
ERROR: line over 90 characters
#231: FILE: scripts/vmstate-static-checker.py:490:
+ if not check_updated_sizes(sec, src_ver["version_id"], dest_ver["minimum_version_id"]):
WARNING: line over 80 characters
#235: FILE: scripts/vmstate-static-checker.py:494:
+ 'minimum version error: ' + str(src_ver["version_id"]) + ' < ' +
WARNING: line over 80 characters
#259: FILE: scripts/vmstate-static-checker.py:509:
+ print ('size mismatch: ' + str(src["size"]) + ' , ' + str(dest["size"]))
total: 3 errors, 8 warnings, 269 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org