[v4] qcow2: space preallocation and COW improvements

[Qemu-devel] [PATCH v4 08/15] qcow2: set inactive flag

Posted by Anton Nefedov 8 years, 6 months ago

Qcow2State and BlockDriverState flags have to be in sync

Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
---
 block/qcow2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/qcow2.c b/block/qcow2.c
index 66aa8c2..2a1d2f2 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2138,6 +2138,7 @@ static int qcow2_inactivate(BlockDriverState *bs)
 
     if (result == 0) {
         qcow2_mark_clean(bs);
+        s->flags |= BDRV_O_INACTIVE;
     }
 
     return result;
-- 
2.7.4

Re: [Qemu-devel] [PATCH v4 08/15] qcow2: set inactive flag

Posted by Eric Blake 8 years, 6 months ago

On 08/01/2017 09:19 AM, Anton Nefedov wrote:
> Qcow2State and BlockDriverState flags have to be in sync
> 
> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
> ---
>  block/qcow2.c | 1 +
>  1 file changed, 1 insertion(+)

Is this a bug fix needed for 2.10?

> 
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 66aa8c2..2a1d2f2 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -2138,6 +2138,7 @@ static int qcow2_inactivate(BlockDriverState *bs)
>  
>      if (result == 0) {
>          qcow2_mark_clean(bs);
> +        s->flags |= BDRV_O_INACTIVE;
>      }
>  
>      return result;
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v4 08/15] qcow2: set inactive flag

Posted by Anton Nefedov 8 years, 6 months ago

On 08/04/2017 11:00 PM, Eric Blake wrote:
> On 08/01/2017 09:19 AM, Anton Nefedov wrote:
>> Qcow2State and BlockDriverState flags have to be in sync
>>
>> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
>> ---
>>   block/qcow2.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Is this a bug fix needed for 2.10?
> 

I don't think this bites us now, but yes looks like a bug

>>
>> diff --git a/block/qcow2.c b/block/qcow2.c
>> index 66aa8c2..2a1d2f2 100644
>> --- a/block/qcow2.c
>> +++ b/block/qcow2.c
>> @@ -2138,6 +2138,7 @@ static int qcow2_inactivate(BlockDriverState *bs)
>>   
>>       if (result == 0) {
>>           qcow2_mark_clean(bs);
>> +        s->flags |= BDRV_O_INACTIVE;
>>       }
>>   
>>       return result;
>>
> 
/Anton