[Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState

Peter Xu posted 29 patches 8 years, 6 months ago
There is a newer version of this series
[Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState
Posted by Peter Xu 8 years, 6 months ago
Comments for "migration_dirty_pages" and "bitmap_mutex" are switched.
Fix it.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/ram.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index c93973c..c12358d 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -222,9 +222,9 @@ struct RAMState {
     uint64_t iterations_prev;
     /* Iterations since start */
     uint64_t iterations;
-    /* protects modification of the bitmap */
-    uint64_t migration_dirty_pages;
     /* number of dirty bits in the bitmap */
+    uint64_t migration_dirty_pages;
+    /* protects modification of the bitmap */
     QemuMutex bitmap_mutex;
     /* The RAMBlock used in the last src_page_requests */
     RAMBlock *last_req_rb;
-- 
2.7.4


Re: [Qemu-devel] [RFC 02/29] migration: fix comment disorder in RAMState
Posted by Dr. David Alan Gilbert 8 years, 6 months ago
* Peter Xu (peterx@redhat.com) wrote:
> Comments for "migration_dirty_pages" and "bitmap_mutex" are switched.
> Fix it.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>

Split this out, it can go in a trivial patch probably sooner.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  migration/ram.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index c93973c..c12358d 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -222,9 +222,9 @@ struct RAMState {
>      uint64_t iterations_prev;
>      /* Iterations since start */
>      uint64_t iterations;
> -    /* protects modification of the bitmap */
> -    uint64_t migration_dirty_pages;
>      /* number of dirty bits in the bitmap */
> +    uint64_t migration_dirty_pages;
> +    /* protects modification of the bitmap */
>      QemuMutex bitmap_mutex;
>      /* The RAMBlock used in the last src_page_requests */
>      RAMBlock *last_req_rb;
> -- 
> 2.7.4
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK