[Qemu-devel] [PATCH for-2.10 1/4] bsd-user/mmap.c: Move __thread attribute to right place

Peter Maydell posted 4 patches 8 years, 6 months ago
[Qemu-devel] [PATCH for-2.10 1/4] bsd-user/mmap.c: Move __thread attribute to right place
Posted by Peter Maydell 8 years, 6 months ago
Avoid a compiler warning on OpenBSD:
bsd-user/mmap.c:28:1: warning: '__thread' is not at beginning of declaration [-Wold-style-declaration]
by moving the __thread attribute to its proper place.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 bsd-user/mmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
index 7f2018e..20cd29d 100644
--- a/bsd-user/mmap.c
+++ b/bsd-user/mmap.c
@@ -25,7 +25,7 @@
 //#define DEBUG_MMAP
 
 static pthread_mutex_t mmap_mutex = PTHREAD_MUTEX_INITIALIZER;
-static int __thread mmap_lock_count;
+static __thread int mmap_lock_count;
 
 void mmap_lock(void)
 {
-- 
2.7.4


Re: [Qemu-devel] [PATCH for-2.10 1/4] bsd-user/mmap.c: Move __thread attribute to right place
Posted by Philippe Mathieu-Daudé 8 years, 6 months ago
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Le 18 juil. 2017 1:29 PM, "Peter Maydell" <peter.maydell@linaro.org> a
écrit :

> Avoid a compiler warning on OpenBSD:
> bsd-user/mmap.c:28:1: warning: '__thread' is not at beginning of
> declaration [-Wold-style-declaration]
> by moving the __thread attribute to its proper place.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  bsd-user/mmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bsd-user/mmap.c b/bsd-user/mmap.c
> index 7f2018e..20cd29d 100644
> --- a/bsd-user/mmap.c
> +++ b/bsd-user/mmap.c
> @@ -25,7 +25,7 @@
>  //#define DEBUG_MMAP
>
>  static pthread_mutex_t mmap_mutex = PTHREAD_MUTEX_INITIALIZER;
> -static int __thread mmap_lock_count;
> +static __thread int mmap_lock_count;
>
>  void mmap_lock(void)
>  {
> --
> 2.7.4
>
>
>