The following changes since commit 6632f6ff96f0537fc34cdc00c760656fc62e23c5:

Merge remote-tracking branch 'remotes/famz/tags/block-and-testing-pull-request' into staging (2017-07-17 11:46:36 +0100)

for you to fetch changes up to 189ae6bb5ce1f5a322f8691d00fe942ba43dd601:

virtio-net: fix offload ctrl endian (2017-07-17 20:13:56 +0800)

- fix virtio-net ctrl offload endian

- vnet header support for variou COLO netfilters and compare thread

virtio-net: fix offload ctrl endian

Michal Privoznik (1):

virtion-net: Prefer is_power_of_2()

Zhang Chen (12):

net: Add vnet_hdr_len arguments in NetClientState

net/net.c: Add vnet_hdr support in SocketReadState

net/filter-mirror.c: Introduce parameter for filter_send()

net/filter-mirror.c: Make filter mirror support vnet support.

net/filter-mirror.c: Add new option to enable vnet support for filter-redirector

net/colo.c: Make vnet_hdr_len as packet property

net/colo-compare.c: Introduce parameter for compare_chr_send()

net/colo-compare.c: Make colo-compare support vnet_hdr_len

net/colo.c: Add vnet packet parse feature in colo-proxy

net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare

net/filter-rewriter.c: Make filter-rewriter support vnet_hdr_len

docs/colo-proxy.txt: Update colo-proxy usage of net driver with vnet_header

docs/colo-proxy.txt | 26 ++++++++++++++++

hw/net/virtio-net.c | 4 ++-

include/net/net.h | 10 ++++--

net/colo-compare.c | 84 ++++++++++++++++++++++++++++++++++++++++++---------

net/colo.c | 9 +++---

net/colo.h | 4 ++-

net/filter-mirror.c | 75 +++++++++++++++++++++++++++++++++++++++++----

net/filter-rewriter.c | 37 ++++++++++++++++++++++-

net/net.c | 37 ++++++++++++++++++++---

net/socket.c | 8 ++---

qemu-options.hx | 19 ++++++------

11 files changed, 265 insertions(+), 48 deletions(-)

Spec said offloads should be le64, so use virtio_ldq_p() to guarantee

valid endian.

Fixes: 644c98587d4c ("virtio-net: dynamic network offloads configuration")

Cc: Dmitry Fleytman <dfleytma@redhat.com>

hw/net/virtio-net.c | 2 ++

1 file changed, 2 insertions(+)

@@ -XXX,XX +XXX,XX @@ static int virtio_net_handle_offloads(VirtIONet *n, uint8_t cmd,

if (cmd == VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET) {

uint64_t supported_offloads;

+ offloads = virtio_ldq_p(vdev, &offloads);

+

if (!n->has_vnet_hdr) {

return VIRTIO_NET_ERR;

}

From: Michal Privoznik <mprivozn@redhat.com>

We have a function that checks if given number is power of two.

We should prefer it instead of expanding the check on our own.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

hw/net/virtio-net.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

--- a/hw/net/virtio-net.c

+++ b/hw/net/virtio-net.c

@@ -XXX,XX +XXX,XX @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp)

*/

if (n->net_conf.rx_queue_size < VIRTIO_NET_RX_QUEUE_MIN_SIZE ||

n->net_conf.rx_queue_size > VIRTQUEUE_MAX_SIZE ||

- (n->net_conf.rx_queue_size & (n->net_conf.rx_queue_size - 1))) {

+ !is_power_of_2(n->net_conf.rx_queue_size)) {

error_setg(errp, "Invalid rx_queue_size (= %" PRIu16 "), "

"must be a power of 2 between %d and %d.",

n->net_conf.rx_queue_size, VIRTIO_NET_RX_QUEUE_MIN_SIZE,

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

We add the vnet_hdr_support option for filter-redirector, default is disabled.

If you use virtio-net-pci net driver or other driver needs vnet_hdr, please enable it.

Because colo-compare or other modules needs the vnet_hdr_len to parse

packet, we add this new option send the len to others.

You can use it for example:

-object filter-redirector,id=r0,netdev=hn0,queue=tx,outdev=red0,vnet_hdr_support

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

net/filter-mirror.c | 23 +++++++++++++++++++++++

qemu-options.hx | 6 +++---

2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/net/filter-mirror.c b/net/filter-mirror.c

--- a/net/filter-mirror.c

+++ b/net/filter-mirror.c

@@ -XXX,XX +XXX,XX @@ static void filter_redirector_set_outdev(Object *obj,

s->outdev = g_strdup(value);

+static bool filter_redirector_get_vnet_hdr(Object *obj, Error **errp)

+ MirrorState *s = FILTER_REDIRECTOR(obj);

+

+ return s->vnet_hdr;

+static void filter_redirector_set_vnet_hdr(Object *obj,

+ bool value,

+ Error **errp)

+ MirrorState *s = FILTER_REDIRECTOR(obj);

+

+ s->vnet_hdr = value;

static void filter_mirror_init(Object *obj)

MirrorState *s = FILTER_MIRROR(obj);

@@ -XXX,XX +XXX,XX @@ static void filter_mirror_init(Object *obj)

static void filter_redirector_init(Object *obj)

{

+ MirrorState *s = FILTER_REDIRECTOR(obj);

object_property_add_str(obj, "indev", filter_redirector_get_indev,

filter_redirector_set_indev, NULL);

object_property_add_str(obj, "outdev", filter_redirector_get_outdev,

filter_redirector_set_outdev, NULL);

+ s->vnet_hdr = false;

+ object_property_add_bool(obj, "vnet_hdr_support",

+ filter_redirector_get_vnet_hdr,

+ filter_redirector_set_vnet_hdr, NULL);

static void filter_mirror_fini(Object *obj)

diff --git a/qemu-options.hx b/qemu-options.hx

index XXXXXXX..XXXXXXX 100644

--- a/qemu-options.hx

+++ b/qemu-options.hx

@@ -XXX,XX +XXX,XX @@ queue @var{all|rx|tx} is an option that can be applied to any netfilter.

filter-mirror on netdev @var{netdevid},mirror net packet to chardev@var{chardevid}, if it has the vnet_hdr_support flag, filter-mirror will mirror packet with vnet_hdr_len.

-@item -object filter-redirector,id=@var{id},netdev=@var{netdevid},indev=@var{chardevid},

-outdev=@var{chardevid}[,queue=@var{all|rx|tx}]

+@item -object filter-redirector,id=@var{id},netdev=@var{netdevid},indev=@var{chardevid},outdev=@var{chardevid},queue=@var{all|rx|tx}[,vnet_hdr_support]

filter-redirector on netdev @var{netdevid},redirect filter's net packet to chardev

-@var{chardevid},and redirect indev's packet to filter.

+@var{chardevid},and redirect indev's packet to filter.if it has the vnet_hdr_support flag,

+filter-redirector will redirect packet with vnet_hdr_len.

Create a filter-redirector we need to differ outdev id from indev id, id can not

be the same. we can just use indev or outdev, but at least one of indev or outdev

need to be specified.

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

docs/colo-proxy.txt | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)

diff --git a/docs/colo-proxy.txt b/docs/colo-proxy.txt

--- a/docs/colo-proxy.txt

+++ b/docs/colo-proxy.txt

@@ -XXX,XX +XXX,XX @@ Secondary(ip:3.3.3.8):

-chardev socket,id=red1,host=3.3.3.3,port=9004

-object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0

-object filter-redirector,id=f2,netdev=hn0,queue=rx,outdev=red1

+-object filter-rewriter,id=f3,netdev=hn0,queue=all

+If you want to use virtio-net-pci or other driver with vnet_header:

+Primary(ip:3.3.3.3):

+-netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown

+-device e1000,id=e0,netdev=hn0,mac=52:a4:00:12:78:66

+-chardev socket,id=mirror0,host=3.3.3.3,port=9003,server,nowait

+-chardev socket,id=compare1,host=3.3.3.3,port=9004,server,nowait

+-chardev socket,id=compare0,host=3.3.3.3,port=9001,server,nowait

+-chardev socket,id=compare0-0,host=3.3.3.3,port=9001

+-chardev socket,id=compare_out,host=3.3.3.3,port=9005,server,nowait

+-chardev socket,id=compare_out0,host=3.3.3.3,port=9005

+-object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=mirror0,vnet_hdr_support

+-object filter-redirector,netdev=hn0,id=redire0,queue=rx,indev=compare_out,vnet_hdr_support

+-object filter-redirector,netdev=hn0,id=redire1,queue=rx,outdev=compare0,vnet_hdr_support

+-object colo-compare,id=comp0,primary_in=compare0-0,secondary_in=compare1,outdev=compare_out0,vnet_hdr_support

+Secondary(ip:3.3.3.8):

+-netdev tap,id=hn0,vhost=off,script=/etc/qemu-ifup,down script=/etc/qemu-ifdown

+-device e1000,netdev=hn0,mac=52:a4:00:12:78:66

+-chardev socket,id=red0,host=3.3.3.3,port=9003

+-chardev socket,id=red1,host=3.3.3.3,port=9004

+-object filter-redirector,id=f1,netdev=hn0,queue=tx,indev=red0,vnet_hdr_support

+-object filter-redirector,id=f2,netdev=hn0,queue=rx,outdev=red1,vnet_hdr_support

+-object filter-rewriter,id=f3,netdev=hn0,queue=all,vnet_hdr_support

Note:

a.COLO-proxy must work with COLO-frame and Block-replication.

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

We add the vnet_hdr_support option for filter-rewriter, default is disabled.

If you use virtio-net-pci or other driver needs vnet_hdr, please enable it.

You can use it for example:

-object filter-rewriter,id=rew0,netdev=hn0,queue=all,vnet_hdr_support

We get the vnet_hdr_len from NetClientState that make us

parse net packet correctly.

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

net/filter-rewriter.c | 37 ++++++++++++++++++++++++++++++++++++-

qemu-options.hx | 4 ++--

2 files changed, 38 insertions(+), 3 deletions(-)

diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c

--- a/net/filter-rewriter.c

+++ b/net/filter-rewriter.c

@@ -XXX,XX +XXX,XX @@

#include "qemu-common.h"

#include "qapi/error.h"

#include "qapi/qmp/qerror.h"

+#include "qemu/error-report.h"

#include "qapi-visit.h"

#include "qom/object.h"

#include "qemu/main-loop.h"

@@ -XXX,XX +XXX,XX @@ typedef struct RewriterState {

NetQueue *incoming_queue;

/* hashtable to save connection */

GHashTable *connection_track_table;

+ bool vnet_hdr;

} RewriterState;

static void filter_rewriter_flush(NetFilterState *nf)

@@ -XXX,XX +XXX,XX @@ static ssize_t colo_rewriter_receive_iov(NetFilterState *nf,

ConnectionKey key;

Packet *pkt;

ssize_t size = iov_size(iov, iovcnt);

+ ssize_t vnet_hdr_len = 0;

char *buf = g_malloc0(size);

iov_to_buf(iov, iovcnt, 0, buf, size);

- pkt = packet_new(buf, size, 0);

+

+ if (s->vnet_hdr) {

+ vnet_hdr_len = nf->netdev->vnet_hdr_len;

+ }

+

+ pkt = packet_new(buf, size, vnet_hdr_len);

g_free(buf);

/*

@@ -XXX,XX +XXX,XX @@ static void colo_rewriter_setup(NetFilterState *nf, Error **errp)

s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);

+static bool filter_rewriter_get_vnet_hdr(Object *obj, Error **errp)

+ RewriterState *s = FILTER_COLO_REWRITER(obj);

+

+ return s->vnet_hdr;

+static void filter_rewriter_set_vnet_hdr(Object *obj,

+ bool value,

+ Error **errp)

+ RewriterState *s = FILTER_COLO_REWRITER(obj);

+ s->vnet_hdr = value;

+static void filter_rewriter_init(Object *obj)

+ RewriterState *s = FILTER_COLO_REWRITER(obj);

+

+ s->vnet_hdr = false;

+ object_property_add_bool(obj, "vnet_hdr_support",

+ filter_rewriter_get_vnet_hdr,

+ filter_rewriter_set_vnet_hdr, NULL);

static void colo_rewriter_class_init(ObjectClass *oc, void *data)

{

NetFilterClass *nfc = NETFILTER_CLASS(oc);

@@ -XXX,XX +XXX,XX @@ static const TypeInfo colo_rewriter_info = {

.name = TYPE_FILTER_REWRITER,

.parent = TYPE_NETFILTER,

.class_init = colo_rewriter_class_init,

+ .instance_init = filter_rewriter_init,

.instance_size = sizeof(RewriterState),

};

diff --git a/qemu-options.hx b/qemu-options.hx

--- a/qemu-options.hx

+++ b/qemu-options.hx

@@ -XXX,XX +XXX,XX @@ Create a filter-redirector we need to differ outdev id from indev id, id can not

be the same. we can just use indev or outdev, but at least one of indev or outdev

need to be specified.

-@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid}[,queue=@var{all|rx|tx}]

+@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},queue=@var{all|rx|tx},[vnet_hdr_support]

Filter-rewriter is a part of COLO project.It will rewrite tcp packet to

secondary from primary to keep secondary tcp connection,and rewrite

tcp packet to primary from secondary make tcp packet can be handled by

-client.

+client.if it has the vnet_hdr_support flag, we can parse packet with vnet header.

usage:

colo secondary:

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

We add the vnet_hdr_support option for colo-compare, default is disabled.

If you use virtio-net-pci or other driver needs vnet_hdr, please enable it.

You can use it for example:

-object colo-compare,id=comp0,primary_in=compare0-0,secondary_in=compare1,outdev=compare_out0,vnet_hdr_support

COLO-compare can get vnet header length from filter,

Add vnet_hdr_len to struct packet and output packet with

the vnet_hdr_len.

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

net/colo-compare.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++-------

qemu-options.hx | 4 ++--

2 files changed, 55 insertions(+), 9 deletions(-)

diff --git a/net/colo-compare.c b/net/colo-compare.c

--- a/net/colo-compare.c

+++ b/net/colo-compare.c

@@ -XXX,XX +XXX,XX @@ typedef struct CompareState {

CharBackend chr_out;

SocketReadState pri_rs;

SocketReadState sec_rs;

+ bool vnet_hdr;

/* connection list: the connections belonged to this NIC could be found

* in this list.

@@ -XXX,XX +XXX,XX @@ enum {

static int compare_chr_send(CompareState *s,

const uint8_t *buf,

- uint32_t size);

+ uint32_t size,

+ uint32_t vnet_hdr_len);

static gint seq_sorter(Packet *a, Packet *b, gpointer data)

@@ -XXX,XX +XXX,XX @@ static void colo_compare_connection(void *opaque, void *user_data)

}

if (result) {

- ret = compare_chr_send(s, pkt->data, pkt->size);

+ ret = compare_chr_send(s,

+ pkt->data,

+ pkt->size,

+ pkt->vnet_hdr_len);

if (ret < 0) {

error_report("colo_send_primary_packet failed");

}

@@ -XXX,XX +XXX,XX @@ static void colo_compare_connection(void *opaque, void *user_data)

static int compare_chr_send(CompareState *s,

const uint8_t *buf,

- uint32_t size)

+ uint32_t size,

+ uint32_t vnet_hdr_len)

int ret = 0;

uint32_t len = htonl(size);

@@ -XXX,XX +XXX,XX @@ static int compare_chr_send(CompareState *s,

goto err;

}

+ if (s->vnet_hdr) {

+ * We send vnet header len make other module(like filter-redirector)

+ * know how to parse net packet correctly.

+ len = htonl(vnet_hdr_len);

+ ret = qemu_chr_fe_write_all(&s->chr_out, (uint8_t *)&len, sizeof(len));

+ if (ret != sizeof(len)) {

+ goto err;

+ }

ret = qemu_chr_fe_write_all(&s->chr_out, (uint8_t *)buf, size);

if (ret != size) {

goto err;

@@ -XXX,XX +XXX,XX @@ static void compare_set_outdev(Object *obj, const char *value, Error **errp)

s->outdev = g_strdup(value);

+static bool compare_get_vnet_hdr(Object *obj, Error **errp)

+{

+ CompareState *s = COLO_COMPARE(obj);

+ return s->vnet_hdr;

+}

+static void compare_set_vnet_hdr(Object *obj,

+ bool value,

+ Error **errp)

+{

+ CompareState *s = COLO_COMPARE(obj);

+

+ s->vnet_hdr = value;

+}

+

static void compare_pri_rs_finalize(SocketReadState *pri_rs)

{

CompareState *s = container_of(pri_rs, CompareState, pri_rs);

if (packet_enqueue(s, PRIMARY_IN)) {

trace_colo_compare_main("primary: unsupported packet in");

- compare_chr_send(s, pri_rs->buf, pri_rs->packet_len);

+ compare_chr_send(s,

+ pri_rs->buf,

+ pri_rs->packet_len,

+ pri_rs->vnet_hdr_len);

} else {

/* compare connection */

g_queue_foreach(&s->conn_list, colo_compare_connection, s);

@@ -XXX,XX +XXX,XX @@ static void colo_compare_complete(UserCreatable *uc, Error **errp)

return;

}

- net_socket_rs_init(&s->pri_rs, compare_pri_rs_finalize, false);

- net_socket_rs_init(&s->sec_rs, compare_sec_rs_finalize, false);

+ net_socket_rs_init(&s->pri_rs, compare_pri_rs_finalize, s->vnet_hdr);

+ net_socket_rs_init(&s->sec_rs, compare_sec_rs_finalize, s->vnet_hdr);

g_queue_init(&s->conn_list);

@@ -XXX,XX +XXX,XX @@ static void colo_flush_packets(void *opaque, void *user_data)

while (!g_queue_is_empty(&conn->primary_list)) {

pkt = g_queue_pop_head(&conn->primary_list);

- compare_chr_send(s, pkt->data, pkt->size);

+ compare_chr_send(s,

+ pkt->data,

+ pkt->size,

+ pkt->vnet_hdr_len);

packet_destroy(pkt, NULL);

}

while (!g_queue_is_empty(&conn->secondary_list)) {

@@ -XXX,XX +XXX,XX @@ static void colo_compare_class_init(ObjectClass *oc, void *data)

static void colo_compare_init(Object *obj)

{

+ CompareState *s = COLO_COMPARE(obj);