The following changes since commit 6632f6ff96f0537fc34cdc00c760656fc62e23c5:

Merge remote-tracking branch 'remotes/famz/tags/block-and-testing-pull-request' into staging (2017-07-17 11:46:36 +0100)

for you to fetch changes up to 189ae6bb5ce1f5a322f8691d00fe942ba43dd601:

virtio-net: fix offload ctrl endian (2017-07-17 20:13:56 +0800)

- fix virtio-net ctrl offload endian

- vnet header support for variou COLO netfilters and compare thread

----------------------------------------------------------------

Jason Wang (1):

virtio-net: fix offload ctrl endian

Michal Privoznik (1):

virtion-net: Prefer is_power_of_2()

Zhang Chen (12):

net: Add vnet_hdr_len arguments in NetClientState

net/net.c: Add vnet_hdr support in SocketReadState

net/filter-mirror.c: Introduce parameter for filter_send()

net/filter-mirror.c: Make filter mirror support vnet support.

net/filter-mirror.c: Add new option to enable vnet support for filter-redirector

net/colo.c: Make vnet_hdr_len as packet property

net/colo-compare.c: Introduce parameter for compare_chr_send()

net/colo-compare.c: Make colo-compare support vnet_hdr_len

net/colo.c: Add vnet packet parse feature in colo-proxy

net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare

net/filter-rewriter.c: Make filter-rewriter support vnet_hdr_len

docs/colo-proxy.txt: Update colo-proxy usage of net driver with vnet_header

docs/colo-proxy.txt | 26 ++++++++++++++++

hw/net/virtio-net.c | 4 ++-

include/net/net.h | 10 ++++--

net/colo-compare.c | 84 ++++++++++++++++++++++++++++++++++++++++++---------

net/colo.c | 9 +++---

net/colo.h | 4 ++-

net/filter-mirror.c | 75 +++++++++++++++++++++++++++++++++++++++++----

net/filter-rewriter.c | 37 ++++++++++++++++++++++-

net/net.c | 37 ++++++++++++++++++++---

net/socket.c | 8 ++---

qemu-options.hx | 19 ++++++------

11 files changed, 265 insertions(+), 48 deletions(-)

We add the vnet_hdr_support option for filter-rewriter, default is disabled.

If you use virtio-net-pci or other driver needs vnet_hdr, please enable it.

You can use it for example:

-object filter-rewriter,id=rew0,netdev=hn0,queue=all,vnet_hdr_support

We get the vnet_hdr_len from NetClientState that make us

parse net packet correctly.

net/filter-rewriter.c | 37 ++++++++++++++++++++++++++++++++++++-

qemu-options.hx | 4 ++--

2 files changed, 38 insertions(+), 3 deletions(-)

@@ -XXX,XX +XXX,XX @@

#include "qemu-common.h"

#include "qapi/error.h"

#include "qapi/qmp/qerror.h"

+#include "qemu/error-report.h"

#include "qapi-visit.h"

#include "qom/object.h"

#include "qemu/main-loop.h"

@@ -XXX,XX +XXX,XX @@ typedef struct RewriterState {

NetQueue *incoming_queue;

/* hashtable to save connection */

GHashTable *connection_track_table;

+ bool vnet_hdr;

} RewriterState;

static void filter_rewriter_flush(NetFilterState *nf)

@@ -XXX,XX +XXX,XX @@ static ssize_t colo_rewriter_receive_iov(NetFilterState *nf,

ConnectionKey key;

Packet *pkt;

ssize_t size = iov_size(iov, iovcnt);

+ ssize_t vnet_hdr_len = 0;

char *buf = g_malloc0(size);

iov_to_buf(iov, iovcnt, 0, buf, size);

- pkt = packet_new(buf, size, 0);

+

+ if (s->vnet_hdr) {

+ vnet_hdr_len = nf->netdev->vnet_hdr_len;

+ }

+

+ pkt = packet_new(buf, size, vnet_hdr_len);

g_free(buf);

/*

@@ -XXX,XX +XXX,XX @@ static void colo_rewriter_setup(NetFilterState *nf, Error **errp)

s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);

}

+static bool filter_rewriter_get_vnet_hdr(Object *obj, Error **errp)

+{

+ RewriterState *s = FILTER_COLO_REWRITER(obj);

+

+ return s->vnet_hdr;

+}

+

+static void filter_rewriter_set_vnet_hdr(Object *obj,

+ bool value,

+ Error **errp)

+{

+ RewriterState *s = FILTER_COLO_REWRITER(obj);

+

+ s->vnet_hdr = value;

+}

+

+static void filter_rewriter_init(Object *obj)

+{

+ RewriterState *s = FILTER_COLO_REWRITER(obj);

+

+ s->vnet_hdr = false;

+ object_property_add_bool(obj, "vnet_hdr_support",

+ filter_rewriter_get_vnet_hdr,

+ filter_rewriter_set_vnet_hdr, NULL);

+}

+

static void colo_rewriter_class_init(ObjectClass *oc, void *data)

{

NetFilterClass *nfc = NETFILTER_CLASS(oc);

@@ -XXX,XX +XXX,XX @@ static const TypeInfo colo_rewriter_info = {

.name = TYPE_FILTER_REWRITER,

.parent = TYPE_NETFILTER,

.class_init = colo_rewriter_class_init,

+ .instance_init = filter_rewriter_init,

.instance_size = sizeof(RewriterState),

};

diff --git a/qemu-options.hx b/qemu-options.hx

index XXXXXXX..XXXXXXX 100644

--- a/qemu-options.hx

+++ b/qemu-options.hx

@@ -XXX,XX +XXX,XX @@ Create a filter-redirector we need to differ outdev id from indev id, id can not

be the same. we can just use indev or outdev, but at least one of indev or outdev

need to be specified.

-@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid}[,queue=@var{all|rx|tx}]

+@item -object filter-rewriter,id=@var{id},netdev=@var{netdevid},queue=@var{all|rx|tx},[vnet_hdr_support]

Filter-rewriter is a part of COLO project.It will rewrite tcp packet to

secondary from primary to keep secondary tcp connection,and rewrite

tcp packet to primary from secondary make tcp packet can be handled by

-client.

+client.if it has the vnet_hdr_support flag, we can parse packet with vnet header.

usage:

colo secondary:

Spec said offloads should be le64, so use virtio_ldq_p() to guarantee

valid endian.

Fixes: 644c98587d4c ("virtio-net: dynamic network offloads configuration")

Cc: qemu-stable@nongnu.org

Cc: Dmitry Fleytman <dfleytma@redhat.com>

hw/net/virtio-net.c | 2 ++

1 file changed, 2 insertions(+)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c

index XXXXXXX..XXXXXXX 100644

--- a/hw/net/virtio-net.c

+++ b/hw/net/virtio-net.c

@@ -XXX,XX +XXX,XX @@ static int virtio_net_handle_offloads(VirtIONet *n, uint8_t cmd,

if (cmd == VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET) {

uint64_t supported_offloads;

+ offloads = virtio_ldq_p(vdev, &offloads);

if (!n->has_vnet_hdr) {

return VIRTIO_NET_ERR;

}

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

This patch change the filter_send() parameter from CharBackend to MirrorState,

we can get more information like vnet_hdr(We use it to support packet with vnet_header).

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

net/filter-mirror.c | 10 +++++-----

1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/filter-mirror.c b/net/filter-mirror.c

--- a/net/filter-mirror.c

+++ b/net/filter-mirror.c

@@ -XXX,XX +XXX,XX @@ typedef struct MirrorState {

SocketReadState rs;

} MirrorState;

-static int filter_send(CharBackend *chr_out,

+static int filter_send(MirrorState *s,

const struct iovec *iov,

int iovcnt)

@@ -XXX,XX +XXX,XX @@ static int filter_send(CharBackend *chr_out,

len = htonl(size);

- ret = qemu_chr_fe_write_all(chr_out, (uint8_t *)&len, sizeof(len));

+ ret = qemu_chr_fe_write_all(&s->chr_out, (uint8_t *)&len, sizeof(len));

if (ret != sizeof(len)) {

goto err;

buf = g_malloc(size);

iov_to_buf(iov, iovcnt, 0, buf, size);

- ret = qemu_chr_fe_write_all(chr_out, (uint8_t *)buf, size);

+ ret = qemu_chr_fe_write_all(&s->chr_out, (uint8_t *)buf, size);

g_free(buf);

if (ret != size) {

goto err;

@@ -XXX,XX +XXX,XX @@ static ssize_t filter_mirror_receive_iov(NetFilterState *nf,

MirrorState *s = FILTER_MIRROR(nf);

int ret;

- ret = filter_send(&s->chr_out, iov, iovcnt);

+ ret = filter_send(s, iov, iovcnt);

if (ret) {

error_report("filter mirror send failed(%s)", strerror(-ret));

@@ -XXX,XX +XXX,XX @@ static ssize_t filter_redirector_receive_iov(NetFilterState *nf,

int ret;

if (qemu_chr_fe_backend_connected(&s->chr_out)) {

- ret = filter_send(&s->chr_out, iov, iovcnt);

+ ret = filter_send(s, iov, iovcnt);

if (ret) {

error_report("filter redirector send failed(%s)", strerror(-ret));

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

Add vnet_hdr_len arguments in NetClientState

that make other module get real vnet_hdr_len easily.

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

include/net/net.h | 1 +

net/net.c | 1 +

2 files changed, 2 insertions(+)

diff --git a/include/net/net.h b/include/net/net.h

--- a/include/net/net.h

+++ b/include/net/net.h

@@ -XXX,XX +XXX,XX @@ struct NetClientState {

unsigned int queue_index;

unsigned rxfilter_notify_enabled:1;

int vring_enable;

+ int vnet_hdr_len;

QTAILQ_HEAD(NetFilterHead, NetFilterState) filters;

diff --git a/net/net.c b/net/net.c

index XXXXXXX..XXXXXXX 100644

--- a/net/net.c

+++ b/net/net.c

@@ -XXX,XX +XXX,XX @@ void qemu_set_vnet_hdr_len(NetClientState *nc, int len)

return;

+ nc->vnet_hdr_len = len;

nc->info->set_vnet_hdr_len(nc, len);

Make colo-compare and filter-rewriter can parse vnet packet.

net/colo.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/colo.c b/net/colo.c

--- a/net/colo.c

+++ b/net/colo.c

@@ -XXX,XX +XXX,XX @@ int parse_packet_early(Packet *pkt)

{

int network_length;

static const uint8_t vlan[] = {0x81, 0x00};

- uint8_t *data = pkt->data;

+ uint8_t *data = pkt->data + pkt->vnet_hdr_len;

uint16_t l3_proto;

ssize_t l2hdr_len = eth_get_l2_hdr_length(data);

- if (pkt->size < ETH_HLEN) {

+ if (pkt->size < ETH_HLEN + pkt->vnet_hdr_len) {

trace_colo_proxy_main("pkt->size < ETH_HLEN");

return 1;

}

@@ -XXX,XX +XXX,XX @@ int parse_packet_early(Packet *pkt)

}

network_length = pkt->ip->ip_hl * 4;

- if (pkt->size < l2hdr_len + network_length) {

+ if (pkt->size < l2hdr_len + network_length + pkt->vnet_hdr_len) {

trace_colo_proxy_main("pkt->size < network_header + network_length");

return 1;

}

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

We add the vnet_hdr_support option for filter-redirector, default is disabled.

If you use virtio-net-pci net driver or other driver needs vnet_hdr, please enable it.

Because colo-compare or other modules needs the vnet_hdr_len to parse

packet, we add this new option send the len to others.

You can use it for example:

-object filter-redirector,id=r0,netdev=hn0,queue=tx,outdev=red0,vnet_hdr_support

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

net/filter-mirror.c | 23 +++++++++++++++++++++++

qemu-options.hx | 6 +++---

2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/net/filter-mirror.c b/net/filter-mirror.c

--- a/net/filter-mirror.c

+++ b/net/filter-mirror.c

@@ -XXX,XX +XXX,XX @@ static void filter_redirector_set_outdev(Object *obj,

s->outdev = g_strdup(value);

+static bool filter_redirector_get_vnet_hdr(Object *obj, Error **errp)

+{

+ MirrorState *s = FILTER_REDIRECTOR(obj);

+ return s->vnet_hdr;

+}

+static void filter_redirector_set_vnet_hdr(Object *obj,

+ bool value,

+ Error **errp)

+{

+ MirrorState *s = FILTER_REDIRECTOR(obj);

+

+ s->vnet_hdr = value;

+}

+

static void filter_mirror_init(Object *obj)

{

MirrorState *s = FILTER_MIRROR(obj);

@@ -XXX,XX +XXX,XX @@ static void filter_mirror_init(Object *obj)

static void filter_redirector_init(Object *obj)

{

+ MirrorState *s = FILTER_REDIRECTOR(obj);

+

object_property_add_str(obj, "indev", filter_redirector_get_indev,

filter_redirector_set_indev, NULL);

object_property_add_str(obj, "outdev", filter_redirector_get_outdev,

filter_redirector_set_outdev, NULL);

+

+ s->vnet_hdr = false;

+ object_property_add_bool(obj, "vnet_hdr_support",

+ filter_redirector_get_vnet_hdr,

+ filter_redirector_set_vnet_hdr, NULL);

}

static void filter_mirror_fini(Object *obj)

diff --git a/qemu-options.hx b/qemu-options.hx

index XXXXXXX..XXXXXXX 100644

--- a/qemu-options.hx

+++ b/qemu-options.hx

@@ -XXX,XX +XXX,XX @@ queue @var{all|rx|tx} is an option that can be applied to any netfilter.

filter-mirror on netdev @var{netdevid},mirror net packet to chardev@var{chardevid}, if it has the vnet_hdr_support flag, filter-mirror will mirror packet with vnet_hdr_len.

-@item -object filter-redirector,id=@var{id},netdev=@var{netdevid},indev=@var{chardevid},

-outdev=@var{chardevid}[,queue=@var{all|rx|tx}]

+@item -object filter-redirector,id=@var{id},netdev=@var{netdevid},indev=@var{chardevid},outdev=@var{chardevid},queue=@var{all|rx|tx}[,vnet_hdr_support]

filter-redirector on netdev @var{netdevid},redirect filter's net packet to chardev

-@var{chardevid},and redirect indev's packet to filter.

+@var{chardevid},and redirect indev's packet to filter.if it has the vnet_hdr_support flag,

+filter-redirector will redirect packet with vnet_hdr_len.

Create a filter-redirector we need to differ outdev id from indev id, id can not

be the same. we can just use indev or outdev, but at least one of indev or outdev

need to be specified.

From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

We add a flag to decide whether net_fill_rstate() need read

the vnet_hdr_len or not.

Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>

Suggested-by: Jason Wang <jasowang@redhat.com>

include/net/net.h | 9 +++++++--

net/colo-compare.c | 4 ++--

net/filter-mirror.c | 2 +-

net/net.c | 36 ++++++++++++++++++++++++++++++++----

net/socket.c | 8 ++++----

5 files changed, 46 insertions(+), 13 deletions(-)

diff --git a/include/net/net.h b/include/net/net.h

--- a/include/net/net.h

+++ b/include/net/net.h

@@ -XXX,XX +XXX,XX @@ typedef struct NICState {

} NICState;

struct SocketReadState {

- int state; /* 0 = getting length, 1 = getting data */

+ /* 0 = getting length, 1 = getting vnet header length, 2 = getting data */

+ int state;

+ /* This flag decide whether to read the vnet_hdr_len field */

+ bool vnet_hdr;

uint32_t index;

uint32_t packet_len;

+ uint32_t vnet_hdr_len;

uint8_t buf[NET_BUFSIZE];

SocketReadStateFinalize *finalize;