MAINTAINERS | 1 - softmmu_template.h => accel/tcg/softmmu_template.h | 0 2 files changed, 1 deletion(-) rename softmmu_template.h => accel/tcg/softmmu_template.h (100%)
The header is only used by accel/tcg/cputlb.c so we can
move it to the accel/tcg/ folder, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Note: This patch should be applied after Philippe's "MAINTAINERS:
update TCG entries" patch here:
https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg06529.html
MAINTAINERS | 1 -
softmmu_template.h => accel/tcg/softmmu_template.h | 0
2 files changed, 1 deletion(-)
rename softmmu_template.h => accel/tcg/softmmu_template.h (100%)
diff --git a/MAINTAINERS b/MAINTAINERS
index 74b3956..993b12e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -86,7 +86,6 @@ M: Richard Henderson <rth@twiddle.net>
S: Maintained
F: cpus.c
F: exec.c
-F: softmmu_template.h
F: accel/tcg/
F: include/exec/cpu*.h
F: include/exec/exec-all.h
diff --git a/softmmu_template.h b/accel/tcg/softmmu_template.h
similarity index 100%
rename from softmmu_template.h
rename to accel/tcg/softmmu_template.h
--
1.8.3.1
On 11/07/2017 11:31, Thomas Huth wrote: > The header is only used by accel/tcg/cputlb.c so we can > move it to the accel/tcg/ folder, too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Note: This patch should be applied after Philippe's "MAINTAINERS: > update TCG entries" patch here: > https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg06529.html > > MAINTAINERS | 1 - > softmmu_template.h => accel/tcg/softmmu_template.h | 0 > 2 files changed, 1 deletion(-) > rename softmmu_template.h => accel/tcg/softmmu_template.h (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 74b3956..993b12e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -86,7 +86,6 @@ M: Richard Henderson <rth@twiddle.net> > S: Maintained > F: cpus.c > F: exec.c > -F: softmmu_template.h > F: accel/tcg/ > F: include/exec/cpu*.h > F: include/exec/exec-all.h > diff --git a/softmmu_template.h b/accel/tcg/softmmu_template.h > similarity index 100% > rename from softmmu_template.h > rename to accel/tcg/softmmu_template.h > Reviewed-by: Laurent Vivier <lvivier@redhat.com>
On 11/07/2017 11:31, Thomas Huth wrote: > The header is only used by accel/tcg/cputlb.c so we can > move it to the accel/tcg/ folder, too. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > Note: This patch should be applied after Philippe's "MAINTAINERS: > update TCG entries" patch here: > https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg06529.html > > MAINTAINERS | 1 - > softmmu_template.h => accel/tcg/softmmu_template.h | 0 > 2 files changed, 1 deletion(-) > rename softmmu_template.h => accel/tcg/softmmu_template.h (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 74b3956..993b12e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -86,7 +86,6 @@ M: Richard Henderson <rth@twiddle.net> > S: Maintained > F: cpus.c > F: exec.c > -F: softmmu_template.h > F: accel/tcg/ > F: include/exec/cpu*.h > F: include/exec/exec-all.h > diff --git a/softmmu_template.h b/accel/tcg/softmmu_template.h > similarity index 100% > rename from softmmu_template.h > rename to accel/tcg/softmmu_template.h > Queued, thanks. Paolo
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- same as Thomas previous patch. this file had no entry in MAINTAINERS. atomic_template.h => accel/tcg/atomic_template.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename atomic_template.h => accel/tcg/atomic_template.h (100%) diff --git a/atomic_template.h b/accel/tcg/atomic_template.h similarity index 100% rename from atomic_template.h rename to accel/tcg/atomic_template.h -- 2.13.2
On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > same as Thomas previous patch. this file had no entry in MAINTAINERS. > > atomic_template.h => accel/tcg/atomic_template.h | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename atomic_template.h => accel/tcg/atomic_template.h (100%) > > diff --git a/atomic_template.h b/accel/tcg/atomic_template.h > similarity index 100% > rename from atomic_template.h > rename to accel/tcg/atomic_template.h It's also used by a file in tcg/, but I've checked, and yes, the code still compiles fine if the header gets moved to accel/tcg/. Tested-by: Thomas Huth <thuth@redhat.com>
On 12/07/2017 07:52, Thomas Huth wrote: > On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> same as Thomas previous patch. this file had no entry in MAINTAINERS. >> >> atomic_template.h => accel/tcg/atomic_template.h | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >> >> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >> similarity index 100% >> rename from atomic_template.h >> rename to accel/tcg/atomic_template.h > > It's also used by a file in tcg/, but I've checked, and yes, the code > still compiles fine if the header gets moved to accel/tcg/. > > Tested-by: Thomas Huth <thuth@redhat.com> > That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, and user-exec.c should in turn be in accel/tcg. Since this is just code movement we can do it after soft freeze. Philippe, can you send v2? Thanks, Paolo
On 13.07.2017 13:35, Paolo Bonzini wrote: > On 12/07/2017 07:52, Thomas Huth wrote: >> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> --- >>> same as Thomas previous patch. this file had no entry in MAINTAINERS. >>> >>> atomic_template.h => accel/tcg/atomic_template.h | 0 >>> 1 file changed, 0 insertions(+), 0 deletions(-) >>> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >>> >>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >>> similarity index 100% >>> rename from atomic_template.h >>> rename to accel/tcg/atomic_template.h >> >> It's also used by a file in tcg/, but I've checked, and yes, the code >> still compiles fine if the header gets moved to accel/tcg/. >> >> Tested-by: Thomas Huth <thuth@redhat.com> >> > > That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, > and user-exec.c should in turn be in accel/tcg. > > Since this is just code movement we can do it after soft freeze. > Philippe, can you send v2? Ping? Looks like the atomic_template.h is still in the main directory ... Thomas
On 07/09/2017 11:30, Thomas Huth wrote: > On 13.07.2017 13:35, Paolo Bonzini wrote: >> On 12/07/2017 07:52, Thomas Huth wrote: >>> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>> --- >>>> same as Thomas previous patch. this file had no entry in MAINTAINERS. >>>> >>>> atomic_template.h => accel/tcg/atomic_template.h | 0 >>>> 1 file changed, 0 insertions(+), 0 deletions(-) >>>> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >>>> >>>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >>>> similarity index 100% >>>> rename from atomic_template.h >>>> rename to accel/tcg/atomic_template.h >>> >>> It's also used by a file in tcg/, but I've checked, and yes, the code >>> still compiles fine if the header gets moved to accel/tcg/. >>> >>> Tested-by: Thomas Huth <thuth@redhat.com> >>> >> >> That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, >> and user-exec.c should in turn be in accel/tcg. >> >> Since this is just code movement we can do it after soft freeze. >> Philippe, can you send v2? > > Ping? > > Looks like the atomic_template.h is still in the main directory ... Still waiting for v2... Paolo
>>>> On 11.07.2017 20:55, Philippe Mathieu-Daudé wrote: >>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >>>>> --- >>>>> same as Thomas previous patch. this file had no entry in MAINTAINERS. >>>>> >>>>> atomic_template.h => accel/tcg/atomic_template.h | 0 >>>>> 1 file changed, 0 insertions(+), 0 deletions(-) >>>>> rename atomic_template.h => accel/tcg/atomic_template.h (100%) >>>>> >>>>> diff --git a/atomic_template.h b/accel/tcg/atomic_template.h >>>>> similarity index 100% >>>>> rename from atomic_template.h >>>>> rename to accel/tcg/atomic_template.h >>>> >>>> It's also used by a file in tcg/, but I've checked, and yes, the code >>>> still compiles fine if the header gets moved to accel/tcg/. >>>> >>>> Tested-by: Thomas Huth <thuth@redhat.com> >>>> >>> >>> That part of tcg/tcg-runtime.c probably should be moved to user-exec.c, >>> and user-exec.c should in turn be in accel/tcg. >>> >>> Since this is just code movement we can do it after soft freeze. >>> Philippe, can you send v2? >> >> Ping? >> >> Looks like the atomic_template.h is still in the main directory ... > > Still waiting for v2... I chat with Thomas last night about it, with 2.10 freeze I totally forgot about this, sorry! I'll respin v2 during the day.
© 2016 - 2025 Red Hat, Inc.