[Qemu-devel] [PULL 3/8] 9pfs: replace g_malloc()+memcpy() with g_memdup()

Greg Kurz posted 8 patches 8 years, 7 months ago
[Qemu-devel] [PULL 3/8] 9pfs: replace g_malloc()+memcpy() with g_memdup()
Posted by Greg Kurz 8 years, 7 months ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

I found these pattern via grepping the source tree. I don't have a
coccinelle script for it!

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/9pfs/9p-synth.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/9pfs/9p-synth.c b/hw/9pfs/9p-synth.c
index 4b6d4e6a3f1c..df0a8de08aed 100644
--- a/hw/9pfs/9p-synth.c
+++ b/hw/9pfs/9p-synth.c
@@ -494,8 +494,7 @@ static int synth_name_to_path(FsContext *ctx, V9fsPath *dir_path,
     }
 out:
     /* Copy the node pointer to fid */
-    target->data = g_malloc(sizeof(void *));
-    memcpy(target->data, &node, sizeof(void *));
+    target->data = g_memdup(&node, sizeof(void *));
     target->size = sizeof(void *);
     return 0;
 }
-- 
2.7.5