[Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension

Peter Lieven posted 8 patches 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1498733831-15254-1-git-send-email-pl@kamp.de
Test FreeBSD passed
Test checkpatch passed
Test docker failed
Test s390x passed
There is a newer version of this series
block/qcow2-cluster.c     |  73 +++++++++++-----
block/qcow2.c             | 219 +++++++++++++++++++++++++++++++++++++++-------
block/qcow2.h             |  33 +++++--
configure                 |   2 +-
docs/interop/qcow2.txt    |  43 ++++++++-
include/block/block_int.h |   2 +
qapi/block-core.json      |  54 +++++++++++-
qemu-img.texi             |  22 +++++
8 files changed, 384 insertions(+), 64 deletions(-)
[Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension
Posted by Peter Lieven 6 years, 9 months ago
this adds a create option for Qcow2 images to specify the compression format
and level for compressed clusters. The series adds 2 algorithms to choose from:
zlib and lzo. zlib is the current default, but with unoptimal settings.
If no compress.format option is specified the old zlib with the old parameters
is used and the created images are backwards compatible with older QEMU version.
As soon as a compression format is specified a new compress format header extension
is written and the Qcow2 images are incompatible with older QEMU versions.

Some numbers for an uncompressed Debian 9 QCOW2 image (size 1148MB):

compress.format     compress time    compressed size   decompress time
none                35.7s            339MB             3.4s
zlib (default)      30.5s            320MB             3.2s
zlib (level 1)      12.8s            348MB             3.2s
lzo                  4.2s            429MB             1.6s

Changes V1->V2:
  - split the series into more patches
  - added an qapi scheme for the compression settings
  - renamed compression_algorithm to compress.format and added compress.level+
  - updated the header extension to carry a variable extra payload and compress
    level.
  - removed extra reservations for header extensions
  - added missing lzo_init and fixed compress overhead for lzo

Peter Lieven (8):
  docs: add compress format extension to qcow2 spec
  qapi: add compress parameters to Qcow2 Blockdev options
  block/qcow2: parse compress create options
  qemu-img: add documentation for compress settings
  block/qcow2: read and write the compress format extension
  block/qcow2: optimize qcow2_co_pwritev_compressed
  block/qcow2: start using the compress format extension
  block/qcow2: add lzo compress format

 block/qcow2-cluster.c     |  73 +++++++++++-----
 block/qcow2.c             | 219 +++++++++++++++++++++++++++++++++++++++-------
 block/qcow2.h             |  33 +++++--
 configure                 |   2 +-
 docs/interop/qcow2.txt    |  43 ++++++++-
 include/block/block_int.h |   2 +
 qapi/block-core.json      |  54 +++++++++++-
 qemu-img.texi             |  22 +++++
 8 files changed, 384 insertions(+), 64 deletions(-)

-- 
1.9.1


Re: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension
Posted by no-reply@patchew.org 6 years, 9 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension
Message-id: 1498733831-15254-1-git-send-email-pl@kamp.de
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
fatal: Cannot update paths and switch to branch 'test' at the same time.
Did you intend to checkout 'origin/patchew/1498733831-15254-1-git-send-email-pl@kamp.de' which can not be resolved as commit?
Traceback (most recent call last):
  File "/home/fam/bin/patchew", line 440, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf)
  File "/home/fam/bin/patchew", line 53, in git_clone_repo
    cwd=clone)
  File "/usr/lib64/python3.5/subprocess.py", line 271, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'checkout', 'origin/patchew/1498733831-15254-1-git-send-email-pl@kamp.de', '-b', 'test']' returned non-zero exit status 128



---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension
Posted by Fam Zheng 6 years, 9 months ago
On Thu, 07/06 16:49, no-reply@patchew.org wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension
> Message-id: 1498733831-15254-1-git-send-email-pl@kamp.de
> Type: series
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> fatal: Cannot update paths and switch to branch 'test' at the same time.
> Did you intend to checkout 'origin/patchew/1498733831-15254-1-git-send-email-pl@kamp.de' which can not be resolved as commit?
> Traceback (most recent call last):
>   File "/home/fam/bin/patchew", line 440, in test_one
>     git_clone_repo(clone, r["repo"], r["head"], logf)
>   File "/home/fam/bin/patchew", line 53, in git_clone_repo
>     cwd=clone)
>   File "/usr/lib64/python3.5/subprocess.py", line 271, in check_call
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['git', 'checkout', 'origin/patchew/1498733831-15254-1-git-send-email-pl@kamp.de', '-b', 'test']' returned non-zero exit status 128

Ignore this please, patchew is recovering from a bad state.

Re: [Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension
Posted by Peter Lieven 6 years, 9 months ago
Am 29.06.2017 um 12:57 schrieb Peter Lieven:
> this adds a create option for Qcow2 images to specify the compression format
> and level for compressed clusters. The series adds 2 algorithms to choose from:
> zlib and lzo. zlib is the current default, but with unoptimal settings.
> If no compress.format option is specified the old zlib with the old parameters
> is used and the created images are backwards compatible with older QEMU version.
> As soon as a compression format is specified a new compress format header extension
> is written and the Qcow2 images are incompatible with older QEMU versions.
>
> Some numbers for an uncompressed Debian 9 QCOW2 image (size 1148MB):
>
> compress.format     compress time    compressed size   decompress time
> none                35.7s            339MB             3.4s
> zlib (default)      30.5s            320MB             3.2s
> zlib (level 1)      12.8s            348MB             3.2s
> lzo                  4.2s            429MB             1.6s
>
> Changes V1->V2:
>    - split the series into more patches
>    - added an qapi scheme for the compression settings
>    - renamed compression_algorithm to compress.format and added compress.level+
>    - updated the header extension to carry a variable extra payload and compress
>      level.
>    - removed extra reservations for header extensions
>    - added missing lzo_init and fixed compress overhead for lzo
>
> Peter Lieven (8):
>    docs: add compress format extension to qcow2 spec
>    qapi: add compress parameters to Qcow2 Blockdev options
>    block/qcow2: parse compress create options
>    qemu-img: add documentation for compress settings
>    block/qcow2: read and write the compress format extension
>    block/qcow2: optimize qcow2_co_pwritev_compressed
>    block/qcow2: start using the compress format extension
>    block/qcow2: add lzo compress format
>
>   block/qcow2-cluster.c     |  73 +++++++++++-----
>   block/qcow2.c             | 219 +++++++++++++++++++++++++++++++++++++++-------
>   block/qcow2.h             |  33 +++++--
>   configure                 |   2 +-
>   docs/interop/qcow2.txt    |  43 ++++++++-
>   include/block/block_int.h |   2 +
>   qapi/block-core.json      |  54 +++++++++++-
>   qemu-img.texi             |  22 +++++
>   8 files changed, 384 insertions(+), 64 deletions(-)
>

Hi,


had anyone had a chance to look at the updated specs?


Thanks,

Peter