[Qemu-devel] [RFC PATCH v7 00/26] translate: [tcg] Generic translation framework

Lluís Vilanova posted 26 patches 8 years, 4 months ago
Only 5 patches received!
There is a newer version of this series
Makefile.target                |    1
include/exec/exec-all.h        |   13 +
include/exec/gen-icount.h      |    8 -
include/exec/translate-block.h |  125 ++++++++++
include/qemu/queue.h           |   12 +
include/qom/cpu.h              |   22 ++
target/alpha/translate.c       |   25 +-
target/arm/translate-a64.c     |  312 ++++++++++++-------------
target/arm/translate.c         |  503 ++++++++++++++++++++++------------------
target/arm/translate.h         |   38 ++-
target/cris/translate.c        |   26 +-
target/hppa/translate.c        |    6
target/i386/translate.c        |  353 +++++++++++++++-------------
target/lm32/translate.c        |   36 +--
target/m68k/translate.c        |   24 +-
target/microblaze/translate.c  |   28 +-
target/mips/translate.c        |   41 ++-
target/moxie/translate.c       |   16 +
target/nios2/translate.c       |    6
target/openrisc/translate.c    |   25 +-
target/ppc/translate.c         |   21 +-
target/ppc/translate_init.c    |   32 +--
target/s390x/translate.c       |   22 +-
target/sh4/translate.c         |   21 +-
target/sparc/translate.c       |   17 +
target/tilegx/translate.c      |    9 -
target/tricore/translate.c     |   11 -
target/unicore32/translate.c   |   26 +-
target/xtensa/translate.c      |   39 ++-
translate-all.c                |    2
translate-block.c              |  185 +++++++++++++++
31 files changed, 1212 insertions(+), 793 deletions(-)
create mode 100644 include/exec/translate-block.h
create mode 100644 translate-block.c
[Qemu-devel] [RFC PATCH v7 00/26] translate: [tcg] Generic translation framework
Posted by Lluís Vilanova 8 years, 4 months ago
This series proposes a generic (target-agnostic) instruction translation
framework.

It basically provides a generic main loop for instruction disassembly, which
calls target-specific functions when necessary. This generalization makes
inserting new code in the main loop easier, and helps in keeping all targets in
synch as to the contents of it.

This series also paves the way towards adding events to trace guest code
execution (BBLs and instructions).

I've ported i386/x86-64 and arm/aarch64 as an example to see how it fits in the
current organization, but will port the rest when this series gets merged.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---

Changes in v7
=============

* Change BreakpointHitType (BH_*) for BreakpointCheckType (BC_*).
* Move target-specific translation functions to a struct (TranslatorOps).
* Split target-specific changes into multiple patches.
* Rebase on edf8bc9842.


Changes in v6
=============

* Rebase on upstream master (64175afc69).
* Reorder fields in DisasContextBase to minimize padding [Richard Henderson].


Changes in v5
=============

* Remove stray uses of "restrict" keyword.


Changes in v4
=============

* Document new macro QTAILQ_FOREACH_CONTINUE [Peter Maydell].
* Fix coding style errors reported by checkpatch.
* Remove use of "restrict" in added functions; it makes older gcc versions barf
  about compilation errors.


Changes in v3
=============

* Rebase on 0737f32daf.


Changes in v2
=============

* Port ARM and AARCH64 targets.
* Fold single-stepping checks into "max_insns" [Richard Henderson].
* Move instruction start marks to target code [Richard Henderson].
* Add target hook for TB start.
* Check for TCG temporary leaks.
* Move instruction disassembly into a target hook.
* Make breakpoint_hit() return an enum to accomodate target's needs (ARM).


Lluís Vilanova (26):
      Pass generic CPUState to gen_intermediate_code()
      queue: Add macro for incremental traversal
      cpu-exec: Avoid global variables in icount-related functions
      target: [tcg] Add generic translation framework
      target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*)
      target: [tcg,i386] Port to DisasContextBase
      target: [tcg,i386] Refactor init_disas_context
      target: [tcg,i386] Refactor init_globals
      target: [tcg,i386] Refactor insn_start
      target: [tcg,i386] Refactor breakpoint_check
      target: [tcg,i386] Refactor disas_insn
      target: [tcg,i386] Refactor tb_stop
      target: [tcg,i386] Refactor disas_flags
      target: [tcg,i386] Replace DISAS_* with DJ_*
      target: [tcg,i386] Port to generic translation framework
      target: [tcg,arm] Replace DISAS_* with DJ_*
      target: [tcg,arm] Port to DisasContextBase
      target: [tcg,arm] Port to init_disas_context
      target: [tcg,arm] Port to init_globals
      target: [tcg,arm] Port to tb_start
      target: [tcg,arm] Port to insn_start
      target: [tcg,arm] Port to breakpoint_check
      target: [tcg,arm] Port to disas_insn
      target: [tcg,arm] Port to tb_stop
      target: [tcg,arm] Port to disas_flags
      target: [tcg,arm] Port to generic translation framework


 Makefile.target                |    1 
 include/exec/exec-all.h        |   13 +
 include/exec/gen-icount.h      |    8 -
 include/exec/translate-block.h |  125 ++++++++++
 include/qemu/queue.h           |   12 +
 include/qom/cpu.h              |   22 ++
 target/alpha/translate.c       |   25 +-
 target/arm/translate-a64.c     |  312 ++++++++++++-------------
 target/arm/translate.c         |  503 ++++++++++++++++++++++------------------
 target/arm/translate.h         |   38 ++-
 target/cris/translate.c        |   26 +-
 target/hppa/translate.c        |    6 
 target/i386/translate.c        |  353 +++++++++++++++-------------
 target/lm32/translate.c        |   36 +--
 target/m68k/translate.c        |   24 +-
 target/microblaze/translate.c  |   28 +-
 target/mips/translate.c        |   41 ++-
 target/moxie/translate.c       |   16 +
 target/nios2/translate.c       |    6 
 target/openrisc/translate.c    |   25 +-
 target/ppc/translate.c         |   21 +-
 target/ppc/translate_init.c    |   32 +--
 target/s390x/translate.c       |   22 +-
 target/sh4/translate.c         |   21 +-
 target/sparc/translate.c       |   17 +
 target/tilegx/translate.c      |    9 -
 target/tricore/translate.c     |   11 -
 target/unicore32/translate.c   |   26 +-
 target/xtensa/translate.c      |   39 ++-
 translate-all.c                |    2 
 translate-block.c              |  185 +++++++++++++++
 31 files changed, 1212 insertions(+), 793 deletions(-)
 create mode 100644 include/exec/translate-block.h
 create mode 100644 translate-block.c


To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Alex Bennée <alex.bennee@linaro.org>

Re: [Qemu-devel] [RFC PATCH v7 00/26] translate: [tcg] Generic translation framework
Posted by Lluís Vilanova 8 years, 4 months ago
Please ignore, I'm having problems with my mail server and there's patches being
dropeed.

Thanks,
  Lluis


Lluís Vilanova writes:

> This series proposes a generic (target-agnostic) instruction translation
> framework.

> It basically provides a generic main loop for instruction disassembly, which
> calls target-specific functions when necessary. This generalization makes
> inserting new code in the main loop easier, and helps in keeping all targets in
> synch as to the contents of it.

> This series also paves the way towards adding events to trace guest code
> execution (BBLs and instructions).

> I've ported i386/x86-64 and arm/aarch64 as an example to see how it fits in the
> current organization, but will port the rest when this series gets merged.

> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---

> Changes in v7
> =============

> * Change BreakpointHitType (BH_*) for BreakpointCheckType (BC_*).
> * Move target-specific translation functions to a struct (TranslatorOps).
> * Split target-specific changes into multiple patches.
> * Rebase on edf8bc9842.


> Changes in v6
> =============

> * Rebase on upstream master (64175afc69).
> * Reorder fields in DisasContextBase to minimize padding [Richard Henderson].


> Changes in v5
> =============

> * Remove stray uses of "restrict" keyword.


> Changes in v4
> =============

> * Document new macro QTAILQ_FOREACH_CONTINUE [Peter Maydell].
> * Fix coding style errors reported by checkpatch.
> * Remove use of "restrict" in added functions; it makes older gcc versions barf
>   about compilation errors.


> Changes in v3
> =============

> * Rebase on 0737f32daf.


> Changes in v2
> =============

> * Port ARM and AARCH64 targets.
> * Fold single-stepping checks into "max_insns" [Richard Henderson].
> * Move instruction start marks to target code [Richard Henderson].
> * Add target hook for TB start.
> * Check for TCG temporary leaks.
> * Move instruction disassembly into a target hook.
> * Make breakpoint_hit() return an enum to accomodate target's needs (ARM).


> Lluís Vilanova (26):
>       Pass generic CPUState to gen_intermediate_code()
>       queue: Add macro for incremental traversal
>       cpu-exec: Avoid global variables in icount-related functions
>       target: [tcg] Add generic translation framework
>       target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*)
>       target: [tcg,i386] Port to DisasContextBase
>       target: [tcg,i386] Refactor init_disas_context
>       target: [tcg,i386] Refactor init_globals
>       target: [tcg,i386] Refactor insn_start
>       target: [tcg,i386] Refactor breakpoint_check
>       target: [tcg,i386] Refactor disas_insn
>       target: [tcg,i386] Refactor tb_stop
>       target: [tcg,i386] Refactor disas_flags
>       target: [tcg,i386] Replace DISAS_* with DJ_*
>       target: [tcg,i386] Port to generic translation framework
>       target: [tcg,arm] Replace DISAS_* with DJ_*
>       target: [tcg,arm] Port to DisasContextBase
>       target: [tcg,arm] Port to init_disas_context
>       target: [tcg,arm] Port to init_globals
>       target: [tcg,arm] Port to tb_start
>       target: [tcg,arm] Port to insn_start
>       target: [tcg,arm] Port to breakpoint_check
>       target: [tcg,arm] Port to disas_insn
>       target: [tcg,arm] Port to tb_stop
>       target: [tcg,arm] Port to disas_flags
>       target: [tcg,arm] Port to generic translation framework


>  Makefile.target                |    1 
>  include/exec/exec-all.h        |   13 +
>  include/exec/gen-icount.h      |    8 -
>  include/exec/translate-block.h |  125 ++++++++++
>  include/qemu/queue.h           |   12 +
>  include/qom/cpu.h              |   22 ++
>  target/alpha/translate.c       |   25 +-
>  target/arm/translate-a64.c     |  312 ++++++++++++-------------
>  target/arm/translate.c         |  503 ++++++++++++++++++++++------------------
>  target/arm/translate.h         |   38 ++-
>  target/cris/translate.c        |   26 +-
>  target/hppa/translate.c        |    6 
>  target/i386/translate.c        |  353 +++++++++++++++-------------
>  target/lm32/translate.c        |   36 +--
>  target/m68k/translate.c        |   24 +-
>  target/microblaze/translate.c  |   28 +-
>  target/mips/translate.c        |   41 ++-
>  target/moxie/translate.c       |   16 +
>  target/nios2/translate.c       |    6 
>  target/openrisc/translate.c    |   25 +-
>  target/ppc/translate.c         |   21 +-
>  target/ppc/translate_init.c    |   32 +--
>  target/s390x/translate.c       |   22 +-
>  target/sh4/translate.c         |   21 +-
>  target/sparc/translate.c       |   17 +
>  target/tilegx/translate.c      |    9 -
>  target/tricore/translate.c     |   11 -
>  target/unicore32/translate.c   |   26 +-
>  target/xtensa/translate.c      |   39 ++-
>  translate-all.c                |    2 
>  translate-block.c              |  185 +++++++++++++++
>  31 files changed, 1212 insertions(+), 793 deletions(-)
>  create mode 100644 include/exec/translate-block.h
>  create mode 100644 translate-block.c


> To: qemu-devel@nongnu.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Alex Bennée <alex.bennee@linaro.org>