[Qemu-devel] [RFC PATCH v6 0/6] translate: [tcg] Generic translation framework

Lluís Vilanova posted 6 patches 8 years, 4 months ago
Only 5 patches received!
There is a newer version of this series
include/exec/exec-all.h               |   13 -
include/exec/gen-icount.h             |    2
include/exec/translate-all_template.h |   73 +++
include/qemu/queue.h                  |   12 +
include/qom/cpu.h                     |   22 +
target/alpha/translate.c              |   11 -
target/arm/translate-a64.c            |  346 ++++++++--------
target/arm/translate.c                |  720 +++++++++++++++++----------------
target/arm/translate.h                |   45 +-
target/cris/translate.c               |   20 -
target/i386/translate.c               |  305 ++++++--------
target/lm32/translate.c               |   22 +
target/m68k/translate.c               |   18 -
target/microblaze/translate.c         |   22 +
target/mips/translate.c               |   15 -
target/moxie/translate.c              |   14 -
target/openrisc/translate.c           |   19 -
target/ppc/translate.c                |   15 -
target/s390x/translate.c              |   16 -
target/sh4/translate.c                |   15 -
target/sparc/translate.c              |   11 -
target/tilegx/translate.c             |    7
target/tricore/translate.c            |    9
target/unicore32/translate.c          |   20 -
target/xtensa/translate.c             |   13 -
translate-all.c                       |    2
translate-all_template.h              |  204 +++++++++
27 files changed, 1141 insertions(+), 850 deletions(-)
create mode 100644 include/exec/translate-all_template.h
create mode 100644 translate-all_template.h
[Qemu-devel] [RFC PATCH v6 0/6] translate: [tcg] Generic translation framework
Posted by Lluís Vilanova 8 years, 4 months ago
This series proposes a generic (target-agnostic) instruction translation
framework.

It basically provides a generic main loop for instruction disassembly, which
calls target-specific functions when necessary. This generalization makes
inserting new code in the main loop easier, and helps in keeping all targets in
synch as to the contents of it.

This series also paves the way towards adding events to trace guest code
execution (BBLs and instructions).

I've ported i386/x86-64 and arm/aarch64 as an example to see how it fits in the
current organization, but will port the rest when this series gets merged.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---

Changes in v6
=============

* Rebase on upstream master (64175afc69).
* Reorder fields in DisasContextBase to minimize padding [Richard Henderson].


Changes in v5
=============

* Remove stray uses of "restrict" keyword.


Changes in v4
=============

* Document new macro QTAILQ_FOREACH_CONTINUE [Peter Maydell].
* Fix coding style errors reported by checkpatch.
* Remove use of "restrict" in added functions; it makes older gcc versions barf
  about compilation errors.


Changes in v3
=============

* Rebase on 0737f32daf.


Changes in v2
=============

* Port ARM and AARCH64 targets.
* Fold single-stepping checks into "max_insns" [Richard Henderson].
* Move instruction start marks to target code [Richard Henderson].
* Add target hook for TB start.
* Check for TCG temporary leaks.
* Move instruction disassembly into a target hook.
* Make breakpoint_hit() return an enum to accomodate target's needs (ARM).


Lluís Vilanova (6):
      Pass generic CPUState to gen_intermediate_code()
      queue: Add macro for incremental traversal
      target: [tcg] Add generic translation framework
      target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*)
      target: [tcg,i386] Port to generic translation framework
      target: [tcg,arm] Port to generic translation framework


 include/exec/exec-all.h               |   13 -
 include/exec/gen-icount.h             |    2 
 include/exec/translate-all_template.h |   73 +++
 include/qemu/queue.h                  |   12 +
 include/qom/cpu.h                     |   22 +
 target/alpha/translate.c              |   11 -
 target/arm/translate-a64.c            |  346 ++++++++--------
 target/arm/translate.c                |  720 +++++++++++++++++----------------
 target/arm/translate.h                |   45 +-
 target/cris/translate.c               |   20 -
 target/i386/translate.c               |  305 ++++++--------
 target/lm32/translate.c               |   22 +
 target/m68k/translate.c               |   18 -
 target/microblaze/translate.c         |   22 +
 target/mips/translate.c               |   15 -
 target/moxie/translate.c              |   14 -
 target/openrisc/translate.c           |   19 -
 target/ppc/translate.c                |   15 -
 target/s390x/translate.c              |   16 -
 target/sh4/translate.c                |   15 -
 target/sparc/translate.c              |   11 -
 target/tilegx/translate.c             |    7 
 target/tricore/translate.c            |    9 
 target/unicore32/translate.c          |   20 -
 target/xtensa/translate.c             |   13 -
 translate-all.c                       |    2 
 translate-all_template.h              |  204 +++++++++
 27 files changed, 1141 insertions(+), 850 deletions(-)
 create mode 100644 include/exec/translate-all_template.h
 create mode 100644 translate-all_template.h


To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Alex Bennée <alex.bennee@linaro.org>

Re: [Qemu-devel] [RFC PATCH v6 0/6] translate: [tcg] Generic translation framework
Posted by Emilio G. Cota 8 years, 4 months ago
On Mon, Jun 12, 2017 at 17:53:47 +0300, Lluís Vilanova wrote:
> This series proposes a generic (target-agnostic) instruction translation
> framework.
> 
> It basically provides a generic main loop for instruction disassembly, which
> calls target-specific functions when necessary. This generalization makes
> inserting new code in the main loop easier, and helps in keeping all targets in
> synch as to the contents of it.
> 
> This series also paves the way towards adding events to trace guest code
> execution (BBLs and instructions).
> 
> I've ported i386/x86-64 and arm/aarch64 as an example to see how it fits in the
> current organization, but will port the rest when this series gets merged.

It seems patch 5 didn't make it through the list (the list drops patches
sometimes):
  https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02833.html

I think I've found it in your qemu-dbi tree though (1c97cf92b06).
I pasted it here: https://pastebin.ca/3832616

		E.

Re: [Qemu-devel] [RFC PATCH v6 0/6] translate: [tcg] Generic translation framework
Posted by Lluís Vilanova 8 years, 4 months ago
Emilio G Cota writes:

> On Mon, Jun 12, 2017 at 17:53:47 +0300, Lluís Vilanova wrote:
>> This series proposes a generic (target-agnostic) instruction translation
>> framework.
>> 
>> It basically provides a generic main loop for instruction disassembly, which
>> calls target-specific functions when necessary. This generalization makes
>> inserting new code in the main loop easier, and helps in keeping all targets in
>> synch as to the contents of it.
>> 
>> This series also paves the way towards adding events to trace guest code
>> execution (BBLs and instructions).
>> 
>> I've ported i386/x86-64 and arm/aarch64 as an example to see how it fits in the
>> current organization, but will port the rest when this series gets merged.

> It seems patch 5 didn't make it through the list (the list drops patches
> sometimes):
>   https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02833.html

> I think I've found it in your qemu-dbi tree though (1c97cf92b06).
> I pasted it here: https://pastebin.ca/3832616

> 		E.

Yes, I realized that but was waiting to accumulate some changes before sending a
new series. Thanks! :)

Lluis