[v1] fw_cfg: qdev-related tidy-ups

[Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups

Posted by Mark Cave-Ayland 8 years, 4 months ago

As part of some ongoing sun4u work, I need to be able to wire the fw_cfg
IO interface to a separate IO space by instantiating the qdev device instead
of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with
FW_CFG_MEM and tidies up the realize methods accordingly.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Mark Cave-Ayland (6):
  fw_cfg: move initialisation of FWCfgState into instance_init
  fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers
  fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()
  fw_cfg: move fw_cfg_init1() into the fw_cfg_*_realize() functions
  fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize()
  fw_cfg: move QOM type defines into fw_cfg.h

 hw/nvram/fw_cfg.c         |   60 ++++++++++++++++++++++++---------------------
 include/hw/nvram/fw_cfg.h |    8 ++++++
 2 files changed, 40 insertions(+), 28 deletions(-)

-- 
1.7.10.4

Re: [Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups

Posted by Philippe Mathieu-Daudé 8 years, 4 months ago

Hi Mark,

Is it possible to reorder the 3rd patch (FW_CFG_ID) first or 2nd in the 
series? Mostly for cosmetic :)

On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote:
> As part of some ongoing sun4u work, I need to be able to wire the fw_cfg
> IO interface to a separate IO space by instantiating the qdev device instead
> of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with
> FW_CFG_MEM and tidies up the realize methods accordingly.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>
> Mark Cave-Ayland (6):
>   fw_cfg: move initialisation of FWCfgState into instance_init
>   fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers
>   fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()
>   fw_cfg: move fw_cfg_init1() into the fw_cfg_*_realize() functions
>   fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize()
>   fw_cfg: move QOM type defines into fw_cfg.h
>
>  hw/nvram/fw_cfg.c         |   60 ++++++++++++++++++++++++---------------------
>  include/hw/nvram/fw_cfg.h |    8 ++++++
>  2 files changed, 40 insertions(+), 28 deletions(-)
>

Re: [Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups

Posted by Mark Cave-Ayland 8 years, 4 months ago

On 10/06/17 19:15, Philippe Mathieu-Daudé wrote:

> Hi Mark,
> 
> Is it possible to reorder the 3rd patch (FW_CFG_ID) first or 2nd in the
> series? Mostly for cosmetic :)
> 
> On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote:
>> As part of some ongoing sun4u work, I need to be able to wire the fw_cfg
>> IO interface to a separate IO space by instantiating the qdev device
>> instead
>> of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with
>> FW_CFG_MEM and tidies up the realize methods accordingly.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>
>> Mark Cave-Ayland (6):
>>   fw_cfg: move initialisation of FWCfgState into instance_init
>>   fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers
>>   fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1()
>>   fw_cfg: move fw_cfg_init1() into the fw_cfg_*_realize() functions
>>   fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize()
>>   fw_cfg: move QOM type defines into fw_cfg.h
>>
>>  hw/nvram/fw_cfg.c         |   60
>> ++++++++++++++++++++++++---------------------
>>  include/hw/nvram/fw_cfg.h |    8 ++++++
>>  2 files changed, 40 insertions(+), 28 deletions(-)

I can't really get too excited about this - anyone else have any strong
opinions either way?


ATB,

Mark.