hw/cpu: core.c can be compiled as common object

[Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

Posted by Thomas Huth 8 years, 4 months ago

There does not seem to be any target specific code in core.c, so we can
put it into "common-obj" instead of "obj" to compile it only once for
all targets.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/cpu/Makefile.objs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/cpu/Makefile.objs b/hw/cpu/Makefile.objs
index 942a4bb..cd52d20 100644
--- a/hw/cpu/Makefile.objs
+++ b/hw/cpu/Makefile.objs
@@ -2,5 +2,4 @@ obj-$(CONFIG_ARM11MPCORE) += arm11mpcore.o
 obj-$(CONFIG_REALVIEW) += realview_mpcore.o
 obj-$(CONFIG_A9MPCORE) += a9mpcore.o
 obj-$(CONFIG_A15MPCORE) += a15mpcore.o
-obj-y += core.o
-
+common-obj-y += core.o
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

Posted by Juan Quintela 8 years, 4 months ago

Thomas Huth <thuth@redhat.com> wrote:
> There does not seem to be any target specific code in core.c, so we can
> put it into "common-obj" instead of "obj" to compile it only once for
> all targets.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

It compiles.
I can't see anything that is target dependent on core.c.

So

Reviewed-by: Juan Quintela <quintela@redhat.com>

Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

Posted by David Gibson 8 years, 4 months ago

On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote:
> Thomas Huth <thuth@redhat.com> wrote:
> > There does not seem to be any target specific code in core.c, so we can
> > put it into "common-obj" instead of "obj" to compile it only once for
> > all targets.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> It compiles.
> I can't see anything that is target dependent on core.c.
> 
> So
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>

I've merged this into my ppc-for-2.10 tree, on the basis that ppc is
the only user of core.c so far.  Any objections?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [Qemu-devel] [PATCH] hw/cpu: core.c can be compiled as common object

Posted by Eduardo Habkost 8 years, 4 months ago

On Fri, Jun 09, 2017 at 12:03:38PM +1000, David Gibson wrote:
> On Thu, Jun 08, 2017 at 04:23:34PM +0200, Juan Quintela wrote:
> > Thomas Huth <thuth@redhat.com> wrote:
> > > There does not seem to be any target specific code in core.c, so we can
> > > put it into "common-obj" instead of "obj" to compile it only once for
> > > all targets.
> > >
> > > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > 
> > It compiles.
> > I can't see anything that is target dependent on core.c.
> > 
> > So
> > 
> > Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> I've merged this into my ppc-for-2.10 tree, on the basis that ppc is
> the only user of core.c so far.  Any objections?

No problem to me.  If you want, you can add my:

Acked-by: Eduardo Habkost <ehabkost@redhat.com>

-- 
Eduardo