target/xtensa: gdbstub: drop dead return statement

[Qemu-devel] [PATCH] target/xtensa: gdbstub: drop dead return statement

Max Filippov posted 1 patch 8 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1496864204-5954-1-git-send-email-jcmvbkbc@gmail.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

target/xtensa/gdbstub.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] target/xtensa: gdbstub: drop dead return statement

Posted by Max Filippov 8 years, 8 months ago

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 target/xtensa/gdbstub.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/xtensa/gdbstub.c b/target/xtensa/gdbstub.c
index da131ae..d78a1b4 100644
--- a/target/xtensa/gdbstub.c
+++ b/target/xtensa/gdbstub.c
@@ -72,7 +72,6 @@ int xtensa_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)
                       __func__, n, reg->type);
         memset(mem_buf, 0, reg->size);
         return reg->size;
-        return 0;
     }
 }
 
-- 
2.1.4

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target/xtensa: gdbstub: drop dead return statement

Posted by Laurent Vivier 8 years, 8 months ago

On 07/06/2017 21:36, Max Filippov wrote:
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  target/xtensa/gdbstub.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/xtensa/gdbstub.c b/target/xtensa/gdbstub.c
> index da131ae..d78a1b4 100644
> --- a/target/xtensa/gdbstub.c
> +++ b/target/xtensa/gdbstub.c
> @@ -72,7 +72,6 @@ int xtensa_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)
>                        __func__, n, reg->type);
>          memset(mem_buf, 0, reg->size);
>          return reg->size;
> -        return 0;
>      }
>  }
>  
> 
Reviewed-by: Laurent Vivier <lvivier@redhat.com>