qemu-img: supplement the omitted 'disk size' bytes info

[Qemu-devel] [PATCH] qemu-img: supplement the omitted 'disk size' bytes info

sochin.jiang posted 1 patch 8 years, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1496732599-7977-1-git-send-email-sochin.jiang@huawei.com

Test FreeBSD passed

Test checkpatch passed

Test docker passed

Test s390x passed

block/qapi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] qemu-img: supplement the omitted 'disk size' bytes info

Posted by sochin.jiang 8 years, 5 months ago

From: "sochin.jiang" <sochin.jiang@huawei.com>

 Supplement the omitted 'disk size' bytes information when using

 'qemu-img info',it is useful in some occasion. Anyhow, it looks

 strange that 'virtual size' has bytes while actual 'disk size'

 does not.

Signed-off-by: sochin.jiang <sochin.jiang@huawei.com>
---
 block/qapi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/qapi.c b/block/qapi.c
index a40922e..9bb5956 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -703,10 +703,11 @@ void bdrv_image_info_dump(fprintf_function func_fprintf, void *f,
                  "image: %s\n"
                  "file format: %s\n"
                  "virtual size: %s (%" PRId64 " bytes)\n"
-                 "disk size: %s\n",
+                 "disk size: %s (%" PRId64 " bytes)\n",
                  info->filename, info->format, size_buf,
                  info->virtual_size,
-                 dsize_buf);
+                 dsize_buf,
+                 info->actual_size);
 
     if (info->has_encrypted && info->encrypted) {
         func_fprintf(f, "encrypted: yes\n");
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] qemu-img: supplement the omitted 'disk size' bytes info

Posted by sochin.jiang 8 years, 5 months ago

Please ignore this patch, I realize that there are some unfixed problems,
like iotest, etc.

On 2017/6/6 15:03, sochin.jiang wrote:
> From: "sochin.jiang" <sochin.jiang@huawei.com>
>
>  Supplement the omitted 'disk size' bytes information when using
>
>  'qemu-img info',it is useful in some occasion. Anyhow, it looks
>
>  strange that 'virtual size' has bytes while actual 'disk size'
>
>  does not.
>
> Signed-off-by: sochin.jiang <sochin.jiang@huawei.com>
> ---
>  block/qapi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index a40922e..9bb5956 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -703,10 +703,11 @@ void bdrv_image_info_dump(fprintf_function func_fprintf, void *f,
>                   "image: %s\n"
>                   "file format: %s\n"
>                   "virtual size: %s (%" PRId64 " bytes)\n"
> -                 "disk size: %s\n",
> +                 "disk size: %s (%" PRId64 " bytes)\n",
>                   info->filename, info->format, size_buf,
>                   info->virtual_size,
> -                 dsize_buf);
> +                 dsize_buf,
> +                 info->actual_size);
>  
>      if (info->has_encrypted && info->encrypted) {
>          func_fprintf(f, "encrypted: yes\n");