hw/core: nmi.c can be compiled as common-obj nowadays

[Qemu-devel] [PATCH] hw/core: nmi.c can be compiled as common-obj nowadays

Thomas Huth posted 1 patch 6 years, 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1496310843-28771-1-git-send-email-thuth@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

hw/core/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw/core: nmi.c can be compiled as common-obj nowadays

Posted by Thomas Huth 6 years, 10 months ago

The target-specific code in nmi.c has been removed with this commit:

	commit f7e981f29548fe4af7812f5920304fe607e5bf0d
	nmi: remove x86 specific nmi handling

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/core/Makefile.objs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
index 91450b2..f8d7a4a 100644
--- a/hw/core/Makefile.objs
+++ b/hw/core/Makefile.objs
@@ -5,7 +5,7 @@ common-obj-y += fw-path-provider.o
 # irq.o needed for qdev GPIO handling:
 common-obj-y += irq.o
 common-obj-y += hotplug.o
-obj-y += nmi.o
+common-obj-y += nmi.o
 
 common-obj-$(CONFIG_EMPTY_SLOT) += empty_slot.o
 common-obj-$(CONFIG_XILINX_AXI) += stream.o
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] hw/core: nmi.c can be compiled as common-obj nowadays

Posted by Juan Quintela 6 years, 10 months ago

Thomas Huth <thuth@redhat.com> wrote:
> The target-specific code in nmi.c has been removed with this commit:
>
> 	commit f7e981f29548fe4af7812f5920304fe607e5bf0d
> 	nmi: remove x86 specific nmi handling
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>