The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab:

Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100)

for you to fetch changes up to 82342e91b60a4a078811df4e1a545e57abffa11d:

e1000e: Fix ICR "Other" causes clear logic (2017-05-23 10:10:38 +0800)

Sameeh Jubran (1):

e1000e: Fix ICR "Other" causes clear logic

Thomas Huth (3):

net/tap: Replace tap-haiku.c and tap-aix.c by a generic tap-stub.c

net/dump: Issue a warning for the deprecated "-net dump"

hmp / net: Mark host_net_add/remove as deprecated

Yunjian Wang (1):

virtio-net: fix wild pointer when remove virtio-net queues

Zhang Chen (4):

COLO-compare: Improve tcp compare trace event readability

net/filter-mirror.c: Remove duplicate check code.

net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle

net/filter-rewriter: Remove unused option in filter-rewriter

hmp-commands.hx | 8 ++--

hw/net/e1000e_core.c | 10 ++++-

hw/net/virtio-net.c | 3 ++

net/Makefile.objs | 15 ++++----

net/colo-compare.c | 33 ++++++++++------

net/dump.c | 3 ++

net/filter-mirror.c | 35 ++++++++---------

net/net.c | 13 +++++++

net/tap-haiku.c | 87 -------------------------------------------

net/{tap-aix.c => tap-stub.c} | 3 +-

net/trace-events | 3 +-

qemu-options.hx | 2 +-

12 files changed, 80 insertions(+), 135 deletions(-)

delete mode 100644 net/tap-haiku.c

rename net/{tap-aix.c => tap-stub.c} (97%)

From: Sameeh Jubran <sameeh@daynix.com>

This commit fixes a bug which causes the guest to hang. The bug was

observed upon a "receive overrun" (bit #6 of the ICR register)

interrupt which could be triggered post migration in a heavy traffic

environment. Even though the "receive overrun" bit (#6) is masked out

by the IMS register (refer to the log below) the driver still receives

an interrupt as the "receive overrun" bit (#6) causes the "Other" -

bit #24 of the ICR register - bit to be set as documented below. The

driver handles the interrupt and clears the "Other" bit (#24) but

doesn't clear the "receive overrun" bit (#6) which leads to an

infinite loop. Apparently the Windows driver expects that the "receive

overrun" bit and other ones - documented below - to be cleared when

the "Other" bit (#24) is cleared.

So to sum that up:

1. Bit #6 of the ICR register is set by heavy traffic

2. As a results of setting bit #6, bit #24 is set

3. The driver receives an interrupt for bit 24 (it doesn't receieve an

interrupt for bit #6 as it is masked out by IMS)

4. The driver handles and clears the interrupt of bit #24

5. Bit #6 is still set.

6. 2 happens all over again

The Interrupt Cause Read - ICR register:

The ICR has the "Other" bit - bit #24 - that is set when one or more

of the following ICR register's bits are set:

LSC - bit #2, RXO - bit #6, MDAC - bit #9, SRPD - bit #16, ACK - bit

#17, MNG - bit #18

This bug can occur with any of these bits depending on the driver's

behaviour and the way it configures the device. However, trying to

reproduce it with any bit other than RX0 is challenging and came to

failure as the drivers don't implement most of these bits, trying to

reproduce it with LSC (Link Status Change - bit #2) bit didn't succeed

too as it seems that Windows handles this bit differently.

Log sample of the storm:

27563@1494850819.411877:e1000e_irq_pending_interrupts ICR PENDING: 0x1000000 (ICR: 0x815000c2, IMS: 0x1a00004)

27563@1494850819.411900:e1000e_irq_pending_interrupts ICR PENDING: 0x0 (ICR: 0x815000c2, IMS: 0xa00004)

27563@1494850819.411915:e1000e_irq_pending_interrupts ICR PENDING: 0x0 (ICR: 0x815000c2, IMS: 0xa00004)

27563@1494850819.412380:e1000e_irq_pending_interrupts ICR PENDING: 0x0 (ICR: 0x815000c2, IMS: 0xa00004)

27563@1494850819.412395:e1000e_irq_pending_interrupts ICR PENDING: 0x0 (ICR: 0x815000c2, IMS: 0xa00004)

27563@1494850819.412436:e1000e_irq_pending_interrupts ICR PENDING: 0x0 (ICR: 0x815000c2, IMS: 0xa00004)

27563@1494850819.412441:e1000e_irq_pending_interrupts ICR PENDING: 0x0 (ICR: 0x815000c2, IMS: 0xa00004)

27563@1494850819.412998:e1000e_irq_pending_interrupts ICR PENDING: 0x1000000 (ICR: 0x815000c2, IMS: 0x1a00004)

* This bug behaviour wasn't observed with the Linux driver.

This commit solves:

https://bugzilla.redhat.com/show_bug.cgi?id=1447935

https://bugzilla.redhat.com/show_bug.cgi?id=1449490

Cc: qemu-stable@nongnu.org

Signed-off-by: Sameeh Jubran <sjubran@redhat.com>

hw/net/e1000e_core.c | 10 ++++++++--

1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c

--- a/hw/net/e1000e_core.c

+++ b/hw/net/e1000e_core.c

@@ -XXX,XX +XXX,XX @@ e1000e_set_ics(E1000ECore *core, int index, uint32_t val)

static void

e1000e_set_icr(E1000ECore *core, int index, uint32_t val)

{

+ uint32_t icr = 0;

if ((core->mac[ICR] & E1000_ICR_ASSERTED) &&

(core->mac[CTRL_EXT] & E1000_CTRL_EXT_IAME)) {

trace_e1000e_irq_icr_process_iame();

e1000e_clear_ims_bits(core, core->mac[IAM]);

- trace_e1000e_irq_icr_write(val, core->mac[ICR], core->mac[ICR] & ~val);

- core->mac[ICR] &= ~val;

+ icr = core->mac[ICR] & ~val;

+ /* Windows driver expects that the "receive overrun" bit and other

+ * ones to be cleared when the "Other" bit (#24) is cleared.

+ */

+ icr = (val & E1000_ICR_OTHER) ? (icr & ~E1000_ICR_OTHER_CAUSES) : icr;

+ trace_e1000e_irq_icr_write(val, core->mac[ICR], icr);

+ core->mac[ICR] = icr;

e1000e_update_interrupt_state(core);

From: Thomas Huth <thuth@redhat.com>

The netdev_add and netdev_del commands should be used nowadays instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>

hmp-commands.hx | 8 ++++----

net/net.c | 13 +++++++++++++

2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx

--- a/hmp-commands.hx

+++ b/hmp-commands.hx

@@ -XXX,XX +XXX,XX @@ ETEXI

.name = "host_net_add",

.args_type = "device:s,opts:s?",

.params = "tap|user|socket|vde|netmap|bridge|vhost-user|dump [options]",

- .help = "add host VLAN client",

+ .help = "add host VLAN client (deprecated, use netdev_add instead)",

.cmd = hmp_host_net_add,

.command_completion = host_net_add_completion,

},

@@ -XXX,XX +XXX,XX @@ ETEXI

STEXI

@item host_net_add

@findex host_net_add

-Add host VLAN client.

+Add host VLAN client. Deprecated, please use @code{netdev_add} instead.

ETEXI

{

.name = "host_net_remove",

.args_type = "vlan_id:i,device:s",

.params = "vlan_id name",

- .help = "remove host VLAN client",

+ .help = "remove host VLAN client (deprecated, use netdev_del instead)",

.cmd = hmp_host_net_remove,

.command_completion = host_net_remove_completion,

},

@@ -XXX,XX +XXX,XX @@ ETEXI

STEXI

@item host_net_remove

@findex host_net_remove

-Remove host VLAN client.

+Remove host VLAN client. Deprecated, please use @code{netdev_del} instead.

ETEXI

{

@@ -XXX,XX +XXX,XX @@

#include "qapi-visit.h"

#include "qapi/opts-visitor.h"

#include "sysemu/sysemu.h"

+#include "sysemu/qtest.h"

#include "net/filter.h"

#include "qapi/string-output-visitor.h"

@@ -XXX,XX +XXX,XX @@ void hmp_host_net_add(Monitor *mon, const QDict *qdict)

const char *opts_str = qdict_get_try_str(qdict, "opts");

Error *local_err = NULL;

QemuOpts *opts;

+ static bool warned;

+

+ if (!warned && !qtest_enabled()) {

+ error_report("host_net_add is deprecated, use netdev_add instead");

+ warned = true;

+ }

if (!net_host_check_device(device)) {

monitor_printf(mon, "invalid host network device %s\n", device);

@@ -XXX,XX +XXX,XX @@ void hmp_host_net_remove(Monitor *mon, const QDict *qdict)

NetClientState *nc;

int vlan_id = qdict_get_int(qdict, "vlan_id");

const char *device = qdict_get_str(qdict, "device");

+ static bool warned;

+

+ if (!warned && !qtest_enabled()) {

+ error_report("host_net_remove is deprecated, use netdev_del instead");

+ warned = true;

+ }

nc = net_hub_find_client_by_name(vlan_id, device);

if (!nc) {

Because filter_mirror_receive_iov() and filter_redirector_receive_iov()

both use the filter_mirror_send() to send packet, so I change

filter_mirror_send() to filter_send() that looks more common.

And fix some codestyle.

net/filter-mirror.c | 29 ++++++++++++++++-------------

1 file changed, 16 insertions(+), 13 deletions(-)

-static int filter_mirror_send(CharBackend *chr_out,

- const struct iovec *iov,

- int iovcnt)

+static int filter_send(CharBackend *chr_out,

+ const struct iovec *iov,

+ int iovcnt)

int ret = 0;

ssize_t size = 0;

- ret = filter_mirror_send(&s->chr_out, iov, iovcnt);

+ ret = filter_send(&s->chr_out, iov, iovcnt);

- error_report("filter_mirror_send failed(%s)", strerror(-ret));

+ error_report("filter mirror send failed(%s)", strerror(-ret));

if (qemu_chr_fe_get_driver(&s->chr_out)) {

- ret = filter_mirror_send(&s->chr_out, iov, iovcnt);

+ ret = filter_send(&s->chr_out, iov, iovcnt);

- error_report("filter_mirror_send failed(%s)", strerror(-ret));

+ error_report("filter redirector send failed(%s)", strerror(-ret));

The s->outdev have checked in filter_mirror_set_outdev().

net/filter-mirror.c | 6 ------

1 file changed, 6 deletions(-)

@@ -XXX,XX +XXX,XX @@ static void filter_mirror_setup(NetFilterState *nf, Error **errp)

MirrorState *s = FILTER_MIRROR(nf);

Chardev *chr;

- if (!s->outdev) {

- error_setg(errp, "filter mirror needs 'outdev' "

- "property set");

- return;

- }

-

chr = qemu_chr_find(s->outdev);

if (chr == NULL) {

error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,

Because of previous patch's trace arguments over the limit

of UST backend, so I rewrite the patch.

net/colo-compare.c | 33 ++++++++++++++++++++++-----------

net/trace-events | 3 +--

2 files changed, 23 insertions(+), 13 deletions(-)

@@ -XXX,XX +XXX,XX @@ static int colo_packet_compare_tcp(Packet *spkt, Packet *ppkt)

if (res != 0 && trace_event_get_state(TRACE_COLO_COMPARE_MISCOMPARE)) {

- trace_colo_compare_pkt_info_src(inet_ntoa(ppkt->ip->ip_src),

- ntohl(stcp->th_seq),

- ntohl(stcp->th_ack),

- res, stcp->th_flags,

- spkt->size);

-

- trace_colo_compare_pkt_info_dst(inet_ntoa(ppkt->ip->ip_dst),

- ntohl(ptcp->th_seq),

- ntohl(ptcp->th_ack),

- res, ptcp->th_flags,

- ppkt->size);

+ char pri_ip_src[20], pri_ip_dst[20], sec_ip_src[20], sec_ip_dst[20];

+

+ strcpy(pri_ip_src, inet_ntoa(ppkt->ip->ip_src));

+ strcpy(pri_ip_dst, inet_ntoa(ppkt->ip->ip_dst));

+ strcpy(sec_ip_src, inet_ntoa(spkt->ip->ip_src));

+ strcpy(sec_ip_dst, inet_ntoa(spkt->ip->ip_dst));

+

+ trace_colo_compare_ip_info(ppkt->size, pri_ip_src,

+ pri_ip_dst, spkt->size,

+ sec_ip_src, sec_ip_dst);

+

+ trace_colo_compare_tcp_info("pri tcp packet",

+ ntohl(ptcp->th_seq),

+ ntohl(ptcp->th_ack),

+ res, ptcp->th_flags,

+ ppkt->size);

+

+ trace_colo_compare_tcp_info("sec tcp packet",

+ ntohl(stcp->th_seq),

+ ntohl(stcp->th_ack),

+ res, stcp->th_flags,

+ spkt->size);

qemu_hexdump((char *)ppkt->data, stderr,

"colo-compare ppkt", ppkt->size);

diff --git a/net/trace-events b/net/trace-events

--- a/net/trace-events

+++ b/net/trace-events

@@ -XXX,XX +XXX,XX @@ colo_compare_icmp_miscompare(const char *sta, int size) ": %s = %d"

colo_compare_ip_info(int psize, const char *sta, const char *stb, int ssize, const char *stc, const char *std) "ppkt size = %d, ip_src = %s, ip_dst = %s, spkt size = %d, ip_src = %s, ip_dst = %s"

colo_old_packet_check_found(int64_t old_time) "%" PRId64

colo_compare_miscompare(void) ""

-colo_compare_pkt_info_src(const char *src, uint32_t sseq, uint32_t sack, int res, uint32_t sflag, int ssize) "src/dst: %s s: seq/ack=%u/%u res=%d flags=%x spkt_size: %d\n"

-colo_compare_pkt_info_dst(const char *dst, uint32_t dseq, uint32_t dack, int res, uint32_t dflag, int dsize) "src/dst: %s d: seq/ack=%u/%u res=%d flags=%x dpkt_size: %d\n"

+colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int res, uint32_t flag, int size) "side: %s seq/ack= %u/%u res= %d flags= %x pkt_size: %d\n"

# net/filter-rewriter.c

colo_filter_rewriter_debug(void) ""

From: Thomas Huth <thuth@redhat.com>

The files tap-haiku.c and tap-aix.c are identical (except one line

of error message). We should avoid such code duplication, so replace

these by a generic tap-stub.c file instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

net/Makefile.objs | 15 +++++-----

net/tap-aix.c | 88 -------------------------------------------------------

net/tap-haiku.c | 87 ------------------------------------------------------

net/tap-stub.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++++

4 files changed, 95 insertions(+), 182 deletions(-)

delete mode 100644 net/tap-aix.c

delete mode 100644 net/tap-haiku.c

create mode 100644 net/tap-stub.c

diff --git a/net/Makefile.objs b/net/Makefile.objs

--- a/net/Makefile.objs

+++ b/net/Makefile.objs

@@ -XXX,XX +XXX,XX @@ common-obj-y += socket.o

common-obj-y += dump.o

common-obj-y += eth.o

common-obj-$(CONFIG_L2TPV3) += l2tpv3.o

-common-obj-$(CONFIG_POSIX) += tap.o vhost-user.o

-common-obj-$(CONFIG_LINUX) += tap-linux.o

-common-obj-$(CONFIG_WIN32) += tap-win32.o

-common-obj-$(CONFIG_BSD) += tap-bsd.o

-common-obj-$(CONFIG_SOLARIS) += tap-solaris.o

-common-obj-$(CONFIG_AIX) += tap-aix.o

-common-obj-$(CONFIG_HAIKU) += tap-haiku.o

+common-obj-$(CONFIG_POSIX) += vhost-user.o

common-obj-$(CONFIG_SLIRP) += slirp.o

common-obj-$(CONFIG_VDE) += vde.o

common-obj-$(CONFIG_NETMAP) += netmap.o

@@ -XXX,XX +XXX,XX @@ common-obj-y += colo-compare.o

common-obj-y += colo.o

common-obj-y += filter-rewriter.o

common-obj-y += filter-replay.o

+tap-obj-$(CONFIG_LINUX) = tap-linux.o

+tap-obj-$(CONFIG_BSD) = tap-bsd.o

+tap-obj-$(CONFIG_SOLARIS) = tap-solaris.o

+tap-obj-y ?= tap-stub.o

+common-obj-$(CONFIG_POSIX) += tap.o $(tap-obj-y)

+common-obj-$(CONFIG_WIN32) += tap-win32.o

diff --git a/net/tap-aix.c b/net/tap-aix.c

deleted file mode 100644

index XXXXXXX..XXXXXXX

--- a/net/tap-aix.c

+++ /dev/null

@@ -XXX,XX +XXX,XX @@

-/*

- * QEMU System Emulator

- *

- * Copyright (c) 2003-2008 Fabrice Bellard

- *

- * Permission is hereby granted, free of charge, to any person obtaining a copy

- * of this software and associated documentation files (the "Software"), to deal

- * in the Software without restriction, including without limitation the rights

- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell

- * copies of the Software, and to permit persons to whom the Software is

- * furnished to do so, subject to the following conditions:

- *

- * The above copyright notice and this permission notice shall be included in

- * all copies or substantial portions of the Software.

- *

- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,

- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL

- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER

- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,

- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN

- * THE SOFTWARE.

- */

-

-#include "qemu/osdep.h"

-#include "qapi/error.h"

-#include "tap_int.h"

-

-int tap_open(char *ifname, int ifname_size, int *vnet_hdr,

- int vnet_hdr_required, int mq_required, Error **errp)

-{

- error_setg(errp, "no tap on AIX");

- return -1;

-}

-

-void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)

-{

-}

-

-int tap_probe_vnet_hdr(int fd)

-{

- return 0;

-}

-

-int tap_probe_has_ufo(int fd)

-{

- return 0;

-}

-

-int tap_probe_vnet_hdr_len(int fd, int len)

-{

- return 0;

-}

-

-void tap_fd_set_vnet_hdr_len(int fd, int len)

-{

-}

-

-int tap_fd_set_vnet_le(int fd, int is_le)

-{

- return -EINVAL;

-}

-

-int tap_fd_set_vnet_be(int fd, int is_be)

-{

- return -EINVAL;

-}

-

-void tap_fd_set_offload(int fd, int csum, int tso4,

- int tso6, int ecn, int ufo)

-{

-}

-

-int tap_fd_enable(int fd)

-{

- return -1;

-}

-

-int tap_fd_disable(int fd)

-{

- return -1;

-}

-

-int tap_fd_get_ifname(int fd, char *ifname)

-{

- return -1;

-}

-

diff --git a/net/tap-haiku.c b/net/tap-haiku.c

deleted file mode 100644

index XXXXXXX..XXXXXXX

--- a/net/tap-haiku.c

+++ /dev/null

@@ -XXX,XX +XXX,XX @@

-/*

- * QEMU System Emulator

- *

- * Copyright (c) 2003-2008 Fabrice Bellard

- *

- * Permission is hereby granted, free of charge, to any person obtaining a copy

- * of this software and associated documentation files (the "Software"), to deal

- * in the Software without restriction, including without limitation the rights

- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell

- * copies of the Software, and to permit persons to whom the Software is

- * furnished to do so, subject to the following conditions:

- *

- * The above copyright notice and this permission notice shall be included in

- * all copies or substantial portions of the Software.

- *

- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,

- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL

- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER

- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,

- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN

- * THE SOFTWARE.

- */

-

-#include "qemu/osdep.h"

-#include "qapi/error.h"

-#include "tap_int.h"

-

-int tap_open(char *ifname, int ifname_size, int *vnet_hdr,

- int vnet_hdr_required, int mq_required, Error **errp)

-{

- error_setg(errp, "no tap on Haiku");

- return -1;

-}

-

-void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)

-{

-}

-

-int tap_probe_vnet_hdr(int fd)

-{

- return 0;

-}

-

-int tap_probe_has_ufo(int fd)

-{

- return 0;

-}

-

-int tap_probe_vnet_hdr_len(int fd, int len)

-{

- return 0;

-}

-

-void tap_fd_set_vnet_hdr_len(int fd, int len)

-{

-}

-

-int tap_fd_set_vnet_le(int fd, int is_le)

-{

- return -EINVAL;

-}

-

-int tap_fd_set_vnet_be(int fd, int is_be)

-{

- return -EINVAL;

-}

-

-void tap_fd_set_offload(int fd, int csum, int tso4,

- int tso6, int ecn, int ufo)

-{

-}

-

-int tap_fd_enable(int fd)

-{

- return -1;

-}

-

-int tap_fd_disable(int fd)

-{

- return -1;

-}

-

-int tap_fd_get_ifname(int fd, char *ifname)

-{

- return -1;

-}

diff --git a/net/tap-stub.c b/net/tap-stub.c

new file mode 100644

index XXXXXXX..XXXXXXX

--- /dev/null

+++ b/net/tap-stub.c

@@ -XXX,XX +XXX,XX @@

+/*

+ * QEMU System Emulator

+ *

+ * Copyright (c) 2003-2008 Fabrice Bellard

+ *

+ * Permission is hereby granted, free of charge, to any person obtaining a copy

+ * of this software and associated documentation files (the "Software"), to deal

+ * in the Software without restriction, including without limitation the rights

+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell

+ * copies of the Software, and to permit persons to whom the Software is

+ * furnished to do so, subject to the following conditions:

+ *

+ * The above copyright notice and this permission notice shall be included in

+ * all copies or substantial portions of the Software.

+ *

+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,

+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL

+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER

+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,

+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN

+ * THE SOFTWARE.

+ */

+#include "qemu/osdep.h"

+#include "qapi/error.h"

+#include "tap_int.h"

+

+int tap_open(char *ifname, int ifname_size, int *vnet_hdr,

+ int vnet_hdr_required, int mq_required, Error **errp)

+{

+ error_setg(errp, "tap is not supported in this build");

+ return -1;

+void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)

+int tap_probe_vnet_hdr(int fd)

+{

+ return 0;

+}

+int tap_probe_has_ufo(int fd)

+{

+ return 0;

+}