.gitignore | 1 + Makefile | 3 + Makefile.objs | 4 + block/nbd-client.c | 11 +- contrib/vhost-user-scsi/Makefile.objs | 1 + contrib/vhost-user-scsi/vhost-user-scsi.c | 886 ++++++++++++++++++++++++++++++ default-configs/pci.mak | 1 + default-configs/s390x-softmmu.mak | 1 + exec.c | 13 +- hw/pci/msix.c | 11 +- hw/pci/trace-events | 3 + hw/scsi/Makefile.objs | 1 + hw/scsi/vhost-user-scsi.c | 215 ++++++++ hw/scsi/virtio-scsi.c | 3 + hw/timer/mc146818rtc.c | 206 ++++--- hw/virtio/virtio-pci.c | 54 ++ hw/virtio/virtio-pci.h | 11 + include/block/nbd.h | 8 +- include/hw/virtio/vhost-user-scsi.h | 35 ++ include/hw/virtio/virtio-scsi.h | 3 + kvm-all.c | 4 +- nbd/client.c | 125 ++--- nbd/common.c | 23 +- nbd/nbd-internal.h | 40 +- nbd/server.c | 92 ++-- qemu-nbd.c | 3 +- target/i386/arch_memory_mapping.c | 18 +- target/i386/cpu.c | 15 +- target/i386/cpu.h | 20 +- target/i386/helper.c | 96 ++-- target/i386/kvm.c | 12 +- target/i386/machine.c | 4 - target/i386/smm_helper.c | 18 - trace-events | 3 +- util/oslib-posix.c | 4 +- 35 files changed, 1642 insertions(+), 306 deletions(-) create mode 100644 contrib/vhost-user-scsi/Makefile.objs create mode 100644 contrib/vhost-user-scsi/vhost-user-scsi.c create mode 100644 hw/scsi/vhost-user-scsi.c create mode 100644 include/hw/virtio/vhost-user-scsi.h
The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to e10dc0ca6854c4f47cc5e9d47e20c62aa875f518: target/i386: use multiple CPU AddressSpaces (2017-05-19 13:01:32 +0200) ---------------------------------------------------------------- * virtio-scsi use-after-free fix (Fam) * vhost-user-scsi support (Felipe) * SMM fixes and improvements for TCG (myself) * irqchip and AddressSpaceDispatch cleanups and fixes (Peter) * Coverity fix (Stefano) * NBD cleanups (Vladimir) * RTC accuracy improvements and code cleanups (Guangrong+Yunfang) ---------------------------------------------------------------- Fam Zheng (1): virtio-scsi: Unset hotplug handler when unrealize Felipe Franciosi (2): vhost-user-scsi: Introduce vhost-user-scsi host device vhost-user-scsi: Introduce a vhost-user-scsi sample application Paolo Bonzini (2): target/i386: enable A20 automatically in system management mode target/i386: use multiple CPU AddressSpaces Peter Xu (4): kvm: irqchip: trace changes on msi add/remove msix: trace control bit write op kvm: irqchip: skip update msi when disabled exec: simplify phys_page_find() params Stefano Stabellini (1): Check the return value of fcntl in qemu_set_cloexec Tai Yunfang (1): mc146818rtc: precisely count the clock for periodic timer Vladimir Sementsov-Ogievskiy (5): nbd: strict nbd_wr_syncv nbd: read_sync and friends: return 0 on success nbd: add errp parameter to nbd_wr_syncv() nbd: add errp to read_sync, write_sync and drop_sync nbd/client.c: use errp instead of LOG Xiao Guangrong (4): mc146818rtc: update periodic timer only if it is needed mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386 mc146818rtc: drop unnecessary '#ifdef TARGET_I386' mc146818rtc: embrace all x86 specific code .gitignore | 1 + Makefile | 3 + Makefile.objs | 4 + block/nbd-client.c | 11 +- contrib/vhost-user-scsi/Makefile.objs | 1 + contrib/vhost-user-scsi/vhost-user-scsi.c | 886 ++++++++++++++++++++++++++++++ default-configs/pci.mak | 1 + default-configs/s390x-softmmu.mak | 1 + exec.c | 13 +- hw/pci/msix.c | 11 +- hw/pci/trace-events | 3 + hw/scsi/Makefile.objs | 1 + hw/scsi/vhost-user-scsi.c | 215 ++++++++ hw/scsi/virtio-scsi.c | 3 + hw/timer/mc146818rtc.c | 206 ++++--- hw/virtio/virtio-pci.c | 54 ++ hw/virtio/virtio-pci.h | 11 + include/block/nbd.h | 8 +- include/hw/virtio/vhost-user-scsi.h | 35 ++ include/hw/virtio/virtio-scsi.h | 3 + kvm-all.c | 4 +- nbd/client.c | 125 ++--- nbd/common.c | 23 +- nbd/nbd-internal.h | 40 +- nbd/server.c | 92 ++-- qemu-nbd.c | 3 +- target/i386/arch_memory_mapping.c | 18 +- target/i386/cpu.c | 15 +- target/i386/cpu.h | 20 +- target/i386/helper.c | 96 ++-- target/i386/kvm.c | 12 +- target/i386/machine.c | 4 - target/i386/smm_helper.c | 18 - trace-events | 3 +- util/oslib-posix.c | 4 +- 35 files changed, 1642 insertions(+), 306 deletions(-) create mode 100644 contrib/vhost-user-scsi/Makefile.objs create mode 100644 contrib/vhost-user-scsi/vhost-user-scsi.c create mode 100644 hw/scsi/vhost-user-scsi.c create mode 100644 include/hw/virtio/vhost-user-scsi.h -- 1.8.3.1
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1495192872-27667-1-git-send-email-pbonzini@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 6fce4cd target/i386: use multiple CPU AddressSpaces a04ba9d target/i386: enable A20 automatically in system management mode 87c38d5 vhost-user-scsi: Introduce a vhost-user-scsi sample application a63728e vhost-user-scsi: Introduce vhost-user-scsi host device bda4194 virtio-scsi: Unset hotplug handler when unrealize ca14443 exec: simplify phys_page_find() params 7eee4fd nbd/client.c: use errp instead of LOG 388beda nbd: add errp to read_sync, write_sync and drop_sync 0032273 nbd: add errp parameter to nbd_wr_syncv() bdf25c9 nbd: read_sync and friends: return 0 on success b61d7d1 nbd: strict nbd_wr_syncv cc100d3 Check the return value of fcntl in qemu_set_cloexec 94297c6 kvm: irqchip: skip update msi when disabled f8f04f1 msix: trace control bit write op 11bfe30 kvm: irqchip: trace changes on msi add/remove 192c432 mc146818rtc: embrace all x86 specific code 6e1b003 mc146818rtc: drop unnecessary '#ifdef TARGET_I386' cb9a45b mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386 98a508b mc146818rtc: precisely count the clock for periodic timer b9744f3 mc146818rtc: update periodic timer only if it is needed === OUTPUT BEGIN === Checking PATCH 1/20: mc146818rtc: update periodic timer only if it is needed... Checking PATCH 2/20: mc146818rtc: precisely count the clock for periodic timer... ERROR: braces {} are necessary for all arms of this statement #129: FILE: hw/timer/mc146818rtc.c:216: + if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) { [...] + } else [...] total: 1 errors, 0 warnings, 181 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/20: mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386... Checking PATCH 4/20: mc146818rtc: drop unnecessary '#ifdef TARGET_I386'... Checking PATCH 5/20: mc146818rtc: embrace all x86 specific code... Checking PATCH 6/20: kvm: irqchip: trace changes on msi add/remove... Checking PATCH 7/20: msix: trace control bit write op... Checking PATCH 8/20: kvm: irqchip: skip update msi when disabled... Checking PATCH 9/20: Check the return value of fcntl in qemu_set_cloexec... Checking PATCH 10/20: nbd: strict nbd_wr_syncv... Checking PATCH 11/20: nbd: read_sync and friends: return 0 on success... Checking PATCH 12/20: nbd: add errp parameter to nbd_wr_syncv()... Checking PATCH 13/20: nbd: add errp to read_sync, write_sync and drop_sync... Checking PATCH 14/20: nbd/client.c: use errp instead of LOG... ERROR: code indent should never use tabs #126: FILE: nbd/client.c:729: +^I Error **errp)$ total: 1 errors, 0 warnings, 146 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 15/20: exec: simplify phys_page_find() params... Checking PATCH 16/20: virtio-scsi: Unset hotplug handler when unrealize... Checking PATCH 17/20: vhost-user-scsi: Introduce vhost-user-scsi host device... ERROR: do not use C99 // comments #216: FILE: hw/scsi/vhost-user-scsi.c:145: + // Turn on predefined features supported by this device ERROR: do not use C99 // comments #261: FILE: hw/scsi/vhost-user-scsi.c:190: + // Add the bootindex property for this object ERROR: do not use C99 // comments #265: FILE: hw/scsi/vhost-user-scsi.c:194: + // Set boot index according the the device config total: 3 errors, 0 warnings, 382 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 18/20: vhost-user-scsi: Introduce a vhost-user-scsi sample application... ERROR: do not use C99 // comments #109: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:28: +//#define VUS_DEBUG 1 ERROR: spaces required around that '/' (ctx:VxV) #123: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:42: + timebuf, ts.tv_nsec/1000, \ ^ ERROR: __func__ should be used instead of gcc specific __FUNCTION__ #124: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:43: + __FILE__, __FUNCTION__, __LINE__, ## __VA_ARGS__); \ ERROR: space required before the open parenthesis '(' #125: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:44: +} while(0) ERROR: spaces required around that '/' (ctx:VxV) #130: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:49: + timebuf, ts.tv_nsec/1000, ## __VA_ARGS__); \ ^ ERROR: space required before the open parenthesis '(' #131: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:50: +} while(0); ERROR: do not use C99 // comments #145: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:64: +#define VUS_MAX_LUNS 1 // Only 1 lun supported today ERROR: do not use C99 // comments #146: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:65: +#define VUS_MAX_DEVS 1 // Only 1 devices supported today ERROR: do not use C99 // comments #159: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:78: + GTree *fdmap; // maps fd to gsource context id ERROR: trailing statements should be on next line #176: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:95: + if (b > a) return 1; ERROR: braces {} are necessary for all arms of this statement #176: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:95: + if (b > a) return 1; [...] ERROR: trailing statements should be on next line #177: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:96: + if (b < a) return -1; ERROR: braces {} are necessary for all arms of this statement #177: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:96: + if (b < a) return -1; [...] ERROR: trailing statements should be on next line #213: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:132: + if (vus_src->gfd.events & G_IO_IN) vu_evt |= VU_WATCH_IN; ERROR: braces {} are necessary for all arms of this statement #213: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:132: + if (vus_src->gfd.events & G_IO_IN) vu_evt |= VU_WATCH_IN; [...] ERROR: trailing statements should be on next line #214: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:133: + if (vus_src->gfd.events & G_IO_OUT) vu_evt |= VU_WATCH_OUT; ERROR: braces {} are necessary for all arms of this statement #214: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:133: + if (vus_src->gfd.events & G_IO_OUT) vu_evt |= VU_WATCH_OUT; [...] ERROR: trailing statements should be on next line #215: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:134: + if (vus_src->gfd.events & G_IO_PRI) vu_evt |= VU_WATCH_PRI; ERROR: braces {} are necessary for all arms of this statement #215: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:134: + if (vus_src->gfd.events & G_IO_PRI) vu_evt |= VU_WATCH_PRI; [...] ERROR: trailing statements should be on next line #216: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:135: + if (vus_src->gfd.events & G_IO_ERR) vu_evt |= VU_WATCH_ERR; ERROR: braces {} are necessary for all arms of this statement #216: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:135: + if (vus_src->gfd.events & G_IO_ERR) vu_evt |= VU_WATCH_ERR; [...] ERROR: trailing statements should be on next line #217: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:136: + if (vus_src->gfd.events & G_IO_HUP) vu_evt |= VU_WATCH_HUP; ERROR: braces {} are necessary for all arms of this statement #217: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:136: + if (vus_src->gfd.events & G_IO_HUP) vu_evt |= VU_WATCH_HUP; [...] ERROR: use QEMU instead of Qemu or QEmu #277: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:196: + * Qemu's scsi.h also defines "SCSI_XFER_NONE". ERROR: open brace '{' following function declarations go on the next line #358: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:277: +static int iscsi_add_lun(iscsi_lun_t *lun, char *iscsi_uri) { ERROR: open brace '{' following function declarations go on the next line #423: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:342: +static int get_cdb_len(uint8_t *cdb) { ERROR: spaces required around that '>>' (ctx:VxV) #433: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:352: + PERR("Unable to determine cdb len (0x%02hhX)", cdb[0]>>5); ^ ERROR: do not use C99 // comments #453: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:372: + // Ignore anything different than target=0, lun=0 ERROR: spaces required around that '=' (ctx:VxV) #477: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:396: + for (i=0; i<out_len; i++) { ^ ERROR: spaces required around that '<' (ctx:VxV) #477: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:396: + for (i=0; i<out_len; i++) { ^ ERROR: spaces required around that '=' (ctx:VxV) #482: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:401: + for (i=0; i<in_len; i++) { ^ ERROR: spaces required around that '<' (ctx:VxV) #482: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:401: + for (i=0; i<in_len; i++) { ^ ERROR: open brace '{' following function declarations go on the next line #532: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:451: +static void vus_panic_cb(VuDev *vu_dev, const char *buf) { ERROR: trailing statements should be on next line #574: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:493: + if (vu_evt & VU_WATCH_IN) conds |= G_IO_IN; ERROR: braces {} are necessary for all arms of this statement #574: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:493: + if (vu_evt & VU_WATCH_IN) conds |= G_IO_IN; [...] ERROR: trailing statements should be on next line #575: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:494: + if (vu_evt & VU_WATCH_OUT) conds |= G_IO_OUT; ERROR: braces {} are necessary for all arms of this statement #575: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:494: + if (vu_evt & VU_WATCH_OUT) conds |= G_IO_OUT; [...] ERROR: trailing statements should be on next line #576: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:495: + if (vu_evt & VU_WATCH_PRI) conds |= G_IO_PRI; ERROR: braces {} are necessary for all arms of this statement #576: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:495: + if (vu_evt & VU_WATCH_PRI) conds |= G_IO_PRI; [...] ERROR: trailing statements should be on next line #577: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:496: + if (vu_evt & VU_WATCH_ERR) conds |= G_IO_ERR; ERROR: braces {} are necessary for all arms of this statement #577: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:496: + if (vu_evt & VU_WATCH_ERR) conds |= G_IO_ERR; [...] ERROR: trailing statements should be on next line #578: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:497: + if (vu_evt & VU_WATCH_HUP) conds |= G_IO_HUP; ERROR: braces {} are necessary for all arms of this statement #578: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:497: + if (vu_evt & VU_WATCH_HUP) conds |= G_IO_HUP; [...] ERROR: open brace '{' following function declarations go on the next line #585: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:504: +static void vus_del_watch_cb(VuDev *vu_dev, int fd) { ERROR: open brace '{' following function declarations go on the next line #608: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:527: +static void vus_proc_ctl(VuDev *vu_dev, int idx) { ERROR: open brace '{' following function declarations go on the next line #612: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:531: +static void vus_proc_evt(VuDev *vu_dev, int idx) { ERROR: open brace '{' following function declarations go on the next line #616: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:535: +static void vus_proc_req(VuDev *vu_dev, int idx) { ERROR: space required before the open parenthesis '(' #643: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:562: + while(1) { ERROR: spaces required around that '-' (ctx:VxV) #673: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:592: + req, &elem->out_sg[1], elem->out_num-1, ^ ERROR: spaces required around that '-' (ctx:VxV) #674: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:593: + rsp, &elem->in_sg[1], elem->in_num-1) != 0) { ^ ERROR: open brace '{' following function declarations go on the next line #686: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:605: +static void vus_queue_set_started(VuDev *vu_dev, int idx, bool started) { ERROR: space required before the open parenthesis '(' #699: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:618: + switch(idx) { ERROR: spaces required around that '?' (ctx:VxV) #701: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:620: + vu_set_queue_handler(vu_dev, vq, started?vus_proc_ctl:NULL); ^ ERROR: spaces required around that ':' (ctx:VxV) #701: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:620: + vu_set_queue_handler(vu_dev, vq, started?vus_proc_ctl:NULL); ^ ERROR: spaces required around that '?' (ctx:VxV) #704: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:623: + vu_set_queue_handler(vu_dev, vq, started?vus_proc_evt:NULL); ^ ERROR: spaces required around that ':' (ctx:VxV) #704: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:623: + vu_set_queue_handler(vu_dev, vq, started?vus_proc_evt:NULL); ^ ERROR: spaces required around that '?' (ctx:VxV) #707: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:626: + vu_set_queue_handler(vu_dev, vq, started?vus_proc_req:NULL); ^ ERROR: spaces required around that ':' (ctx:VxV) #707: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:626: + vu_set_queue_handler(vu_dev, vq, started?vus_proc_req:NULL); ^ ERROR: open brace '{' following function declarations go on the next line #715: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:634: +static gboolean vus_vhost_cb(gpointer data) { ERROR: open brace '{' following function declarations go on the next line #731: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:650: +static int unix_sock_new(char *unix_fn) { ERROR: open brace '{' following function declarations go on the next line #769: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:688: +static vhost_scsi_dev_t *vdev_scsi_find_by_vu(VuDev *vu_dev) { ERROR: spaces required around that '=' (ctx:VxV) #774: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:693: + for (i=0; i<VUS_MAX_DEVS; i++) { ^ ERROR: spaces required around that '<' (ctx:VxV) #774: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:693: + for (i=0; i<VUS_MAX_DEVS; i++) { ^ ERROR: open brace '{' following function declarations go on the next line #784: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:703: +static void vdev_scsi_deinit(vhost_scsi_dev_t *vdev_scsi) { ERROR: open brace '{' following function declarations go on the next line #809: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:728: +static vhost_scsi_dev_t *vdev_scsi_new(char *unix_fn) { ERROR: open brace '{' following function declarations go on the next line #864: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:783: +static int vdev_scsi_run(vhost_scsi_dev_t *vdev_scsi) { total: 66 errors, 0 warnings, 912 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 19/20: target/i386: enable A20 automatically in system management mode... Checking PATCH 20/20: target/i386: use multiple CPU AddressSpaces... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On Fri, May 19, 2017 at 05:41:28AM -0700, no-reply@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: Yikes, on second thought I've dropped the pull request for now. Please look at these coding style violations. Thanks, Stefan > > Message-id: 1495192872-27667-1-git-send-email-pbonzini@redhat.com > Type: series > Subject: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19 > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 6fce4cd target/i386: use multiple CPU AddressSpaces > a04ba9d target/i386: enable A20 automatically in system management mode > 87c38d5 vhost-user-scsi: Introduce a vhost-user-scsi sample application > a63728e vhost-user-scsi: Introduce vhost-user-scsi host device > bda4194 virtio-scsi: Unset hotplug handler when unrealize > ca14443 exec: simplify phys_page_find() params > 7eee4fd nbd/client.c: use errp instead of LOG > 388beda nbd: add errp to read_sync, write_sync and drop_sync > 0032273 nbd: add errp parameter to nbd_wr_syncv() > bdf25c9 nbd: read_sync and friends: return 0 on success > b61d7d1 nbd: strict nbd_wr_syncv > cc100d3 Check the return value of fcntl in qemu_set_cloexec > 94297c6 kvm: irqchip: skip update msi when disabled > f8f04f1 msix: trace control bit write op > 11bfe30 kvm: irqchip: trace changes on msi add/remove > 192c432 mc146818rtc: embrace all x86 specific code > 6e1b003 mc146818rtc: drop unnecessary '#ifdef TARGET_I386' > cb9a45b mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386 > 98a508b mc146818rtc: precisely count the clock for periodic timer > b9744f3 mc146818rtc: update periodic timer only if it is needed > > === OUTPUT BEGIN === > Checking PATCH 1/20: mc146818rtc: update periodic timer only if it is needed... > Checking PATCH 2/20: mc146818rtc: precisely count the clock for periodic timer... > ERROR: braces {} are necessary for all arms of this statement > #129: FILE: hw/timer/mc146818rtc.c:216: > + if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) { > [...] > + } else > [...] > > total: 1 errors, 0 warnings, 181 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 3/20: mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386... > Checking PATCH 4/20: mc146818rtc: drop unnecessary '#ifdef TARGET_I386'... > Checking PATCH 5/20: mc146818rtc: embrace all x86 specific code... > Checking PATCH 6/20: kvm: irqchip: trace changes on msi add/remove... > Checking PATCH 7/20: msix: trace control bit write op... > Checking PATCH 8/20: kvm: irqchip: skip update msi when disabled... > Checking PATCH 9/20: Check the return value of fcntl in qemu_set_cloexec... > Checking PATCH 10/20: nbd: strict nbd_wr_syncv... > Checking PATCH 11/20: nbd: read_sync and friends: return 0 on success... > Checking PATCH 12/20: nbd: add errp parameter to nbd_wr_syncv()... > Checking PATCH 13/20: nbd: add errp to read_sync, write_sync and drop_sync... > Checking PATCH 14/20: nbd/client.c: use errp instead of LOG... > ERROR: code indent should never use tabs > #126: FILE: nbd/client.c:729: > +^I Error **errp)$ > > total: 1 errors, 0 warnings, 146 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 15/20: exec: simplify phys_page_find() params... > Checking PATCH 16/20: virtio-scsi: Unset hotplug handler when unrealize... > Checking PATCH 17/20: vhost-user-scsi: Introduce vhost-user-scsi host device... > ERROR: do not use C99 // comments > #216: FILE: hw/scsi/vhost-user-scsi.c:145: > + // Turn on predefined features supported by this device > > ERROR: do not use C99 // comments > #261: FILE: hw/scsi/vhost-user-scsi.c:190: > + // Add the bootindex property for this object > > ERROR: do not use C99 // comments > #265: FILE: hw/scsi/vhost-user-scsi.c:194: > + // Set boot index according the the device config > > total: 3 errors, 0 warnings, 382 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 18/20: vhost-user-scsi: Introduce a vhost-user-scsi sample application... > ERROR: do not use C99 // comments > #109: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:28: > +//#define VUS_DEBUG 1 > > ERROR: spaces required around that '/' (ctx:VxV) > #123: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:42: > + timebuf, ts.tv_nsec/1000, \ > ^ > > ERROR: __func__ should be used instead of gcc specific __FUNCTION__ > #124: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:43: > + __FILE__, __FUNCTION__, __LINE__, ## __VA_ARGS__); \ > > ERROR: space required before the open parenthesis '(' > #125: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:44: > +} while(0) > > ERROR: spaces required around that '/' (ctx:VxV) > #130: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:49: > + timebuf, ts.tv_nsec/1000, ## __VA_ARGS__); \ > ^ > > ERROR: space required before the open parenthesis '(' > #131: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:50: > +} while(0); > > ERROR: do not use C99 // comments > #145: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:64: > +#define VUS_MAX_LUNS 1 // Only 1 lun supported today > > ERROR: do not use C99 // comments > #146: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:65: > +#define VUS_MAX_DEVS 1 // Only 1 devices supported today > > ERROR: do not use C99 // comments > #159: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:78: > + GTree *fdmap; // maps fd to gsource context id > > ERROR: trailing statements should be on next line > #176: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:95: > + if (b > a) return 1; > > ERROR: braces {} are necessary for all arms of this statement > #176: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:95: > + if (b > a) return 1; > [...] > > ERROR: trailing statements should be on next line > #177: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:96: > + if (b < a) return -1; > > ERROR: braces {} are necessary for all arms of this statement > #177: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:96: > + if (b < a) return -1; > [...] > > ERROR: trailing statements should be on next line > #213: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:132: > + if (vus_src->gfd.events & G_IO_IN) vu_evt |= VU_WATCH_IN; > > ERROR: braces {} are necessary for all arms of this statement > #213: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:132: > + if (vus_src->gfd.events & G_IO_IN) vu_evt |= VU_WATCH_IN; > [...] > > ERROR: trailing statements should be on next line > #214: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:133: > + if (vus_src->gfd.events & G_IO_OUT) vu_evt |= VU_WATCH_OUT; > > ERROR: braces {} are necessary for all arms of this statement > #214: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:133: > + if (vus_src->gfd.events & G_IO_OUT) vu_evt |= VU_WATCH_OUT; > [...] > > ERROR: trailing statements should be on next line > #215: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:134: > + if (vus_src->gfd.events & G_IO_PRI) vu_evt |= VU_WATCH_PRI; > > ERROR: braces {} are necessary for all arms of this statement > #215: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:134: > + if (vus_src->gfd.events & G_IO_PRI) vu_evt |= VU_WATCH_PRI; > [...] > > ERROR: trailing statements should be on next line > #216: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:135: > + if (vus_src->gfd.events & G_IO_ERR) vu_evt |= VU_WATCH_ERR; > > ERROR: braces {} are necessary for all arms of this statement > #216: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:135: > + if (vus_src->gfd.events & G_IO_ERR) vu_evt |= VU_WATCH_ERR; > [...] > > ERROR: trailing statements should be on next line > #217: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:136: > + if (vus_src->gfd.events & G_IO_HUP) vu_evt |= VU_WATCH_HUP; > > ERROR: braces {} are necessary for all arms of this statement > #217: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:136: > + if (vus_src->gfd.events & G_IO_HUP) vu_evt |= VU_WATCH_HUP; > [...] > > ERROR: use QEMU instead of Qemu or QEmu > #277: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:196: > + * Qemu's scsi.h also defines "SCSI_XFER_NONE". > > ERROR: open brace '{' following function declarations go on the next line > #358: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:277: > +static int iscsi_add_lun(iscsi_lun_t *lun, char *iscsi_uri) { > > ERROR: open brace '{' following function declarations go on the next line > #423: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:342: > +static int get_cdb_len(uint8_t *cdb) { > > ERROR: spaces required around that '>>' (ctx:VxV) > #433: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:352: > + PERR("Unable to determine cdb len (0x%02hhX)", cdb[0]>>5); > ^ > > ERROR: do not use C99 // comments > #453: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:372: > + // Ignore anything different than target=0, lun=0 > > ERROR: spaces required around that '=' (ctx:VxV) > #477: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:396: > + for (i=0; i<out_len; i++) { > ^ > > ERROR: spaces required around that '<' (ctx:VxV) > #477: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:396: > + for (i=0; i<out_len; i++) { > ^ > > ERROR: spaces required around that '=' (ctx:VxV) > #482: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:401: > + for (i=0; i<in_len; i++) { > ^ > > ERROR: spaces required around that '<' (ctx:VxV) > #482: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:401: > + for (i=0; i<in_len; i++) { > ^ > > ERROR: open brace '{' following function declarations go on the next line > #532: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:451: > +static void vus_panic_cb(VuDev *vu_dev, const char *buf) { > > ERROR: trailing statements should be on next line > #574: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:493: > + if (vu_evt & VU_WATCH_IN) conds |= G_IO_IN; > > ERROR: braces {} are necessary for all arms of this statement > #574: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:493: > + if (vu_evt & VU_WATCH_IN) conds |= G_IO_IN; > [...] > > ERROR: trailing statements should be on next line > #575: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:494: > + if (vu_evt & VU_WATCH_OUT) conds |= G_IO_OUT; > > ERROR: braces {} are necessary for all arms of this statement > #575: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:494: > + if (vu_evt & VU_WATCH_OUT) conds |= G_IO_OUT; > [...] > > ERROR: trailing statements should be on next line > #576: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:495: > + if (vu_evt & VU_WATCH_PRI) conds |= G_IO_PRI; > > ERROR: braces {} are necessary for all arms of this statement > #576: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:495: > + if (vu_evt & VU_WATCH_PRI) conds |= G_IO_PRI; > [...] > > ERROR: trailing statements should be on next line > #577: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:496: > + if (vu_evt & VU_WATCH_ERR) conds |= G_IO_ERR; > > ERROR: braces {} are necessary for all arms of this statement > #577: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:496: > + if (vu_evt & VU_WATCH_ERR) conds |= G_IO_ERR; > [...] > > ERROR: trailing statements should be on next line > #578: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:497: > + if (vu_evt & VU_WATCH_HUP) conds |= G_IO_HUP; > > ERROR: braces {} are necessary for all arms of this statement > #578: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:497: > + if (vu_evt & VU_WATCH_HUP) conds |= G_IO_HUP; > [...] > > ERROR: open brace '{' following function declarations go on the next line > #585: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:504: > +static void vus_del_watch_cb(VuDev *vu_dev, int fd) { > > ERROR: open brace '{' following function declarations go on the next line > #608: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:527: > +static void vus_proc_ctl(VuDev *vu_dev, int idx) { > > ERROR: open brace '{' following function declarations go on the next line > #612: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:531: > +static void vus_proc_evt(VuDev *vu_dev, int idx) { > > ERROR: open brace '{' following function declarations go on the next line > #616: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:535: > +static void vus_proc_req(VuDev *vu_dev, int idx) { > > ERROR: space required before the open parenthesis '(' > #643: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:562: > + while(1) { > > ERROR: spaces required around that '-' (ctx:VxV) > #673: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:592: > + req, &elem->out_sg[1], elem->out_num-1, > ^ > > ERROR: spaces required around that '-' (ctx:VxV) > #674: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:593: > + rsp, &elem->in_sg[1], elem->in_num-1) != 0) { > ^ > > ERROR: open brace '{' following function declarations go on the next line > #686: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:605: > +static void vus_queue_set_started(VuDev *vu_dev, int idx, bool started) { > > ERROR: space required before the open parenthesis '(' > #699: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:618: > + switch(idx) { > > ERROR: spaces required around that '?' (ctx:VxV) > #701: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:620: > + vu_set_queue_handler(vu_dev, vq, started?vus_proc_ctl:NULL); > ^ > > ERROR: spaces required around that ':' (ctx:VxV) > #701: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:620: > + vu_set_queue_handler(vu_dev, vq, started?vus_proc_ctl:NULL); > ^ > > ERROR: spaces required around that '?' (ctx:VxV) > #704: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:623: > + vu_set_queue_handler(vu_dev, vq, started?vus_proc_evt:NULL); > ^ > > ERROR: spaces required around that ':' (ctx:VxV) > #704: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:623: > + vu_set_queue_handler(vu_dev, vq, started?vus_proc_evt:NULL); > ^ > > ERROR: spaces required around that '?' (ctx:VxV) > #707: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:626: > + vu_set_queue_handler(vu_dev, vq, started?vus_proc_req:NULL); > ^ > > ERROR: spaces required around that ':' (ctx:VxV) > #707: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:626: > + vu_set_queue_handler(vu_dev, vq, started?vus_proc_req:NULL); > ^ > > ERROR: open brace '{' following function declarations go on the next line > #715: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:634: > +static gboolean vus_vhost_cb(gpointer data) { > > ERROR: open brace '{' following function declarations go on the next line > #731: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:650: > +static int unix_sock_new(char *unix_fn) { > > ERROR: open brace '{' following function declarations go on the next line > #769: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:688: > +static vhost_scsi_dev_t *vdev_scsi_find_by_vu(VuDev *vu_dev) { > > ERROR: spaces required around that '=' (ctx:VxV) > #774: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:693: > + for (i=0; i<VUS_MAX_DEVS; i++) { > ^ > > ERROR: spaces required around that '<' (ctx:VxV) > #774: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:693: > + for (i=0; i<VUS_MAX_DEVS; i++) { > ^ > > ERROR: open brace '{' following function declarations go on the next line > #784: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:703: > +static void vdev_scsi_deinit(vhost_scsi_dev_t *vdev_scsi) { > > ERROR: open brace '{' following function declarations go on the next line > #809: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:728: > +static vhost_scsi_dev_t *vdev_scsi_new(char *unix_fn) { > > ERROR: open brace '{' following function declarations go on the next line > #864: FILE: contrib/vhost-user-scsi/vhost-user-scsi.c:783: > +static int vdev_scsi_run(vhost_scsi_dev_t *vdev_scsi) { > > total: 66 errors, 0 warnings, 912 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 19/20: target/i386: enable A20 automatically in system management mode... > Checking PATCH 20/20: target/i386: use multiple CPU AddressSpaces... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org
On 19/05/2017 17:51, Stefan Hajnoczi wrote: >> This series seems to have some coding style problems. See output below for >> more information: > Yikes, on second thought I've dropped the pull request for now. > > Please look at these coding style violations. These are just a sample program, so I didn't really care much. But these three aren't: Checking PATCH 17/20: vhost-user-scsi: Introduce vhost-user-scsi host device... ERROR: do not use C99 // comments #216: FILE: hw/scsi/vhost-user-scsi.c:145: + // Turn on predefined features supported by this device ERROR: do not use C99 // comments #261: FILE: hw/scsi/vhost-user-scsi.c:190: + // Add the bootindex property for this object ERROR: do not use C99 // comments #265: FILE: hw/scsi/vhost-user-scsi.c:194: + // Set boot index according the the device config total: 3 errors, 0 warnings, 382 lines checked so I guess I'll fix the sample program too. Paolo
On Fri, May 19, 2017 at 01:20:52PM +0200, Paolo Bonzini wrote: > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) > > are available in the git repository at: > > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to e10dc0ca6854c4f47cc5e9d47e20c62aa875f518: > > target/i386: use multiple CPU AddressSpaces (2017-05-19 13:01:32 +0200) > > ---------------------------------------------------------------- > * virtio-scsi use-after-free fix (Fam) > * vhost-user-scsi support (Felipe) > * SMM fixes and improvements for TCG (myself) > * irqchip and AddressSpaceDispatch cleanups and fixes (Peter) > * Coverity fix (Stefano) > * NBD cleanups (Vladimir) > * RTC accuracy improvements and code cleanups (Guangrong+Yunfang) > > ---------------------------------------------------------------- > Fam Zheng (1): > virtio-scsi: Unset hotplug handler when unrealize > > Felipe Franciosi (2): > vhost-user-scsi: Introduce vhost-user-scsi host device > vhost-user-scsi: Introduce a vhost-user-scsi sample application > > Paolo Bonzini (2): > target/i386: enable A20 automatically in system management mode > target/i386: use multiple CPU AddressSpaces > > Peter Xu (4): > kvm: irqchip: trace changes on msi add/remove > msix: trace control bit write op > kvm: irqchip: skip update msi when disabled > exec: simplify phys_page_find() params > > Stefano Stabellini (1): > Check the return value of fcntl in qemu_set_cloexec > > Tai Yunfang (1): > mc146818rtc: precisely count the clock for periodic timer > > Vladimir Sementsov-Ogievskiy (5): > nbd: strict nbd_wr_syncv > nbd: read_sync and friends: return 0 on success > nbd: add errp parameter to nbd_wr_syncv() > nbd: add errp to read_sync, write_sync and drop_sync > nbd/client.c: use errp instead of LOG > > Xiao Guangrong (4): > mc146818rtc: update periodic timer only if it is needed > mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386 > mc146818rtc: drop unnecessary '#ifdef TARGET_I386' > mc146818rtc: embrace all x86 specific code > > .gitignore | 1 + > Makefile | 3 + > Makefile.objs | 4 + > block/nbd-client.c | 11 +- > contrib/vhost-user-scsi/Makefile.objs | 1 + > contrib/vhost-user-scsi/vhost-user-scsi.c | 886 ++++++++++++++++++++++++++++++ > default-configs/pci.mak | 1 + > default-configs/s390x-softmmu.mak | 1 + > exec.c | 13 +- > hw/pci/msix.c | 11 +- > hw/pci/trace-events | 3 + > hw/scsi/Makefile.objs | 1 + > hw/scsi/vhost-user-scsi.c | 215 ++++++++ > hw/scsi/virtio-scsi.c | 3 + > hw/timer/mc146818rtc.c | 206 ++++--- > hw/virtio/virtio-pci.c | 54 ++ > hw/virtio/virtio-pci.h | 11 + > include/block/nbd.h | 8 +- > include/hw/virtio/vhost-user-scsi.h | 35 ++ > include/hw/virtio/virtio-scsi.h | 3 + > kvm-all.c | 4 +- > nbd/client.c | 125 ++--- > nbd/common.c | 23 +- > nbd/nbd-internal.h | 40 +- > nbd/server.c | 92 ++-- > qemu-nbd.c | 3 +- > target/i386/arch_memory_mapping.c | 18 +- > target/i386/cpu.c | 15 +- > target/i386/cpu.h | 20 +- > target/i386/helper.c | 96 ++-- > target/i386/kvm.c | 12 +- > target/i386/machine.c | 4 - > target/i386/smm_helper.c | 18 - > trace-events | 3 +- > util/oslib-posix.c | 4 +- > 35 files changed, 1642 insertions(+), 306 deletions(-) > create mode 100644 contrib/vhost-user-scsi/Makefile.objs > create mode 100644 contrib/vhost-user-scsi/vhost-user-scsi.c > create mode 100644 hw/scsi/vhost-user-scsi.c > create mode 100644 include/hw/virtio/vhost-user-scsi.h > -- > 1.8.3.1 > > Thanks, applied to my staging tree: https://github.com/stefanha/qemu/commits/staging Stefan
© 2016 - 2024 Red Hat, Inc.