usb: Deprecate HMP commands usb_add and usb_del

[Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

Posted by Thomas Huth 6 years, 11 months ago

The commands 'device_add' and 'device_del' should be used
nowadays instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hmp-commands.hx | 6 ++++--
 vl.c            | 6 ++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index baeac47..e763606 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -676,7 +676,8 @@ ETEXI
 STEXI
 @item usb_add @var{devname}
 @findex usb_add
-Add the USB device @var{devname}.  For details of available devices see
+Add the USB device @var{devname}. This command is deprecated, please
+use @code{device_add} instead. For details of available devices see
 @ref{usb_devices}
 ETEXI
 
@@ -693,7 +694,8 @@ STEXI
 @findex usb_del
 Remove the USB device @var{devname} from the QEMU virtual USB
 hub. @var{devname} has the syntax @code{bus.addr}. Use the monitor
-command @code{info usb} to see the devices you can remove.
+command @code{info usb} to see the devices you can remove. This
+command is deprecated, please use @code{device_del} instead.
 ETEXI
 
     {
diff --git a/vl.c b/vl.c
index 3ca6bd3..268a8d8 100644
--- a/vl.c
+++ b/vl.c
@@ -1435,6 +1435,9 @@ static int usb_parse(const char *cmdline)
 void hmp_usb_add(Monitor *mon, const QDict *qdict)
 {
     const char *devname = qdict_get_str(qdict, "devname");
+
+    error_report("usb_add is deprecated, please use device_add instead");
+
     if (usb_device_add(devname) < 0) {
         error_report("could not add USB device '%s'", devname);
     }
@@ -1443,6 +1446,9 @@ void hmp_usb_add(Monitor *mon, const QDict *qdict)
 void hmp_usb_del(Monitor *mon, const QDict *qdict)
 {
     const char *devname = qdict_get_str(qdict, "devname");
+
+    error_report("usb_del is deprecated, please use device_del instead");
+
     if (usb_device_del(devname) < 0) {
         error_report("could not delete USB device '%s'", devname);
     }
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

Posted by Paolo Bonzini 6 years, 11 months ago


On 19/05/2017 08:36, Thomas Huth wrote:
> The commands 'device_add' and 'device_del' should be used
> nowadays instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hmp-commands.hx | 6 ++++--
>  vl.c            | 6 ++++++
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index baeac47..e763606 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -676,7 +676,8 @@ ETEXI
>  STEXI
>  @item usb_add @var{devname}
>  @findex usb_add
> -Add the USB device @var{devname}.  For details of available devices see
> +Add the USB device @var{devname}. This command is deprecated, please
> +use @code{device_add} instead. For details of available devices see
>  @ref{usb_devices}
>  ETEXI
>  
> @@ -693,7 +694,8 @@ STEXI
>  @findex usb_del
>  Remove the USB device @var{devname} from the QEMU virtual USB
>  hub. @var{devname} has the syntax @code{bus.addr}. Use the monitor
> -command @code{info usb} to see the devices you can remove.
> +command @code{info usb} to see the devices you can remove. This
> +command is deprecated, please use @code{device_del} instead.
>  ETEXI
>  
>      {
> diff --git a/vl.c b/vl.c
> index 3ca6bd3..268a8d8 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1435,6 +1435,9 @@ static int usb_parse(const char *cmdline)
>  void hmp_usb_add(Monitor *mon, const QDict *qdict)
>  {
>      const char *devname = qdict_get_str(qdict, "devname");
> +
> +    error_report("usb_add is deprecated, please use device_add instead");
> +
>      if (usb_device_add(devname) < 0) {
>          error_report("could not add USB device '%s'", devname);
>      }
> @@ -1443,6 +1446,9 @@ void hmp_usb_add(Monitor *mon, const QDict *qdict)
>  void hmp_usb_del(Monitor *mon, const QDict *qdict)
>  {
>      const char *devname = qdict_get_str(qdict, "devname");
> +
> +    error_report("usb_del is deprecated, please use device_del instead");
> +
>      if (usb_device_del(devname) < 0) {
>          error_report("could not delete USB device '%s'", devname);
>      }
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Re: [Qemu-devel] [PATCH] usb: Deprecate HMP commands usb_add and usb_del

Posted by Dr. David Alan Gilbert 6 years, 11 months ago

* Thomas Huth (thuth@redhat.com) wrote:
> The commands 'device_add' and 'device_del' should be used
> nowadays instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  hmp-commands.hx | 6 ++++--
>  vl.c            | 6 ++++++
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index baeac47..e763606 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -676,7 +676,8 @@ ETEXI
>  STEXI
>  @item usb_add @var{devname}
>  @findex usb_add
> -Add the USB device @var{devname}.  For details of available devices see
> +Add the USB device @var{devname}. This command is deprecated, please
> +use @code{device_add} instead. For details of available devices see
>  @ref{usb_devices}
>  ETEXI
>  
> @@ -693,7 +694,8 @@ STEXI
>  @findex usb_del
>  Remove the USB device @var{devname} from the QEMU virtual USB
>  hub. @var{devname} has the syntax @code{bus.addr}. Use the monitor
> -command @code{info usb} to see the devices you can remove.
> +command @code{info usb} to see the devices you can remove. This
> +command is deprecated, please use @code{device_del} instead.
>  ETEXI
>  
>      {
> diff --git a/vl.c b/vl.c
> index 3ca6bd3..268a8d8 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1435,6 +1435,9 @@ static int usb_parse(const char *cmdline)
>  void hmp_usb_add(Monitor *mon, const QDict *qdict)
>  {
>      const char *devname = qdict_get_str(qdict, "devname");
> +
> +    error_report("usb_add is deprecated, please use device_add instead");
> +
>      if (usb_device_add(devname) < 0) {
>          error_report("could not add USB device '%s'", devname);
>      }
> @@ -1443,6 +1446,9 @@ void hmp_usb_add(Monitor *mon, const QDict *qdict)
>  void hmp_usb_del(Monitor *mon, const QDict *qdict)
>  {
>      const char *devname = qdict_get_str(qdict, "devname");
> +
> +    error_report("usb_del is deprecated, please use device_del instead");
> +
>      if (usb_device_del(devname) < 0) {
>          error_report("could not delete USB device '%s'", devname);
>      }
> -- 
> 1.8.3.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK