[Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function.

Lan Tianyu posted 2 patches 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1495085580-10631-1-git-send-email-tianyu.lan@intel.com
Test checkpatch failed
Test docker passed
Test s390x passed
hw/pci/msi.c                  |  5 +++--
hw/pci/msix.c                 |  4 +++-
hw/xen/xen_pt_msi.c           | 52 +++++++++++++++++++++++++++++++------------
include/hw/i386/apic-msidef.h |  3 ++-
include/hw/xen/xen.h          |  2 +-
xen-hvm-stub.c                |  2 +-
xen-hvm.c                     |  7 +++++-
7 files changed, 54 insertions(+), 21 deletions(-)
[Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function.
Posted by Lan Tianyu 6 years, 11 months ago
Change since V1:
       1) Move create/destroy vIOMMU and query vIOMMU capabilities to tool stack.
       2) Fix some code style issue.

This patchset is to deal with MSI interrupt remapping request when guest
updates MSI registers.

Repo:
https://github.com/lantianyu/qemu/tree/xen_viommu_rfc_v2

Chao Gao (2):
  xen-pt: bind/unbind interrupt remapping format MSI
  msi: Handle remappable format interrupt request

 hw/pci/msi.c                  |  5 +++--
 hw/pci/msix.c                 |  4 +++-
 hw/xen/xen_pt_msi.c           | 52 +++++++++++++++++++++++++++++++------------
 include/hw/i386/apic-msidef.h |  3 ++-
 include/hw/xen/xen.h          |  2 +-
 xen-hvm-stub.c                |  2 +-
 xen-hvm.c                     |  7 +++++-
 7 files changed, 54 insertions(+), 21 deletions(-)

-- 
1.8.3.1


Re: [Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function.
Posted by no-reply@patchew.org 6 years, 11 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function.
Type: series
Message-id: 1495085580-10631-1-git-send-email-tianyu.lan@intel.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
cbe4736 msi: Handle remappable format interrupt request
65e2601 xen-pt: bind/unbind interrupt remapping format MSI

=== OUTPUT BEGIN ===
Checking PATCH 1/2: xen-pt: bind/unbind interrupt remapping format MSI...
ERROR: spaces required around that ':' (ctx:VxW)
#35: FILE: hw/xen/xen_pt_msi.c:172:
+                   is_msix ? "-X": "", addr, data);
                                  ^

ERROR: else should follow close brace '}'
#39: FILE: hw/xen/xen_pt_msi.c:176:
+    }
+    else {

ERROR: space prohibited after that open parenthesis '('
#61: FILE: hw/xen/xen_pt_msi.c:215:
+        if ( addr & MSI_ADDR_IF_MASK ) {

ERROR: space prohibited before that close parenthesis ')'
#61: FILE: hw/xen/xen_pt_msi.c:215:
+        if ( addr & MSI_ADDR_IF_MASK ) {

WARNING: line over 80 characters
#77: FILE: hw/xen/xen_pt_msi.c:231:
+            rc = xc_domain_unbind_msi_irq(xen_xc, xen_domid, gvec, pirq, gflags);

total: 4 errors, 1 warnings, 74 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: msi: Handle remappable format interrupt request...
ERROR: braces {} are necessary for all arms of this statement
#30: FILE: hw/i386/xen/xen-hvm.c:154:
+    if (msi_addr_lo & MSI_ADDR_IF_MASK)
[...]

total: 1 errors, 0 warnings, 67 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org