From: Krzysztof Kozlowski <krzk@kernel.org>

blk_name() is not modifying data passed to it through pointer and it

returns also a pointer to const so the argument can be made const for

code safeness.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

---

block/block-backend.c | 2 +-

include/sysemu/block-backend.h | 2 +-

2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/block-backend.c b/block/block-backend.c

index XXXXXXX..XXXXXXX 100644

--- a/block/block-backend.c

+++ b/block/block-backend.c

@@ -XXX,XX +XXX,XX @@ void monitor_remove_blk(BlockBackend *blk)

* Return @blk's name, a non-null string.

* Returns an empty string iff @blk is not referenced by the monitor.

*/

-const char *blk_name(BlockBackend *blk)

+const char *blk_name(const BlockBackend *blk)

{

return blk->name ?: "";

}

diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h

index XXXXXXX..XXXXXXX 100644

--- a/include/sysemu/block-backend.h

+++ b/include/sysemu/block-backend.h

@@ -XXX,XX +XXX,XX @@ int blk_get_refcnt(BlockBackend *blk);

void blk_ref(BlockBackend *blk);

void blk_unref(BlockBackend *blk);

void blk_remove_all_bs(void);

-const char *blk_name(BlockBackend *blk);

+const char *blk_name(const BlockBackend *blk);

BlockBackend *blk_by_name(const char *name);

BlockBackend *blk_next(BlockBackend *blk);

bool monitor_add_blk(BlockBackend *blk, const char *name, Error **errp);

--

1.8.3.1

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

---

block/file-posix.c | 2 --

1 file changed, 2 deletions(-)

diff --git a/block/file-posix.c b/block/file-posix.c

index XXXXXXX..XXXXXXX 100644

--- a/block/file-posix.c

+++ b/block/file-posix.c

@@ -XXX,XX +XXX,XX @@

#include "qapi/error.h"

#include "qemu/cutils.h"

#include "qemu/error-report.h"

-#include "qemu/timer.h"

-#include "qemu/log.h"

#include "block/block_int.h"

#include "qemu/module.h"

#include "trace.h"

--

1.8.3.1

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

---

block/file-win32.c | 1 -

1 file changed, 1 deletion(-)

diff --git a/block/file-win32.c b/block/file-win32.c

index XXXXXXX..XXXXXXX 100644

--- a/block/file-win32.c

+++ b/block/file-win32.c

@@ -XXX,XX +XXX,XX @@

#include "qemu/osdep.h"

#include "qapi/error.h"

#include "qemu/cutils.h"

-#include "qemu/timer.h"

#include "block/block_int.h"

#include "qemu/module.h"

#include "block/raw-aio.h"

--

1.8.3.1

From: Max Reitz <mreitz@redhat.com>

This reverts commit e3e0003a8f6570aba1421ef99a0b383a43371a74.

This commit was necessary for the 2.9 release because we were unable to

fix the underlying issue(s) in time. However, we will be for 2.10.

Signed-off-by: Max Reitz <mreitz@redhat.com>

Acked-by: Fam Zheng <famz@redhat.com>

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

---

block.c | 6 +-----

block/io.c | 12 ++----------

2 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/block.c b/block.c

index XXXXXXX..XXXXXXX 100644

--- a/block.c

+++ b/block.c

@@ -XXX,XX +XXX,XX @@ int bdrv_truncate(BdrvChild *child, int64_t offset)

BlockDriver *drv = bs->drv;

int ret;

- /* FIXME: Some format block drivers use this function instead of implicitly

- * growing their file by writing beyond its end.

- * See bdrv_aligned_pwritev() for an explanation why we currently

- * cannot assert this permission in that case. */

- // assert(child->perm & BLK_PERM_RESIZE);

+ assert(child->perm & BLK_PERM_RESIZE);

if (!drv)

return -ENOMEDIUM;

diff --git a/block/io.c b/block/io.c

index XXXXXXX..XXXXXXX 100644

--- a/block/io.c

+++ b/block/io.c

@@ -XXX,XX +XXX,XX @@ static int coroutine_fn bdrv_aligned_pwritev(BdrvChild *child,

assert(!waited || !req->serialising);

assert(req->overlap_offset <= offset);

assert(offset + bytes <= req->overlap_offset + req->overlap_bytes);

- /* FIXME: Block migration uses the BlockBackend of the guest device at a

- * point when it has not yet taken write permissions. This will be

- * fixed by a future patch, but for now we have to bypass this

- * assertion for block migration to work. */

- // assert(child->perm & BLK_PERM_WRITE);

- /* FIXME: Because of the above, we also cannot guarantee that all format

- * BDS take the BLK_PERM_RESIZE permission on their file BDS, since

- * they are not obligated to do so if they do not have any parent

- * that has taken the permission to write to them. */

- // assert(end_sector <= bs->total_sectors || child->perm & BLK_PERM_RESIZE);

+ assert(child->perm & BLK_PERM_WRITE);

+ assert(end_sector <= bs->total_sectors || child->perm & BLK_PERM_RESIZE);

ret = notifier_with_return_list_notify(&bs->before_write_notifiers, req);

--

1.8.3.1

From: Peter Lieven <pl@kamp.de>

img_convert has been around before there was an ImgConvertState or

a block backend, but it has never been modified to directly use

these structs. Change this by parsing parameters directly into

the ImgConvertState and directly use BlockBackend where possible.

Furthermore variable initialization has been reworked and sorted.

Signed-off-by: Peter Lieven <pl@kamp.de>

Reviewed-by: Eric Blake <eblake@redhat.com>

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

---

qemu-img.c | 201 +++++++++++++++++++++++++------------------------------------

1 file changed, 81 insertions(+), 120 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c

index XXXXXXX..XXXXXXX 100644

--- a/qemu-img.c

+++ b/qemu-img.c

@@ -XXX,XX +XXX,XX @@ typedef struct ImgConvertState {

int min_sparse;

size_t cluster_sectors;

size_t buf_sectors;

- int num_coroutines;

+ long num_coroutines;

int running_coroutines;

Coroutine *co[MAX_COROUTINES];

int64_t wait_sector_num[MAX_COROUTINES];

@@ -XXX,XX +XXX,XX @@ static int convert_do_copy(ImgConvertState *s)

static int img_convert(int argc, char **argv)

{

- int c, bs_n, bs_i, compress, cluster_sectors, skip_create;

- int64_t ret = 0;

- int progress = 0, flags, src_flags;

- bool writethrough, src_writethrough;

- const char *fmt, *out_fmt, *cache, *src_cache, *out_baseimg, *out_filename;

+ int c, bs_i, flags, src_flags = 0;

+ const char *fmt = NULL, *out_fmt = "raw", *cache = "unsafe",

+ *src_cache = BDRV_DEFAULT_CACHE, *out_baseimg = NULL,

+ *out_filename, *out_baseimg_param, *snapshot_name = NULL;

BlockDriver *drv, *proto_drv;

- BlockBackend **blk = NULL, *out_blk = NULL;

- BlockDriverState **bs = NULL, *out_bs = NULL;

- int64_t total_sectors;

- int64_t *bs_sectors = NULL;

- size_t bufsectors = IO_BUF_SIZE / BDRV_SECTOR_SIZE;

BlockDriverInfo bdi;

- QemuOpts *opts = NULL;

+ BlockDriverState *out_bs;

+ QemuOpts *opts = NULL, *sn_opts = NULL;

QemuOptsList *create_opts = NULL;

- const char *out_baseimg_param;

char *options = NULL;

- const char *snapshot_name = NULL;

- int min_sparse = 8; /* Need at least 4k of zeros for sparse detection */

- bool quiet = false;

Error *local_err = NULL;

- QemuOpts *sn_opts = NULL;

- ImgConvertState state;

- bool image_opts = false;

- bool wr_in_order = true;

- long num_coroutines = 8;

+ bool writethrough, src_writethrough, quiet = false, image_opts = false,

+ skip_create = false, progress = false;

+ int64_t ret = -EINVAL;

+

+ ImgConvertState s = (ImgConvertState) {

+ /* Need at least 4k of zeros for sparse detection */

+ .min_sparse = 8,

+ .buf_sectors = IO_BUF_SIZE / BDRV_SECTOR_SIZE,

+ .wr_in_order = true,

+ .num_coroutines = 8,

+ };

- fmt = NULL;

- out_fmt = "raw";

- cache = "unsafe";

- src_cache = BDRV_DEFAULT_CACHE;

- out_baseimg = NULL;

- compress = 0;

- skip_create = 0;

for(;;) {

static const struct option long_options[] = {

{"help", no_argument, 0, 'h'},

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

out_baseimg = optarg;

break;

case 'c':

- compress = 1;

+ s.compressed = true;

break;

case 'e':

error_report("option -e is deprecated, please use \'-o "

"encryption\' instead!");

- ret = -1;

goto fail_getopt;

case '6':

error_report("option -6 is deprecated, please use \'-o "

"compat6\' instead!");

- ret = -1;

goto fail_getopt;

case 'o':

if (!is_valid_option_list(optarg)) {

error_report("Invalid option list: %s", optarg);

- ret = -1;

goto fail_getopt;

}

if (!options) {

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

if (!sn_opts) {

error_report("Failed in parsing snapshot param '%s'",

optarg);

- ret = -1;

goto fail_getopt;

}

} else {

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

sval = cvtnum(optarg);

if (sval < 0) {

error_report("Invalid minimum zero buffer size for sparse output specified");

- ret = -1;

goto fail_getopt;

}

- min_sparse = sval / BDRV_SECTOR_SIZE;

+ s.min_sparse = sval / BDRV_SECTOR_SIZE;

break;

}

case 'p':

- progress = 1;

+ progress = true;

break;

case 't':

cache = optarg;

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

quiet = true;

break;

case 'n':

- skip_create = 1;

+ skip_create = true;

break;

case 'm':

- if (qemu_strtol(optarg, NULL, 0, &num_coroutines) ||

- num_coroutines < 1 || num_coroutines > MAX_COROUTINES) {

+ if (qemu_strtol(optarg, NULL, 0, &s.num_coroutines) ||

+ s.num_coroutines < 1 || s.num_coroutines > MAX_COROUTINES) {

error_report("Invalid number of coroutines. Allowed number of"

" coroutines is between 1 and %d", MAX_COROUTINES);

- ret = -1;

goto fail_getopt;

}

break;

case 'W':

- wr_in_order = false;

+ s.wr_in_order = false;

break;

case OPTION_OBJECT:

opts = qemu_opts_parse_noisily(&qemu_object_opts,

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

goto fail_getopt;

}

- if (!wr_in_order && compress) {

+ if (!s.wr_in_order && s.compressed) {

error_report("Out of order write and compress are mutually exclusive");

- ret = -1;

goto fail_getopt;

}

- /* Initialize before goto out */

- if (quiet) {

- progress = 0;

- }

- qemu_progress_init(progress, 1.0);

-

- bs_n = argc - optind - 1;

- out_filename = bs_n >= 1 ? argv[argc - 1] : NULL;

+ s.src_num = argc - optind - 1;

+ out_filename = s.src_num >= 1 ? argv[argc - 1] : NULL;

if (options && has_help_option(options)) {

ret = print_block_option_help(out_filename, out_fmt);

- goto out;

+ goto fail_getopt;

}

- if (bs_n < 1) {

- error_exit("Must specify image file name");

+ if (s.src_num < 1) {

+ error_report("Must specify image file name");

+ goto fail_getopt;

}

- if (bs_n > 1 && out_baseimg) {

+ if (s.src_num > 1 && out_baseimg) {

error_report("-B makes no sense when concatenating multiple input "

"images");

- ret = -1;

- goto out;

+ goto fail_getopt;

}

- src_flags = 0;

+ /* ret is still -EINVAL until here */

ret = bdrv_parse_cache_mode(src_cache, &src_flags, &src_writethrough);

if (ret < 0) {

error_report("Invalid source cache option: %s", src_cache);

- goto out;

+ goto fail_getopt;

}

+ /* Initialize before goto out */

+ if (quiet) {

+ progress = false;

+ }

+ qemu_progress_init(progress, 1.0);

qemu_progress_print(0, 100);

- blk = g_new0(BlockBackend *, bs_n);

- bs = g_new0(BlockDriverState *, bs_n);

- bs_sectors = g_new(int64_t, bs_n);

+ s.src = g_new0(BlockBackend *, s.src_num);

+ s.src_sectors = g_new(int64_t, s.src_num);

- total_sectors = 0;

- for (bs_i = 0; bs_i < bs_n; bs_i++) {

- blk[bs_i] = img_open(image_opts, argv[optind + bs_i],

- fmt, src_flags, src_writethrough, quiet);

- if (!blk[bs_i]) {

+ for (bs_i = 0; bs_i < s.src_num; bs_i++) {

+ s.src[bs_i] = img_open(image_opts, argv[optind + bs_i],

+ fmt, src_flags, src_writethrough, quiet);

+ if (!s.src[bs_i]) {

ret = -1;

goto out;

}

- bs[bs_i] = blk_bs(blk[bs_i]);

- bs_sectors[bs_i] = blk_nb_sectors(blk[bs_i]);

- if (bs_sectors[bs_i] < 0) {

+ s.src_sectors[bs_i] = blk_nb_sectors(s.src[bs_i]);

+ if (s.src_sectors[bs_i] < 0) {

error_report("Could not get size of %s: %s",

- argv[optind + bs_i], strerror(-bs_sectors[bs_i]));

+ argv[optind + bs_i], strerror(-s.src_sectors[bs_i]));

ret = -1;

goto out;

}

- total_sectors += bs_sectors[bs_i];

+ s.total_sectors += s.src_sectors[bs_i];

}

if (sn_opts) {

- bdrv_snapshot_load_tmp(bs[0],

+ bdrv_snapshot_load_tmp(blk_bs(s.src[0]),

qemu_opt_get(sn_opts, SNAPSHOT_OPT_ID),

qemu_opt_get(sn_opts, SNAPSHOT_OPT_NAME),

&local_err);

} else if (snapshot_name != NULL) {

- if (bs_n > 1) {

+ if (s.src_num > 1) {

error_report("No support for concatenating multiple snapshot");

ret = -1;

goto out;

}

- bdrv_snapshot_load_tmp_by_id_or_name(bs[0], snapshot_name, &local_err);

+ bdrv_snapshot_load_tmp_by_id_or_name(blk_bs(s.src[0]), snapshot_name,

+ &local_err);

}

if (local_err) {

error_reportf_err(local_err, "Failed to load snapshot: ");

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

}

}

- qemu_opt_set_number(opts, BLOCK_OPT_SIZE, total_sectors * 512,

+ qemu_opt_set_number(opts, BLOCK_OPT_SIZE, s.total_sectors * 512,

&error_abort);

ret = add_old_style_options(out_fmt, opts, out_baseimg, NULL);

if (ret < 0) {

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

if (out_baseimg_param) {

out_baseimg = out_baseimg_param;

}

+ s.target_has_backing = (bool) out_baseimg;

/* Check if compression is supported */

- if (compress) {

+ if (s.compressed) {

bool encryption =

qemu_opt_get_bool(opts, BLOCK_OPT_ENCRYPT, false);

const char *preallocation =

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

}

}

- flags = min_sparse ? (BDRV_O_RDWR | BDRV_O_UNMAP) : BDRV_O_RDWR;

+ flags = s.min_sparse ? (BDRV_O_RDWR | BDRV_O_UNMAP) : BDRV_O_RDWR;

ret = bdrv_parse_cache_mode(cache, &flags, &writethrough);

if (ret < 0) {

error_report("Invalid cache option: %s", cache);

@@ -XXX,XX +XXX,XX @@ static int img_convert(int argc, char **argv)

* the bdrv_create() call which takes different params.

* Not critical right now, so fix can wait...

*/

- out_blk = img_open_file(out_filename, out_fmt, flags, writethrough, quiet);

- if (!out_blk) {

+ s.target = img_open_file(out_filename, out_fmt, flags, writethrough, quiet);

+ if (!s.target) {

ret = -1;

goto out;

}

- out_bs = blk_bs(out_blk);

+ out_bs = blk_bs(s.target);

/* increase bufsectors from the default 4096 (2M) if opt_transfer

* or discard_alignment of the out_bs is greater. Limit to 32768 (16MB)

* as maximum. */

- bufsectors = MIN(32768,

- MAX(bufsectors,

- MAX(out_bs->bl.opt_transfer >> BDRV_SECTOR_BITS,

- out_bs->bl.pdiscard_alignment >>

- BDRV_SECTOR_BITS)));

+ s.buf_sectors = MIN(32768,

+ MAX(s.buf_sectors,

+ MAX(out_bs->bl.opt_transfer >> BDRV_SECTOR_BITS,

+ out_bs->bl.pdiscard_alignment >>

+ BDRV_SECTOR_BITS)));

if (skip_create) {

- int64_t output_sectors = blk_nb_sectors(out_blk);

+ int64_t output_sectors = blk_nb_sectors(s.target);

if (output_sectors < 0) {

error_report("unable to get output image length: %s",

strerror(-output_sectors));

ret = -1;

goto out;

- } else if (output_sectors < total_sectors) {

+ } else if (output_sectors < s.total_sectors) {

error_report("output file is smaller than input file");

ret = -1;

goto out;

}

}

- cluster_sectors = 0;

ret = bdrv_get_info(out_bs, &bdi);

if (ret < 0) {

- if (compress) {

+ if (s.compressed) {

error_report("could not get block driver info");

goto out;

}

} else {

- compress = compress || bdi.needs_compressed_writes;

- cluster_sectors = bdi.cluster_size / BDRV_SECTOR_SIZE;

- }

-

- state = (ImgConvertState) {

- .src = blk,

- .src_sectors = bs_sectors,

- .src_num = bs_n,

- .total_sectors = total_sectors,

- .target = out_blk,

- .compressed = compress,

- .target_has_backing = (bool) out_baseimg,

- .min_sparse = min_sparse,

- .cluster_sectors = cluster_sectors,

- .buf_sectors = bufsectors,

- .wr_in_order = wr_in_order,

- .num_coroutines = num_coroutines,

- };

- ret = convert_do_copy(&state);

+ s.compressed = s.compressed || bdi.needs_compressed_writes;

+ s.cluster_sectors = bdi.cluster_size / BDRV_SECTOR_SIZE;

+ }

+ ret = convert_do_copy(&s);

out:

if (!ret) {

qemu_progress_print(100, 0);

@@ -XXX,XX +XXX,XX @@ out:

qemu_opts_del(opts);

qemu_opts_free(create_opts);

qemu_opts_del(sn_opts);

- blk_unref(out_blk);

- g_free(bs);

- if (blk) {

- for (bs_i = 0; bs_i < bs_n; bs_i++) {

- blk_unref(blk[bs_i]);

+ blk_unref(s.target);

+ if (s.src) {

+ for (bs_i = 0; bs_i < s.src_num; bs_i++) {

+ blk_unref(s.src[bs_i]);

}

- g_free(blk);

+ g_free(s.src);

}

- g_free(bs_sectors);

+ g_free(s.src_sectors);

fail_getopt:

g_free(options);

- if (ret) {

- return 1;

- }

- return 0;

+ return !!ret;

}

--

1.8.3.1

Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming

migration') added blk_resume_after_migration() to the precopy migration

path, but neglected to add it to the duplicated code that is used for

postcopy migration. This means that the guest device doesn't request the

necessary permissions, which ultimately led to failing assertions.

Add the missing blk_resume_after_migration() to the postcopy path.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Eric Blake <eblake@redhat.com>

---

migration/savevm.c | 8 ++++++++

1 file changed, 8 insertions(+)

diff --git a/migration/savevm.c b/migration/savevm.c

index XXXXXXX..XXXXXXX 100644

--- a/migration/savevm.c

+++ b/migration/savevm.c

@@ -XXX,XX +XXX,XX @@ static void loadvm_postcopy_handle_run_bh(void *opaque)

error_report_err(local_err);

}

+ /* If we get an error here, just don't restart the VM yet. */

+ blk_resume_after_migration(&local_err);

+ if (local_err) {

+ error_free(local_err);

+ local_err = NULL;

+ autostart = false;

+ }

+

trace_loadvm_postcopy_handle_run_cpu_sync();

cpu_synchronize_all_post_init();

--

1.8.3.1

The only thing the escape characters achieve is making the reference

output unreadable and lines that are potentially so long that git

doesn't want to put them into an email any more. Let's filter them out.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Eric Blake <eblake@redhat.com>

---

tests/qemu-iotests/028.out | 2 +-

tests/qemu-iotests/051 | 3 +-

tests/qemu-iotests/051.out | 106 +++++++++++++++----------------

tests/qemu-iotests/051.pc.out | 132 +++++++++++++++++++--------------------

tests/qemu-iotests/068 | 4 +-

tests/qemu-iotests/068.out | 6 +-

tests/qemu-iotests/130.out | 4 +-

tests/qemu-iotests/142 | 2 +-

tests/qemu-iotests/142.out | 10 +--

tests/qemu-iotests/145 | 3 +-

tests/qemu-iotests/145.out | 2 +-

tests/qemu-iotests/common.filter | 7 +++

tests/qemu-iotests/common.qemu | 4 +-

13 files changed, 147 insertions(+), 138 deletions(-)

diff --git a/tests/qemu-iotests/028.out b/tests/qemu-iotests/028.out

index XXXXXXX..XXXXXXX 100644

--- a/tests/qemu-iotests/028.out

+++ b/tests/qemu-iotests/028.out

@@ -XXX,XX +XXX,XX @@ No errors were found on the image.

block-backup

Formatting 'TEST_DIR/t.IMGFMT.copy', fmt=IMGFMT size=4294968832 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block-info block-jinfo block-joinfo block-jobinfo block-jobs

+(qemu) info block-jobs

No active jobs

=== IO: pattern 195

read 512/512 bytes at offset 3221194240

diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051

index XXXXXXX..XXXXXXX 100755

--- a/tests/qemu-iotests/051

+++ b/tests/qemu-iotests/051

@@ -XXX,XX +XXX,XX @@ function do_run_qemu()

function run_qemu()

{

- do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qemu | _filter_generated_node_ids

+ do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qemu |

+ _filter_generated_node_ids | _filter_hmp

}

size=128M

diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out

index XXXXXXX..XXXXXXX 100644

--- a/tests/qemu-iotests/051.out

+++ b/tests/qemu-iotests/051.out

@@ -XXX,XX +XXX,XX @@ QEMU X.Y.Z monitor - type 'help' for more information

Testing: -drive file=TEST_DIR/t.qcow2,driver=qcow2,backing.file.filename=TEST_DIR/t.qcow2.orig,if=none,id=drive0 -nodefaults

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo block

+(qemu) info block

drive0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2)

Removable device: not locked, tray closed

Cache mode: writeback

Backing file: TEST_DIR/t.qcow2.orig (chain depth: 1)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,driver=raw,backing.file.filename=TEST_DIR/t.qcow2.orig

QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=raw,backing.file.filename=TEST_DIR/t.qcow2.orig: Driver doesn't support backing files

@@ -XXX,XX +XXX,XX @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,file.backing.driver=qcow2,file.backing.f

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=on

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=off

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=

QEMU_PROG: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=: Parameter 'lazy-refcounts' expects 'on' or 'off'

@@ -XXX,XX +XXX,XX @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=on: Lazy ref

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=off

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

=== No medium ===

@@ -XXX,XX +XXX,XX @@ QEMU X.Y.Z monitor - type 'help' for more information

Testing: -drive file=TEST_DIR/t.qcow2,if=virtio,readonly=on

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

=== Cache modes ===

Testing: -drive driver=null-co,cache=none

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive driver=null-co,cache=directsync

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive driver=null-co,cache=writeback

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive driver=null-co,cache=writethrough

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive driver=null-co,cache=unsafe

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive driver=null-co,cache=invalid_value

QEMU_PROG: -drive driver=null-co,cache=invalid_value: invalid cache option

Testing: -drive file=TEST_DIR/t.qcow2,cache=writeback,backing.file.filename=TEST_DIR/t.qcow2.base,backing.cache.no-flush=on,backing.node-name=backing,backing.file.node-name=backing-file,file.node-name=file,if=none,id=drive0 -nodefaults

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo block

+(qemu) info block

drive0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2)

Removable device: not locked, tray closed

Cache mode: writeback

Backing file: TEST_DIR/t.qcow2.base (chain depth: 1)

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block finfo block fiinfo block filinfo block file

+(qemu) info block file

file: TEST_DIR/t.qcow2 (file)

Cache mode: writeback

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block binfo block bainfo block bacinfo block backinfo block backiinfo block backininfo block backing

+(qemu) info block backing

backing: TEST_DIR/t.qcow2.base (qcow2, read-only)

Cache mode: writeback, ignore flushes

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block binfo block bainfo block bacinfo block backinfo block backiinfo block backininfo block backinginfo block backing-info block backing-finfo block backing-fiinf

o block backing-filinfo block backing-file

+(qemu) info block backing-file

backing-file: TEST_DIR/t.qcow2.base (file, read-only)

Cache mode: writeback, ignore flushes

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,cache=writethrough,backing.file.filename=TEST_DIR/t.qcow2.base,backing.cache.no-flush=on,backing.node-name=backing,backing.file.node-name=backing-file,file.node-name=file,if=none,id=drive0 -nodefaults

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo block

+(qemu) info block

drive0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2)

Removable device: not locked, tray closed

Cache mode: writethrough

Backing file: TEST_DIR/t.qcow2.base (chain depth: 1)

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block finfo block fiinfo block filinfo block file

+(qemu) info block file

file: TEST_DIR/t.qcow2 (file)

Cache mode: writeback

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block binfo block bainfo block bacinfo block backinfo block backiinfo block backininfo block backing

+(qemu) info block backing

backing: TEST_DIR/t.qcow2.base (qcow2, read-only)

Cache mode: writeback, ignore flushes

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block binfo block bainfo block bacinfo block backinfo block backiinfo block backininfo block backinginfo block backing-info block backing-finfo block backing-fiinf

o block backing-filinfo block backing-file

+(qemu) info block backing-file

backing-file: TEST_DIR/t.qcow2.base (file, read-only)

Cache mode: writeback, ignore flushes

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,cache=unsafe,backing.file.filename=TEST_DIR/t.qcow2.base,backing.cache.no-flush=on,backing.node-name=backing,backing.file.node-name=backing-file,file.node-name=file,if=none,id=drive0 -nodefaults

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo block

+(qemu) info block

drive0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2)

Removable device: not locked, tray closed

Cache mode: writeback, ignore flushes

Backing file: TEST_DIR/t.qcow2.base (chain depth: 1)

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block finfo block fiinfo block filinfo block file

+(qemu) info block file

file: TEST_DIR/t.qcow2 (file)

Cache mode: writeback, ignore flushes

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block binfo block bainfo block bacinfo block backinfo block backiinfo block backininfo block backing

+(qemu) info block backing

backing: TEST_DIR/t.qcow2.base (qcow2, read-only)

Cache mode: writeback, ignore flushes

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo blockinfo block info block binfo block bainfo block bacinfo block backinfo block backiinfo block backininfo block backinginfo block backing-info block backing-finfo block backing-fiinf

o block backing-filinfo block backing-file

+(qemu) info block backing-file

backing-file: TEST_DIR/t.qcow2.base (file, read-only)

Cache mode: writeback, ignore flushes

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,cache=invalid_value,backing.file.filename=TEST_DIR/t.qcow2.base,backing.cache.no-flush=on,backing.node-name=backing,backing.file.node-name=backing-file,file.node-name=file,if=none,id=drive0 -nodefaults

QEMU_PROG: -drive file=TEST_DIR/t.qcow2,cache=invalid_value,backing.file.filename=TEST_DIR/t.qcow2.base,backing.cache.no-flush=on,backing.node-name=backing,backing.file.node-name=backing-file,file.node-name=file,if=none,id=drive0: invalid cache option

@@ -XXX,XX +XXX,XX @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,cache=invalid_value,backing.file.filenam

Testing: -drive file=TEST_DIR/t.qcow2,file.driver=file

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

=== Leaving out required options ===

@@ -XXX,XX +XXX,XX @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,throttling.bps-total=-5: bps/iops/max va

Testing: -drive file=TEST_DIR/t.qcow2,bps=0

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,bps=1

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,bps=1000000000000000

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,bps=1000000000000001

QEMU_PROG: -drive file=TEST_DIR/t.qcow2,bps=1000000000000001: bps/iops/max values must be within [0, 1000000000000000]

@@ -XXX,XX +XXX,XX @@ QEMU_PROG: -drive file.filename=foo:bar: Could not open 'foo:bar': No such file

Testing: -hda file:TEST_DIR/t.qcow2

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=file:TEST_DIR/t.qcow2

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file.filename=file:TEST_DIR/t.qcow2

QEMU_PROG: -drive file.filename=file:TEST_DIR/t.qcow2: Could not open 'file:TEST_DIR/t.qcow2': No such file or directory

@@ -XXX,XX +XXX,XX @@ wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

Testing: -drive file=TEST_DIR/t.qcow2,if=none,id=drive0 -snapshot

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,snapshot=on,if=none,id=drive0

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file.filename=TEST_DIR/t.qcow2,driver=qcow2,snapshot=on,if=none,id=drive0

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file.filename=TEST_DIR/t.qcow2,driver=qcow2,if=none,id=drive0 -snapshot

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=file:TEST_DIR/t.qcow2,if=none,id=drive0 -snapshot

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=file:TEST_DIR/t.qcow2,snapshot=on,if=none,id=drive0

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,if=none,id=drive0 -snapshot

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,snapshot=on,if=none,id=drive0

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

read 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

Testing: -drive file=TEST_DIR/t.qcow2,snapshot=off,if=none,id=drive0

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x2qemu-io drive0 "write -P 0x22qemu-io drive0 "write -P 0x22 qemu-io drive0 "write -P 0x22 0

qemu-io drive0 "write -P 0x22 0 qemu-io drive0 "write -P 0x22 0 4qemu-io drive0 "write -P 0x22 0 4kqemu-io drive0 "write -P 0x22 0 4k"

+(qemu) qemu-io drive0 "write -P 0x22 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) qququiquit

+(qemu) quit

read 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

Testing: -drive file=TEST_DIR/t.qcow2,snapshot=on,if=none,id=drive0

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qqeqemqemuqemu-qemu-iqemu-ioqemu-io qemu-io dqemu-io drqemu-io driqemu-io drivqemu-io driveqemu-io drive0qemu-io drive0 qemu-io drive0 "qemu-io drive0 "wqemu-io drive0 "wrqemu-io drive0 "wriqemu-io drive0 "writqemu-io drive0 "writeqem

u-io drive0 "write qemu-io drive0 "write -qemu-io drive0 "write -Pqemu-io drive0 "write -P qemu-io drive0 "write -P 0qemu-io drive0 "write -P 0xqemu-io drive0 "write -P 0x3qemu-io drive0 "write -P 0x33qemu-io drive0 "write -P 0x33 qemu-io drive0 "write -P 0x33 0

qemu-io drive0 "write -P 0x33 0 qemu-io drive0 "write -P 0x33 0 4qemu-io drive0 "write -P 0x33 0 4kqemu-io drive0 "write -P 0x33 0 4k"

+(qemu) qemu-io drive0 "write -P 0x33 0 4k"

wrote 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

-(qemu) ccocomcommcommicommitcommit commit dcommit drcommit dricommit drivcommit drivecommit drive0

-(qemu) qququiquit

+(qemu) commit drive0

+(qemu) quit

read 4096/4096 bytes at offset 0

4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

diff --git a/tests/qemu-iotests/051.pc.out b/tests/qemu-iotests/051.pc.out

index XXXXXXX..XXXXXXX 100644

--- a/tests/qemu-iotests/051.pc.out

+++ b/tests/qemu-iotests/051.pc.out

@@ -XXX,XX +XXX,XX @@ QEMU X.Y.Z monitor - type 'help' for more information

Testing: -drive file=TEST_DIR/t.qcow2,driver=qcow2,backing.file.filename=TEST_DIR/t.qcow2.orig,if=none,id=drive0 -nodefaults

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) iininfinfoinfo info binfo blinfo bloinfo blocinfo block

+(qemu) info block

drive0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2)

Removable device: not locked, tray closed

Cache mode: writeback

Backing file: TEST_DIR/t.qcow2.orig (chain depth: 1)

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,driver=raw,backing.file.filename=TEST_DIR/t.qcow2.orig

QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=raw,backing.file.filename=TEST_DIR/t.qcow2.orig: Driver doesn't support backing files

@@ -XXX,XX +XXX,XX @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,file.backing.driver=qcow2,file.backing.f

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=on

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=off

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=

QEMU_PROG: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=: Parameter 'lazy-refcounts' expects 'on' or 'off'

@@ -XXX,XX +XXX,XX @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=on: Lazy ref

Testing: -drive file=TEST_DIR/t.qcow2,format=qcow2,lazy-refcounts=off

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

=== No medium ===

Testing: -drive if=floppy

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive if=ide,media=cdrom

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive if=scsi,media=cdrom

QEMU X.Y.Z monitor - type 'help' for more information

(qemu) QEMU_PROG: -drive if=scsi,media=cdrom: warning: bus=0,unit=0 is deprecated with this machine type

-qququiquit

+quit

Testing: -drive if=ide

QEMU X.Y.Z monitor - type 'help' for more information

@@ -XXX,XX +XXX,XX @@ QEMU X.Y.Z monitor - type 'help' for more information

Testing: -drive if=none,id=disk -device ide-cd,drive=disk

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive if=none,id=disk -device lsi53c895a -device scsi-cd,drive=disk

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive if=none,id=disk -device ide-drive,drive=disk

QEMU X.Y.Z monitor - type 'help' for more information

@@ -XXX,XX +XXX,XX @@ QEMU X.Y.Z monitor - type 'help' for more information

Testing: -drive file=TEST_DIR/t.qcow2,if=floppy,readonly=on

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,if=ide,media=cdrom,readonly=on

QEMU X.Y.Z monitor - type 'help' for more information

-(qemu) qququiquit

+(qemu) quit

Testing: -drive file=TEST_DIR/t.qcow2,if=scsi,media=cdrom,readonly=on

QEMU X.Y.Z monitor - type 'help' for more information