[Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal

Greg Kurz posted 4 patches 8 years, 6 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal
Posted by Greg Kurz 8 years, 6 months ago
The code only uses well known format strings. An unknown format token is a
bug.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 fsdev/9p-iov-marshal.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
index 1d16f8df4bd4..a1c9beddd2e7 100644
--- a/fsdev/9p-iov-marshal.c
+++ b/fsdev/9p-iov-marshal.c
@@ -168,7 +168,7 @@ ssize_t v9fs_iov_vunmarshal(struct iovec *out_sg, int out_num, size_t offset,
             break;
         }
         default:
-            break;
+            g_assert_not_reached();
         }
         if (copied < 0) {
             return copied;
@@ -281,7 +281,7 @@ ssize_t v9fs_iov_vmarshal(struct iovec *in_sg, int in_num, size_t offset,
             break;
         }
         default:
-            break;
+            g_assert_not_reached();
         }
         if (copied < 0) {
             return copied;


Re: [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal
Posted by Stefano Stabellini 8 years, 6 months ago
On Thu, 27 Apr 2017, Greg Kurz wrote:
> The code only uses well known format strings. An unknown format token is a
> bug.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  fsdev/9p-iov-marshal.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
> index 1d16f8df4bd4..a1c9beddd2e7 100644
> --- a/fsdev/9p-iov-marshal.c
> +++ b/fsdev/9p-iov-marshal.c
> @@ -168,7 +168,7 @@ ssize_t v9fs_iov_vunmarshal(struct iovec *out_sg, int out_num, size_t offset,
>              break;
>          }
>          default:
> -            break;
> +            g_assert_not_reached();
>          }
>          if (copied < 0) {
>              return copied;
> @@ -281,7 +281,7 @@ ssize_t v9fs_iov_vmarshal(struct iovec *in_sg, int in_num, size_t offset,
>              break;
>          }
>          default:
> -            break;
> +            g_assert_not_reached();
>          }
>          if (copied < 0) {
>              return copied;
> 
>