[Qemu-devel] [PATCH v2] configure: fix trace backend list for out-of-tree builds

Greg Kurz posted 1 patch 147 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/149321376763.7874.12797658801011614451.stgit@bahia
Test checkpatch passed
Test docker passed
Test s390x passed
configure |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH v2] configure: fix trace backend list for out-of-tree builds

Posted by Greg Kurz 147 weeks ago
Since commit "c53eeaf75a04 configure: eliminate Python dependency for
--help", configure --help fails to produce the list of available trace
backends if invoked out-of-tree. It also spits the following error:

grep: scripts/tracetool/backend/*.py: No such file or directory

This patch simply adds the missing $source_path to fix it.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
v2: - use "$source_path" instead of $source_path
---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index c35acf119261..c434736c2e27 100755
--- a/configure
+++ b/configure
@@ -1271,7 +1271,7 @@ for config in $mak_wilds; do
 done
 
 # Enumerate public trace backends for --help output
-trace_backend_list=$(echo $(grep -le '^PUBLIC = True$' scripts/tracetool/backend/*.py | sed -e 's/^.*\/\(.*\)\.py$/\1/'))
+trace_backend_list=$(echo $(grep -le '^PUBLIC = True$' "$source_path"/scripts/tracetool/backend/*.py | sed -e 's/^.*\/\(.*\)\.py$/\1/'))
 
 if test x"$show_help" = x"yes" ; then
 cat << EOF


Re: [Qemu-devel] [PATCH v2] configure: fix trace backend list for out-of-tree builds

Posted by Stefan Hajnoczi 147 weeks ago
On Wed, Apr 26, 2017 at 03:36:07PM +0200, Greg Kurz wrote:
> Since commit "c53eeaf75a04 configure: eliminate Python dependency for
> --help", configure --help fails to produce the list of available trace
> backends if invoked out-of-tree. It also spits the following error:
> 
> grep: scripts/tracetool/backend/*.py: No such file or directory
> 
> This patch simply adds the missing $source_path to fix it.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> v2: - use "$source_path" instead of $source_path
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging

Stefan