net/dump: Issue a warning for the deprecated "-net dump"

[Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump"

Thomas Huth posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1493106644-6049-1-git-send-email-thuth@redhat.com

Test checkpatch passed

Test docker passed

Test s390x passed

net/dump.c | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump"

Posted by Thomas Huth 7 years ago

Network dumping should be done with "-object filter-dump" nowadays.
Using "-net dump" via the VLAN mechanism is considered as deprecated
and might be removed in a future release. So warn the users now
to inform them to user the filter-dump method instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 net/dump.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/dump.c b/net/dump.c
index 89a149b..442eb53 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -194,6 +194,9 @@ int net_init_dump(const Netdev *netdev, const char *name,
 
     assert(peer);
 
+    error_report("'-net dump' is deprecated. "
+                 "Please use '-object filter-dump' instead.");
+
     if (dump->has_file) {
         file = dump->file;
     } else {
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump"

Posted by Jason Wang 6 years, 12 months ago


On 2017年04月25日 15:50, Thomas Huth wrote:
> Network dumping should be done with "-object filter-dump" nowadays.
> Using "-net dump" via the VLAN mechanism is considered as deprecated
> and might be removed in a future release. So warn the users now
> to inform them to user the filter-dump method instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   net/dump.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/net/dump.c b/net/dump.c
> index 89a149b..442eb53 100644
> --- a/net/dump.c
> +++ b/net/dump.c
> @@ -194,6 +194,9 @@ int net_init_dump(const Netdev *netdev, const char *name,
>   
>       assert(peer);
>   
> +    error_report("'-net dump' is deprecated. "
> +                 "Please use '-object filter-dump' instead.");
> +
>       if (dump->has_file) {
>           file = dump->file;
>       } else {

Applied.

Thanks