include/net/net.h | 4 +++- net/colo-compare.c | 48 +++++++++++++++++++++++++++++++++++++++--------- net/colo.c | 9 +++++---- net/colo.h | 4 +++- net/filter-mirror.c | 25 ++++++++++++++++++++----- net/filter-rewriter.c | 2 +- net/net.c | 24 ++++++++++++++++++++++-- net/socket.c | 6 ++++++ 8 files changed, 99 insertions(+), 23 deletions(-)
If user use -device virtio-net-pci, virtio-net driver will add a header
to raw net packet that colo-proxy can't handle it. COLO-proxy just
focus on the packet payload, so we skip the virtio-net header to compare
the sent packet that primary guest's to secondary guest's.
Zhang Chen (6):
net/filter-mirror.c: Add filter-mirror and filter-redirector vnet
support.
net/net.c: Add vnet header length to SocketReadState
net/colo-compare.c: Make colo-compare support vnet_hdr_len
net/socket.c: Add vnet packet support in net_socket_receive()
net/colo.c: Add vnet packet parse feature in colo-proxy
net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare
include/net/net.h | 4 +++-
net/colo-compare.c | 48 +++++++++++++++++++++++++++++++++++++++---------
net/colo.c | 9 +++++----
net/colo.h | 4 +++-
net/filter-mirror.c | 25 ++++++++++++++++++++-----
net/filter-rewriter.c | 2 +-
net/net.c | 24 ++++++++++++++++++++++--
net/socket.c | 6 ++++++
8 files changed, 99 insertions(+), 23 deletions(-)
--
2.7.4
On 2017年04月20日 14:39, Zhang Chen wrote:
> If user use -device virtio-net-pci, virtio-net driver will add a header
> to raw net packet that colo-proxy can't handle it. COLO-proxy just
> focus on the packet payload, so we skip the virtio-net header to compare
> the sent packet that primary guest's to secondary guest's.
>
> Zhang Chen (6):
> net/filter-mirror.c: Add filter-mirror and filter-redirector vnet
> support.
> net/net.c: Add vnet header length to SocketReadState
> net/colo-compare.c: Make colo-compare support vnet_hdr_len
> net/socket.c: Add vnet packet support in net_socket_receive()
> net/colo.c: Add vnet packet parse feature in colo-proxy
> net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare
>
> include/net/net.h | 4 +++-
> net/colo-compare.c | 48 +++++++++++++++++++++++++++++++++++++++---------
> net/colo.c | 9 +++++----
> net/colo.h | 4 +++-
> net/filter-mirror.c | 25 ++++++++++++++++++++-----
> net/filter-rewriter.c | 2 +-
> net/net.c | 24 ++++++++++++++++++++++--
> net/socket.c | 6 ++++++
> 8 files changed, 99 insertions(+), 23 deletions(-)
>
A quick glance at the series and find two issues:
- We can't assume virtio-net is the only user for vnet header, you need
query e.g NetClientState for a correct vnet header len.
- This series breaks qtest:
**
ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
(buffer == "TEST"): ("" == "TEST")
GTester: last random seed: R02S39dd06f7f52013798111df2e4eb602c5
**
ERROR:tests/e1000e-test.c:365:e1000e_receive_verify: assertion failed
(le32_to_cpu(descr.wb.upper.status_error) & esta_dd == esta_dd):
(0x00000000 == 0x00000001)
GTester: last random seed: R02S8c8200b8ec86358cb7addb5c6fe1303c
**
ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
(buffer == "TEST"): ("" == "TEST")
GTester: last random seed: R02S9be86025aa7ded4902bdf644c3964a6e
**
ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion failed:
(g_get_monotonic_time() - start_time <= timeout_us)
GTester: last random seed: R02S30cac33d7a98fa56806ca59b35910ea5
**
ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion failed:
(g_get_monotonic_time() - start_time <= timeout_us)
GTester: last random seed: R02S258359836760a723622abf56cf2e61e7
^C/home/devel/git/qemu/tests/Makefile.include:815: recipe for target
'check-qtest-x86_64' failed
make: *** [check-qtest-x86_64] Interrupt
Please fix them.
Thanks
On 04/24/2017 11:48 AM, Jason Wang wrote:
>
>
> On 2017年04月20日 14:39, Zhang Chen wrote:
>> If user use -device virtio-net-pci, virtio-net driver will add a header
>> to raw net packet that colo-proxy can't handle it. COLO-proxy just
>> focus on the packet payload, so we skip the virtio-net header to compare
>> the sent packet that primary guest's to secondary guest's.
>>
>> Zhang Chen (6):
>> net/filter-mirror.c: Add filter-mirror and filter-redirector vnet
>> support.
>> net/net.c: Add vnet header length to SocketReadState
>> net/colo-compare.c: Make colo-compare support vnet_hdr_len
>> net/socket.c: Add vnet packet support in net_socket_receive()
>> net/colo.c: Add vnet packet parse feature in colo-proxy
>> net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare
>>
>> include/net/net.h | 4 +++-
>> net/colo-compare.c | 48
>> +++++++++++++++++++++++++++++++++++++++---------
>> net/colo.c | 9 +++++----
>> net/colo.h | 4 +++-
>> net/filter-mirror.c | 25 ++++++++++++++++++++-----
>> net/filter-rewriter.c | 2 +-
>> net/net.c | 24 ++++++++++++++++++++++--
>> net/socket.c | 6 ++++++
>> 8 files changed, 99 insertions(+), 23 deletions(-)
>>
>
> A quick glance at the series and find two issues:
>
> - We can't assume virtio-net is the only user for vnet header, you
> need query e.g NetClientState for a correct vnet header len.
OK~~ I will fix it in next version.
> - This series breaks qtest:
>
> **
> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
> (buffer == "TEST"): ("" == "TEST")
> GTester: last random seed: R02S39dd06f7f52013798111df2e4eb602c5
> **
> ERROR:tests/e1000e-test.c:365:e1000e_receive_verify: assertion failed
> (le32_to_cpu(descr.wb.upper.status_error) & esta_dd == esta_dd):
> (0x00000000 == 0x00000001)
> GTester: last random seed: R02S8c8200b8ec86358cb7addb5c6fe1303c
> **
> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
> (buffer == "TEST"): ("" == "TEST")
> GTester: last random seed: R02S9be86025aa7ded4902bdf644c3964a6e
> **
> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
> failed: (g_get_monotonic_time() - start_time <= timeout_us)
> GTester: last random seed: R02S30cac33d7a98fa56806ca59b35910ea5
> **
> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
> failed: (g_get_monotonic_time() - start_time <= timeout_us)
> GTester: last random seed: R02S258359836760a723622abf56cf2e61e7
> ^C/home/devel/git/qemu/tests/Makefile.include:815: recipe for target
> 'check-qtest-x86_64' failed
> make: *** [check-qtest-x86_64] Interrupt
>
> Please fix them.
>
Oh~~ I will fix thrm.
Thanks
Zhang Chen
> Thanks
>
>
> .
>
--
Thanks
Zhang Chen
On 04/24/2017 11:48 AM, Jason Wang wrote:
>
>
> On 2017年04月20日 14:39, Zhang Chen wrote:
>> If user use -device virtio-net-pci, virtio-net driver will add a header
>> to raw net packet that colo-proxy can't handle it. COLO-proxy just
>> focus on the packet payload, so we skip the virtio-net header to compare
>> the sent packet that primary guest's to secondary guest's.
>>
>> Zhang Chen (6):
>> net/filter-mirror.c: Add filter-mirror and filter-redirector vnet
>> support.
>> net/net.c: Add vnet header length to SocketReadState
>> net/colo-compare.c: Make colo-compare support vnet_hdr_len
>> net/socket.c: Add vnet packet support in net_socket_receive()
>> net/colo.c: Add vnet packet parse feature in colo-proxy
>> net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare
>>
>> include/net/net.h | 4 +++-
>> net/colo-compare.c | 48
>> +++++++++++++++++++++++++++++++++++++++---------
>> net/colo.c | 9 +++++----
>> net/colo.h | 4 +++-
>> net/filter-mirror.c | 25 ++++++++++++++++++++-----
>> net/filter-rewriter.c | 2 +-
>> net/net.c | 24 ++++++++++++++++++++++--
>> net/socket.c | 6 ++++++
>> 8 files changed, 99 insertions(+), 23 deletions(-)
>>
>
> A quick glance at the series and find two issues:
>
> - We can't assume virtio-net is the only user for vnet header, you
> need query e.g NetClientState for a correct vnet header len.
I don't know whether I understand your means.
I found that I can't get vnet_hdr_len from NetClientState,
typedef struct NetClientInfo {
.....
HasVnetHdr *has_vnet_hdr;
HasVnetHdrLen *has_vnet_hdr_len;
UsingVnetHdr *using_vnet_hdr;
SetOffload *set_offload;
SetVnetHdrLen *set_vnet_hdr_len;
.....
}NetClientInfo;
This struct haven't a function like get_vnet_hdr_len.
Should I add the get_vnet_hdr_len callback here and write new function
in tap.c,tap-wen32.c and netmap.c ?
Thanks
Zhang Chen
> - This series breaks qtest:
>
> **
> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
> (buffer == "TEST"): ("" == "TEST")
> GTester: last random seed: R02S39dd06f7f52013798111df2e4eb602c5
> **
> ERROR:tests/e1000e-test.c:365:e1000e_receive_verify: assertion failed
> (le32_to_cpu(descr.wb.upper.status_error) & esta_dd == esta_dd):
> (0x00000000 == 0x00000001)
> GTester: last random seed: R02S8c8200b8ec86358cb7addb5c6fe1303c
> **
> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
> (buffer == "TEST"): ("" == "TEST")
> GTester: last random seed: R02S9be86025aa7ded4902bdf644c3964a6e
> **
> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
> failed: (g_get_monotonic_time() - start_time <= timeout_us)
> GTester: last random seed: R02S30cac33d7a98fa56806ca59b35910ea5
> **
> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
> failed: (g_get_monotonic_time() - start_time <= timeout_us)
> GTester: last random seed: R02S258359836760a723622abf56cf2e61e7
> ^C/home/devel/git/qemu/tests/Makefile.include:815: recipe for target
> 'check-qtest-x86_64' failed
> make: *** [check-qtest-x86_64] Interrupt
>
> Please fix them.
>
> Thanks
>
>
> .
>
--
Thanks
Zhang Chen
On 2017年04月24日 20:02, Zhang Chen wrote:
>
>
> On 04/24/2017 11:48 AM, Jason Wang wrote:
>>
>>
>> On 2017年04月20日 14:39, Zhang Chen wrote:
>>> If user use -device virtio-net-pci, virtio-net driver will add a header
>>> to raw net packet that colo-proxy can't handle it. COLO-proxy just
>>> focus on the packet payload, so we skip the virtio-net header to
>>> compare
>>> the sent packet that primary guest's to secondary guest's.
>>>
>>> Zhang Chen (6):
>>> net/filter-mirror.c: Add filter-mirror and filter-redirector vnet
>>> support.
>>> net/net.c: Add vnet header length to SocketReadState
>>> net/colo-compare.c: Make colo-compare support vnet_hdr_len
>>> net/socket.c: Add vnet packet support in net_socket_receive()
>>> net/colo.c: Add vnet packet parse feature in colo-proxy
>>> net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare
>>>
>>> include/net/net.h | 4 +++-
>>> net/colo-compare.c | 48
>>> +++++++++++++++++++++++++++++++++++++++---------
>>> net/colo.c | 9 +++++----
>>> net/colo.h | 4 +++-
>>> net/filter-mirror.c | 25 ++++++++++++++++++++-----
>>> net/filter-rewriter.c | 2 +-
>>> net/net.c | 24 ++++++++++++++++++++++--
>>> net/socket.c | 6 ++++++
>>> 8 files changed, 99 insertions(+), 23 deletions(-)
>>>
>>
>> A quick glance at the series and find two issues:
>>
>> - We can't assume virtio-net is the only user for vnet header, you
>> need query e.g NetClientState for a correct vnet header len.
>
> I don't know whether I understand your means.
> I found that I can't get vnet_hdr_len from NetClientState,
>
> typedef struct NetClientInfo {
> .....
> HasVnetHdr *has_vnet_hdr;
> HasVnetHdrLen *has_vnet_hdr_len;
> UsingVnetHdr *using_vnet_hdr;
> SetOffload *set_offload;
> SetVnetHdrLen *set_vnet_hdr_len;
>
> .....
> }NetClientInfo;
>
> This struct haven't a function like get_vnet_hdr_len.
> Should I add the get_vnet_hdr_len callback here and write new function
> in tap.c,tap-wen32.c and netmap.c ?
>
> Thanks
> Zhang Chen
Yes, you need add such callbacks I think.
Thanks
>
>> - This series breaks qtest:
>>
>> **
>> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
>> (buffer == "TEST"): ("" == "TEST")
>> GTester: last random seed: R02S39dd06f7f52013798111df2e4eb602c5
>> **
>> ERROR:tests/e1000e-test.c:365:e1000e_receive_verify: assertion failed
>> (le32_to_cpu(descr.wb.upper.status_error) & esta_dd == esta_dd):
>> (0x00000000 == 0x00000001)
>> GTester: last random seed: R02S8c8200b8ec86358cb7addb5c6fe1303c
>> **
>> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
>> (buffer == "TEST"): ("" == "TEST")
>> GTester: last random seed: R02S9be86025aa7ded4902bdf644c3964a6e
>> **
>> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
>> failed: (g_get_monotonic_time() - start_time <= timeout_us)
>> GTester: last random seed: R02S30cac33d7a98fa56806ca59b35910ea5
>> **
>> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
>> failed: (g_get_monotonic_time() - start_time <= timeout_us)
>> GTester: last random seed: R02S258359836760a723622abf56cf2e61e7
>> ^C/home/devel/git/qemu/tests/Makefile.include:815: recipe for target
>> 'check-qtest-x86_64' failed
>> make: *** [check-qtest-x86_64] Interrupt
>>
>> Please fix them.
>>
>> Thanks
>>
>>
>> .
>>
>
On 04/25/2017 11:54 AM, Jason Wang wrote:
>
>
> On 2017年04月24日 20:02, Zhang Chen wrote:
>>
>>
>> On 04/24/2017 11:48 AM, Jason Wang wrote:
>>>
>>>
>>> On 2017年04月20日 14:39, Zhang Chen wrote:
>>>> If user use -device virtio-net-pci, virtio-net driver will add a
>>>> header
>>>> to raw net packet that colo-proxy can't handle it. COLO-proxy just
>>>> focus on the packet payload, so we skip the virtio-net header to
>>>> compare
>>>> the sent packet that primary guest's to secondary guest's.
>>>>
>>>> Zhang Chen (6):
>>>> net/filter-mirror.c: Add filter-mirror and filter-redirector vnet
>>>> support.
>>>> net/net.c: Add vnet header length to SocketReadState
>>>> net/colo-compare.c: Make colo-compare support vnet_hdr_len
>>>> net/socket.c: Add vnet packet support in net_socket_receive()
>>>> net/colo.c: Add vnet packet parse feature in colo-proxy
>>>> net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare
>>>>
>>>> include/net/net.h | 4 +++-
>>>> net/colo-compare.c | 48
>>>> +++++++++++++++++++++++++++++++++++++++---------
>>>> net/colo.c | 9 +++++----
>>>> net/colo.h | 4 +++-
>>>> net/filter-mirror.c | 25 ++++++++++++++++++++-----
>>>> net/filter-rewriter.c | 2 +-
>>>> net/net.c | 24 ++++++++++++++++++++++--
>>>> net/socket.c | 6 ++++++
>>>> 8 files changed, 99 insertions(+), 23 deletions(-)
>>>>
>>>
>>> A quick glance at the series and find two issues:
>>>
>>> - We can't assume virtio-net is the only user for vnet header, you
>>> need query e.g NetClientState for a correct vnet header len.
>>
>> I don't know whether I understand your means.
>> I found that I can't get vnet_hdr_len from NetClientState,
>>
>> typedef struct NetClientInfo {
>> .....
>> HasVnetHdr *has_vnet_hdr;
>> HasVnetHdrLen *has_vnet_hdr_len;
>> UsingVnetHdr *using_vnet_hdr;
>> SetOffload *set_offload;
>> SetVnetHdrLen *set_vnet_hdr_len;
>>
>> .....
>> }NetClientInfo;
>>
>> This struct haven't a function like get_vnet_hdr_len.
>> Should I add the get_vnet_hdr_len callback here and write new
>> function in tap.c,tap-wen32.c and netmap.c ?
>>
>> Thanks
>> Zhang Chen
>
> Yes, you need add such callbacks I think.
>
OK, I got your point~
Thanks
Zhang Chen
> Thanks
>
>>
>>> - This series breaks qtest:
>>>
>>> **
>>> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
>>> (buffer == "TEST"): ("" == "TEST")
>>> GTester: last random seed: R02S39dd06f7f52013798111df2e4eb602c5
>>> **
>>> ERROR:tests/e1000e-test.c:365:e1000e_receive_verify: assertion
>>> failed (le32_to_cpu(descr.wb.upper.status_error) & esta_dd ==
>>> esta_dd): (0x00000000 == 0x00000001)
>>> GTester: last random seed: R02S8c8200b8ec86358cb7addb5c6fe1303c
>>> **
>>> ERROR:tests/e1000e-test.c:296:e1000e_send_verify: assertion failed
>>> (buffer == "TEST"): ("" == "TEST")
>>> GTester: last random seed: R02S9be86025aa7ded4902bdf644c3964a6e
>>> **
>>> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
>>> failed: (g_get_monotonic_time() - start_time <= timeout_us)
>>> GTester: last random seed: R02S30cac33d7a98fa56806ca59b35910ea5
>>> **
>>> ERROR:tests/libqos/virtio.c:94:qvirtio_wait_queue_isr: assertion
>>> failed: (g_get_monotonic_time() - start_time <= timeout_us)
>>> GTester: last random seed: R02S258359836760a723622abf56cf2e61e7
>>> ^C/home/devel/git/qemu/tests/Makefile.include:815: recipe for target
>>> 'check-qtest-x86_64' failed
>>> make: *** [check-qtest-x86_64] Interrupt
>>>
>>> Please fix them.
>>>
>>> Thanks
>>>
>>>
>>> .
>>>
>>
>
>
>
> .
>
--
Thanks
Zhang Chen
© 2016 - 2024 Red Hat, Inc.