1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4

Kevin Wolf posted 10 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1491572865-8549-1-git-send-email-kwolf@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
block.c                       |  4 ++++
block/block-backend.c         | 40 ++++++++++++++++++++++++++++++++++++-
block/commit.c                |  3 +++
block/io.c                    |  9 ++++++++-
block/mirror.c                | 13 ++++++++++--
blockdev.c                    |  4 ++--
include/block/block.h         |  2 ++
migration/migration.c         |  8 ++++++++
qemu-img-cmds.hx              |  4 ++--
qmp.c                         |  6 ++++++
tests/qemu-iotests/041        | 46 +++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/041.out    |  4 ++--
tests/qemu-iotests/iotests.py | 15 ++++++++++++++
13 files changed, 148 insertions(+), 10 deletions(-)
[Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4
Posted by Kevin Wolf 7 years ago 
The following changes since commit 5fe2339e6b09da7d6f48b9bef0f1a7360392b489:

  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20170406.0' into staging (2017-04-07 10:29:56 +0100)

are available in the git repository at:


  git://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to 19dd29e8a77cd820515de5289f566508e0ed4926:

  mirror: Fix aio context of mirror_top_bs (2017-04-07 14:44:06 +0200)

----------------------------------------------------------------
Block layer fixes for 2.9.0-rc4

----------------------------------------------------------------
Fam Zheng (3):
      block: Fix unpaired aio_disable_external in external snapshot
      block: Assert attached child node has right aio context
      mirror: Fix aio context of mirror_top_bs

Jeff Cody (1):
      qemu-img: img_create does not support image-opts, fix docs

Kevin Wolf (4):
      block: Ignore guest dev permissions during incoming migration
      commit: Set commit_top_bs->aio_context
      commit: Set commit_top_bs->total_sectors
      block: Don't check permissions for copy on read

Max Reitz (2):
      block/mirror: Fix use-after-free
      iotests: Add mirror tests for orphaned source

 block.c                       |  4 ++++
 block/block-backend.c         | 40 ++++++++++++++++++++++++++++++++++++-
 block/commit.c                |  3 +++
 block/io.c                    |  9 ++++++++-
 block/mirror.c                | 13 ++++++++++--
 blockdev.c                    |  4 ++--
 include/block/block.h         |  2 ++
 migration/migration.c         |  8 ++++++++
 qemu-img-cmds.hx              |  4 ++--
 qmp.c                         |  6 ++++++
 tests/qemu-iotests/041        | 46 +++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/041.out    |  4 ++--
 tests/qemu-iotests/iotests.py | 15 ++++++++++++++
 13 files changed, 148 insertions(+), 10 deletions(-)
Re: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4
Posted by Peter Maydell 7 years ago 
On 7 April 2017 at 14:47, Kevin Wolf <kwolf@redhat.com> wrote:
> The following changes since commit 5fe2339e6b09da7d6f48b9bef0f1a7360392b489:
>
>   Merge remote-tracking branch 'remotes/awilliam/tags/vfio-updates-20170406.0' into staging (2017-04-07 10:29:56 +0100)
>
> are available in the git repository at:
>
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 19dd29e8a77cd820515de5289f566508e0ed4926:
>
>   mirror: Fix aio context of mirror_top_bs (2017-04-07 14:44:06 +0200)
>
> ----------------------------------------------------------------
> Block layer fixes for 2.9.0-rc4
>
> ----------------------------------------------------------------
> Fam Zheng (3):
>       block: Fix unpaired aio_disable_external in external snapshot
>       block: Assert attached child node has right aio context
>       mirror: Fix aio context of mirror_top_bs
>
> Jeff Cody (1):
>       qemu-img: img_create does not support image-opts, fix docs
>
> Kevin Wolf (4):
>       block: Ignore guest dev permissions during incoming migration
>       commit: Set commit_top_bs->aio_context
>       commit: Set commit_top_bs->total_sectors
>       block: Don't check permissions for copy on read
>
> Max Reitz (2):
>       block/mirror: Fix use-after-free
>       iotests: Add mirror tests for orphaned source

Applied, thanks.

-- PMM
Re: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4
Posted by no-reply@patchew.org 7 years ago 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 1491572865-8549-1-git-send-email-kwolf@redhat.com
Subject: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4a9e7db mirror: Fix aio context of mirror_top_bs
79767f5 block: Assert attached child node has right aio context
dfad3a5 block: Fix unpaired aio_disable_external in external snapshot
99be1dc block: Don't check permissions for copy on read
0e5e935 qemu-img: img_create does not support image-opts, fix docs
3afb9fa iotests: Add mirror tests for orphaned source
5ccc43d block/mirror: Fix use-after-free
e65d767 commit: Set commit_top_bs->total_sectors
2dddcd2 commit: Set commit_top_bs->aio_context
5770f38 block: Ignore guest dev permissions during incoming migration

=== OUTPUT BEGIN ===
Checking PATCH 1/10: block: Ignore guest dev permissions during incoming migration...
Checking PATCH 2/10: commit: Set commit_top_bs->aio_context...
Checking PATCH 3/10: commit: Set commit_top_bs->total_sectors...
Checking PATCH 4/10: block/mirror: Fix use-after-free...
Checking PATCH 5/10: iotests: Add mirror tests for orphaned source...
Checking PATCH 6/10: qemu-img: img_create does not support image-opts, fix docs...
Checking PATCH 7/10: block: Don't check permissions for copy on read...
ERROR: do not use C99 // comments
#32: FILE: block/io.c:955:
+    // assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));

total: 1 errors, 0 warnings, 15 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/10: block: Fix unpaired aio_disable_external in external snapshot...
Checking PATCH 9/10: block: Assert attached child node has right aio context...
Checking PATCH 10/10: mirror: Fix aio context of mirror_top_bs...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Re: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4
Posted by Fam Zheng 7 years ago 
On Wed, 04/12 16:51, no-reply@patchew.org wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Message-id: 1491572865-8549-1-git-send-email-kwolf@redhat.com
> Subject: [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4
> Type: series
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 4a9e7db mirror: Fix aio context of mirror_top_bs
> 79767f5 block: Assert attached child node has right aio context
> dfad3a5 block: Fix unpaired aio_disable_external in external snapshot
> 99be1dc block: Don't check permissions for copy on read
> 0e5e935 qemu-img: img_create does not support image-opts, fix docs
> 3afb9fa iotests: Add mirror tests for orphaned source
> 5ccc43d block/mirror: Fix use-after-free
> e65d767 commit: Set commit_top_bs->total_sectors
> 2dddcd2 commit: Set commit_top_bs->aio_context
> 5770f38 block: Ignore guest dev permissions during incoming migration
> 
> === OUTPUT BEGIN ===
> Checking PATCH 1/10: block: Ignore guest dev permissions during incoming migration...
> Checking PATCH 2/10: commit: Set commit_top_bs->aio_context...
> Checking PATCH 3/10: commit: Set commit_top_bs->total_sectors...
> Checking PATCH 4/10: block/mirror: Fix use-after-free...
> Checking PATCH 5/10: iotests: Add mirror tests for orphaned source...
> Checking PATCH 6/10: qemu-img: img_create does not support image-opts, fix docs...
> Checking PATCH 7/10: block: Don't check permissions for copy on read...
> ERROR: do not use C99 // comments
> #32: FILE: block/io.c:955:
> +    // assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));
> 
> total: 1 errors, 0 warnings, 15 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Checking PATCH 8/10: block: Fix unpaired aio_disable_external in external snapshot...
> Checking PATCH 9/10: block: Assert attached child node has right aio context...
> Checking PATCH 10/10: mirror: Fix aio context of mirror_top_bs...
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@freelists.org

Hmm, patchew has stalled and a long queue of series is now being processed. I'm
going to disable email notifications for now until it catches up.

Fam

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.