* Peter Xu (peterx@redhat.com) wrote:
> Dump the info in a single line is hard to read. Do it one per line.
> Also, the first "capabilities:" didn't help much. Let's remove it.
>
> CC: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
agreed, although you may find it breaks some peoples scripts, but
we're allowed to do that in HMP and it should be more readable, so:
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hmp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index edb8970..95eef8c 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -265,13 +265,11 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
> caps = qmp_query_migrate_capabilities(NULL);
>
> if (caps) {
> - monitor_printf(mon, "capabilities: ");
> for (cap = caps; cap; cap = cap->next) {
> - monitor_printf(mon, "%s: %s ",
> + monitor_printf(mon, "%s: %s\n",
> MigrationCapability_lookup[cap->value->capability],
> cap->value->state ? "on" : "off");
> }
> - monitor_printf(mon, "\n");
> }
>
> qapi_free_MigrationCapabilityStatusList(caps);
> --
> 2.7.4
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK