ppc_booke: drop useless assignment

[Qemu-devel] [PATCH] ppc_booke: drop useless assignment

fred.konrad@greensocs.com posted 1 patch 7 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1490360147-26450-1-git-send-email-fred.konrad@greensocs.com

Test checkpatch passed

Test docker passed

Test s390x passed

hw/ppc/ppc_booke.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] ppc_booke: drop useless assignment

Posted by fred.konrad@greensocs.com 7 years, 1 month ago

From: KONRAD Frederic <fred.konrad@greensocs.com>

The tb_env variable is set two lines above. So just drop the double assignment.

Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
---
 hw/ppc/ppc_booke.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c
index 60baffa..23bcf1b 100644
--- a/hw/ppc/ppc_booke.c
+++ b/hw/ppc/ppc_booke.c
@@ -282,7 +282,6 @@ void store_booke_tcr(CPUPPCState *env, target_ulong val)
     ppc_tb_t *tb_env = env->tb_env;
     booke_timer_t *booke_timer = tb_env->opaque;
 
-    tb_env = env->tb_env;
     env->spr[SPR_BOOKE_TCR] = val;
     kvmppc_set_tcr(cpu);
 
-- 
1.8.3.1

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ppc_booke: drop useless assignment

Posted by Laurent Vivier 7 years, 1 month ago

Le 24/03/2017 à 13:55, fred.konrad@greensocs.com a écrit :
> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> The tb_env variable is set two lines above. So just drop the double assignment.
> 
> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
> ---
>  hw/ppc/ppc_booke.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c
> index 60baffa..23bcf1b 100644
> --- a/hw/ppc/ppc_booke.c
> +++ b/hw/ppc/ppc_booke.c
> @@ -282,7 +282,6 @@ void store_booke_tcr(CPUPPCState *env, target_ulong val)
>      ppc_tb_t *tb_env = env->tb_env;
>      booke_timer_t *booke_timer = tb_env->opaque;
>  
> -    tb_env = env->tb_env;
>      env->spr[SPR_BOOKE_TCR] = val;
>      kvmppc_set_tcr(cpu);
>  
> 
Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [Qemu-devel] [PATCH] ppc_booke: drop useless assignment

Posted by Michael Tokarev 7 years ago

24.03.2017 15:55, fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> The tb_env variable is set two lines above. So just drop the double assignment.

Applied to -trivial, thanks!

/mjt