[Qemu-devel] [PATCH 0/3] Add a tester for HMP commands

Thomas Huth posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1490092792-30957-1-git-send-email-thuth@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
There is a newer version of this series
tests/Makefile.include |   2 +
tests/libqtest.c       |  36 +++++++++++
tests/libqtest.h       |   8 +++
tests/pc-cpu-test.c    |  95 +++++++++++------------------
tests/qom-test.c       |  36 ++---------
tests/test-hmp.c       | 160 +++++++++++++++++++++++++++++++++++++++++++++++++
6 files changed, 248 insertions(+), 89 deletions(-)
create mode 100644 tests/test-hmp.c
[Qemu-devel] [PATCH 0/3] Add a tester for HMP commands
Posted by Thomas Huth 7 years, 1 month ago
We currently do not test HMP commands automatically yet, so if they
break, we do not notice this until somebody runs into the problem
(like the "info qtree" problem that we recently had on qemu-system-ppc64).
So let's add a simple tester that runs some HMP commands to check if they
can crash or abort QEMU.

Note: Three boards are currently still blacklisted in the third patch.
I've added the problems to our BiteSizeTasks wiki page, so I hope they
will get fixed by GSoC students or somebody else soon. Once the problems
are fixed, the blacklisting can be removed in the tester, too.

Thomas Huth (3):
  libqtest: Ignore QMP events when parsing the response for HMP commands
  libqtest: Add a generic function to run a callback function for every
    machine
  tests: Add a tester for HMP commands

 tests/Makefile.include |   2 +
 tests/libqtest.c       |  36 +++++++++++
 tests/libqtest.h       |   8 +++
 tests/pc-cpu-test.c    |  95 +++++++++++------------------
 tests/qom-test.c       |  36 ++---------
 tests/test-hmp.c       | 160 +++++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 248 insertions(+), 89 deletions(-)
 create mode 100644 tests/test-hmp.c

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH 0/3] Add a tester for HMP commands
Posted by Dr. David Alan Gilbert 7 years ago
* Thomas Huth (thuth@redhat.com) wrote:
> We currently do not test HMP commands automatically yet, so if they
> break, we do not notice this until somebody runs into the problem
> (like the "info qtree" problem that we recently had on qemu-system-ppc64).
> So let's add a simple tester that runs some HMP commands to check if they
> can crash or abort QEMU.
> 
> Note: Three boards are currently still blacklisted in the third patch.
> I've added the problems to our BiteSizeTasks wiki page, so I hope they
> will get fixed by GSoC students or somebody else soon. Once the problems
> are fixed, the blacklisting can be removed in the tester, too.

Queued

> Thomas Huth (3):
>   libqtest: Ignore QMP events when parsing the response for HMP commands
>   libqtest: Add a generic function to run a callback function for every
>     machine
>   tests: Add a tester for HMP commands
> 
>  tests/Makefile.include |   2 +
>  tests/libqtest.c       |  36 +++++++++++
>  tests/libqtest.h       |   8 +++
>  tests/pc-cpu-test.c    |  95 +++++++++++------------------
>  tests/qom-test.c       |  36 ++---------
>  tests/test-hmp.c       | 160 +++++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 248 insertions(+), 89 deletions(-)
>  create mode 100644 tests/test-hmp.c
> 
> -- 
> 1.8.3.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK