hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices

[Qemu-devel] [PATCH] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices

Thomas Huth posted 1 patch 8 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1489084673-31595-1-git-send-email-thuth@redhat.com

Test checkpatch passed

Test docker passed

hw/ppc/pnv.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices

Posted by Thomas Huth 8 years, 8 months ago

The devices that are derived from TYPE_PNV_CHIP currently show up
as "uncategorized" devices in the help text of "-device ?". Since
they obviously are related to the CPU, let's put them into the
CPU category instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/ppc/pnv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 09f0d22..b97055c 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -722,6 +722,7 @@ static void pnv_chip_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
 
+    set_bit(DEVICE_CATEGORY_CPU, dc->categories);
     dc->realize = pnv_chip_realize;
     dc->props = pnv_chip_properties;
     dc->desc = "PowerNV Chip";
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices

Posted by David Gibson 8 years, 8 months ago

On Thu, Mar 09, 2017 at 07:37:53PM +0100, Thomas Huth wrote:
> The devices that are derived from TYPE_PNV_CHIP currently show up
> as "uncategorized" devices in the help text of "-device ?". Since
> they obviously are related to the CPU, let's put them into the
> CPU category instead.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Applied to ppc-for-2.10.

> ---
>  hw/ppc/pnv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 09f0d22..b97055c 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -722,6 +722,7 @@ static void pnv_chip_class_init(ObjectClass *klass, void *data)
>  {
>      DeviceClass *dc = DEVICE_CLASS(klass);
>  
> +    set_bit(DEVICE_CATEGORY_CPU, dc->categories);
>      dc->realize = pnv_chip_realize;
>      dc->props = pnv_chip_properties;
>      dc->desc = "PowerNV Chip";

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson