target/mips: fix delay slot detection in gen_msa_branch()

[Qemu-devel] [PATCH] target/mips: fix delay slot detection in gen_msa_branch()

Yongbok Kim posted 1 patch 7 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1488903794-10789-1-git-send-email-yongbok.kim@imgtec.com

Test checkpatch passed

Test docker passed

target/mips/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] target/mips: fix delay slot detection in gen_msa_branch()

Posted by Yongbok Kim 7 years, 1 month ago

It is unnecessary to test R6 from delay/forbidden slot check
in gen_msa_branch().

https://bugs.launchpad.net/qemu/+bug/1663287

Reported-by: Brian Campbell <bacam@z273.org.uk>
Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
 target/mips/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index 8b4a072..756a9b7 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -18169,7 +18169,7 @@ static void gen_msa_branch(CPUMIPSState *env, DisasContext *ctx, uint32_t op1)
 
     check_msa_access(ctx);
 
-    if (ctx->insn_flags & ISA_MIPS32R6 && ctx->hflags & MIPS_HFLAG_BMASK) {
+    if (ctx->hflags & MIPS_HFLAG_BMASK) {
         generate_exception_end(ctx, EXCP_RI);
         return;
     }
-- 
2.7.4